Suggestion: build app into binary instead of running Python directly

[ponleou]

Taking inspiration from #43, I suggest we could build the app into a binary using pyinstaller, and execute the binary directly instead of calling python on src/main.py. This has been something I've looked into for a while now, but only got it working with the latest pyinstaller release 2 days ago at v6.20. Before, it would have some issues with GLib 2.88.

The main motivation is so that I can do killall mixtapes to close the app, whereas before I would have to do killall python to close mixtapes, which would also kill any other python processes that were running. This is a command I run rather frequently because of the background player feature (closing the ui doesn't actually kill the process). I would imagine this would come with other pros and cons as well, which is why I want to suggest this first as a discussion.

As I said, I've gotten this to work now using a pyinstaller spec, so if this is a feature we are willing to have, I can quickly make a PR for review.

[m-obeid]

Sounds good to me
I'm not sure how this would affect Windows users of Mixtapes or the upcoming Mac support

[ponleou]

This would only change the install process, so it doesn't affect anything core to the code, and running the app with Python directly is still an option. I would imagine a change in PKGBUILD for AUR packaging at most, and perhaps documentation in readme for those who also wants to go with the build approach.

However, since #45 is merged, this isn't a priority development for me anymore. Though if we wish to go with this approach, I'd be happy to put some time into it.

[tanaybhomia]

Yes because the app does feel very very slow.

[ponleou]

@tanaybhomia Pyinstaller build doesn't improve performance afaik, might look into some sort of C-based builder. Though I feel like this issue kinda lost its purpose. Perhaps it could stay to think about building for performance

[ponleou]

#53 now uses Nuitka to build, which should theoretically improve performance. I don't notice much from my side, so I'd appreciate any testers :)

[tanaybhomia]

I wouldve loved to test the build , but seems it was only built for AUR packages which I am not using. I am currently on the flathub user build

[ponleou]

If you want, you could also follow the build instruction from source, which is also added in the PR

or by

git clone https://github.com/ponleou/Mixtapes.git -b chore/nuitka
cd Mixtapes
python -m venv .venv
source .venv/bin/activate
pip install -r requirements.txt
pip install nuitka
nuitka --clang --include-package=ui --include-package=api --include-package=player --include-module=logger --output-filename=mixtapes src/main.py 
./mixtapes

Unfortunately, not too familiar with flathub packaging, but I'm sure it would be possible to incorporate the build process into it as well

[ponleou]

Yes because the app does feel very very slow.

I accidentally found something very surprising. Apparently, a lot of the stutter happens when scrolling while the cursor is on hoverable elements. If I move the cursor to the side and scroll, the app is smooth as butter. See the video below:

mixtapes_stutter_scroll.mp4

@tanaybhomia is the stutter scrolling what you also mean by feeling very very slow? Or are there other slowness that you are noticing? I also really want to work on making the app feel a lot faster, which would help by identifying other parts that feel slow. That said, I also notice stutters when opening a playlist with a lot of music.

[tanaybhomia]

By slowness I meant that the actual loading of the app and actual playing the song. The app takes some time to load fully and then when I am playing a song it again takes some time to load the song. And yes when the cursor stays on the hoverable items the app does stutter but doesnt do so when the cursor is only on the app.