Skip to content

Commit e19d6b7

Browse files
committed
add logging
1 parent e2a6e93 commit e19d6b7

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

pkg/controller/flink/client/api.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,8 @@ func (c *FlinkJobManagerClient) ForceCancelJob(ctx context.Context, url string,
215215
url = url + path + "?mode=cancel"
216216

217217
response, err := c.executeRequest(ctx, httpPatch, url, nil)
218+
logger.Info(ctx, "response is ", response)
219+
logger.Info(ctx, "err is ", err)
218220
if err != nil {
219221
c.metrics.forceCancelJobFailureCounter.Inc(ctx)
220222
logger.Errorf(ctx, fmt.Sprintf("Force cancel job failed with error %v", err))
@@ -225,7 +227,7 @@ func (c *FlinkJobManagerClient) ForceCancelJob(ctx context.Context, url string,
225227
logger.Errorf(ctx, fmt.Sprintf("Force cancel job failed with response %v", response))
226228
return GetRetryableError(err, v1beta1.ForceCancelJob, response.Status(), DefaultRetries)
227229
}
228-
230+
logger.Info(ctx, "Successfully cancelled the job")
229231
c.metrics.forceCancelJobSuccessCounter.Inc(ctx)
230232
return nil
231233
}

pkg/controller/flinkapplication/flink_state_machine.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -984,6 +984,7 @@ func (s *FlinkStateMachine) handleApplicationDeleting(ctx context.Context, app *
984984
}
985985
job, err := s.flinkController.GetJobForApplication(ctx, app, app.Status.DeployHash)
986986
if err != nil {
987+
logger.Warn(ctx, "Error: "+err.Error(), err)
987988
return statusUnchanged, err
988989
}
989990

@@ -995,6 +996,7 @@ func (s *FlinkStateMachine) handleApplicationDeleting(ctx context.Context, app *
995996
case v1beta1.DeleteModeForceCancel:
996997
if job.State == client.Cancelling {
997998
// we've already cancelled the job, waiting for it to finish
999+
logger.Info(ctx, "Still in cancelling..")
9981000
return statusUnchanged, nil
9991001
} else if jobFinished(job) {
10001002
// job was successfully cancelled

0 commit comments

Comments
 (0)