random freeze/crash when copying text with mouse

[zarnovican]

Problem description

I'm experiencing random hangs and codedump of the whole lxterminal. It happens most frequently when I copy text by double-clicking left mouse button. It is not consistently reproducible. I would say it happens ~1% of the time.

Here is the stacktrace I found in journal from the most recent crash:

Mar 07 16:14:25 laptop systemd-coredump[5495]: Process 4767 (lxterminal) of user 1000 dumped core.
                                               
                                               Stack trace of thread 4767:
                                               #0  0x00007f3376d1ceab raise (libc.so.6)
                                               #1  0x00007f3376d075b9 abort (libc.so.6)
                                               #2  0x00007f3376d07491 __assert_fail_base.cold.0 (libc.so.6)
                                               #3  0x00007f3376d15612 __assert_fail (libc.so.6)
                                               #4  0x00007f337751939a poll_for_event (libX11.so.6)
                                               #5  0x00007f337751943e poll_for_response (libX11.so.6)
                                               #6  0x00007f3377519735 _XEventsQueued (libX11.so.6)
                                               #7  0x00007f337751c3f8 _XData32 (libX11.so.6)
                                               #8  0x00007f33774f5d0c XChangeProperty (libX11.so.6)
                                               #9  0x00007f33793fde25 gdk_window_set_icon_list (libgdk-x11-2.0.so.0)
                                               #10 0x00007f33798d3e95 gtk_window_realize_icon (libgtk-x11-2.0.so.0)
                                               #11 0x00007f33798d9b97 gtk_window_realize (libgtk-x11-2.0.so.0)
                                               #12 0x00007f3377fc1c8d g_closure_invoke (libgobject-2.0.so.0)
                                               #13 0x00007f3377fd5386 signal_emit_unlocked_R (libgobject-2.0.so.0)
                                               #14 0x00007f3377fde30a g_signal_emit_valist (libgobject-2.0.so.0)
                                               #15 0x00007f3377fde903 g_signal_emit (libgobject-2.0.so.0)
                                               #16 0x00007f33798cc7a4 gtk_widget_realize (libgtk-x11-2.0.so.0)
                                               #17 0x00007f33798d7be8 gtk_window_show (libgtk-x11-2.0.so.0)
                                               #18 0x00007f3377fc1c8d g_closure_invoke (libgobject-2.0.so.0)
                                               #19 0x00007f3377fd5386 signal_emit_unlocked_R (libgobject-2.0.so.0)
                                               #20 0x00007f3377fde30a g_signal_emit_valist (libgobject-2.0.so.0)
                                               #21 0x00007f3377fde903 g_signal_emit (libgobject-2.0.so.0)
                                               #22 0x00007f33798cbd96 gtk_widget_show (libgtk-x11-2.0.so.0)
                                               #23 0x000055e67e631c91 lxterminal_initialize (lxterminal)
                                               #24 0x000055e67e62c9ea handle_request (lxterminal)
                                               #25 0x00007f3379d2291d g_main_context_dispatch (libglib-2.0.so.0)
                                               #26 0x00007f3379d22ce8 g_main_context_iterate.isra.21 (libglib-2.0.so.0)
                                               #27 0x00007f3379d23012 g_main_loop_run (libglib-2.0.so.0)
                                               #28 0x00007f337978e95f gtk_main (libgtk-x11-2.0.so.0)
                                               #29 0x000055e67e62c7bb main (lxterminal)
                                               #30 0x00007f3376d0911b __libc_start_main (libc.so.6)
                                               #31 0x000055e67e62c7fa _start (lxterminal)
                                               
                                               Stack trace of thread 4770:
                                               #0  0x00007f3376dd5429 __poll (libc.so.6)
                                               #1  0x00007f3379d22c56 g_main_context_iterate.isra.21 (libglib-2.0.so.0)
                                               #2  0x00007f3379d22d80 g_main_context_iteration (libglib-2.0.so.0)
                                               #3  0x00007f3379d22dd1 glib_worker_main (libglib-2.0.so.0)
                                               #4  0x00007f3379d4b01a g_thread_proxy (libglib-2.0.so.0)
                                               #5  0x00007f33770ac594 start_thread (libpthread.so.0)
                                               #6  0x00007f3376ddff4f __clone (libc.so.6)
                                               
                                               Stack trace of thread 4775:
                                               #0  0x00007f3376dd5429 __poll (libc.so.6)
                                               #1  0x00007f3379d22c56 g_main_context_iterate.isra.21 (libglib-2.0.so.0)
                                               #2  0x00007f3379d23012 g_main_loop_run (libglib-2.0.so.0)
                                               #3  0x00007f337873485a gdbus_shared_thread_func (libgio-2.0.so.0)
                                               #4  0x00007f3379d4b01a g_thread_proxy (libglib-2.0.so.0)
                                               #5  0x00007f33770ac594 start_thread (libpthread.so.0)
                                               #6  0x00007f3376ddff4f __clone (libc.so.6)

...
Mar 07 16:14:26 laptop abrt-notification[5586]: Process 18557 (lxterminal) crashed in _nl_load_domain.cold.0()

If the problem is not in your code, can you tell me on which project should I open the ticket ? I cannot decypher it from the stacktrace.

Versions:

• lxterminal-0.3.2-1.fc28.x86_64
• libX11-1.6.5-7.fc28.x86_64
• Linux laptop 4.17.18-200.fc28.x86_64 feature request: move a tab into its own window #1 SMP Wed Aug 22 19:08:07 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Additional info:

• it started happening after upgrading from LXDE Fedora 26? to 28.
• AFAIK, I have just basic lxterminal customization (scrollback lines increased, hidden some UI elements, etc)
• I usually disable the default clipit app after OS installation (I will try to have it running, just to see if it happens again)
• it never hangs on "paste" (middle button). Only "copy" is the problem.

[zarnovican]

This issue stopped happening after one of the Fedora upgrades. Thanks, nameless hero, for fixing it !