Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] IR intensity calculation is wrong in Camera::parameterCB #646

Open
2 tasks done
xhu4 opened this issue Jan 3, 2025 · 0 comments
Open
2 tasks done

[BUG] IR intensity calculation is wrong in Camera::parameterCB #646

xhu4 opened this issue Jan 3, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@xhu4
Copy link

xhu4 commented Jan 3, 2025

Check if issue already exists

  • Google it (e.g. error xy github luxonis depthai)
  • Check troubleshooting in documentation.

Describe the bug
Division order seems to be wrong for ir laser dot intensity and flood intensity in Camera::parameterCB.
https://github.com/luxonis/depthai-ros/blob/humble/depthai_ros_driver/src/camera.cpp#L288-L300

            if(p.get_name() == ph->getFullParamName("i_laser_dot_brightness")) {
                float laserdotBrightness = float(p.get_value<int>());
                if(laserdotBrightness > 1.0) {
>>>>                laserdotBrightness = 1200.0 / laserdotBrightness;
                }
                device->setIrLaserDotProjectorIntensity(laserdotBrightness);
            } else if(p.get_name() == ph->getFullParamName("i_floodlight_brightness")) {
                float floodlightBrightness = float(p.get_value<int>());
                if(floodlightBrightness > 1.0) {
>>>>                floodlightBrightness = 1500.0 / floodlightBrightness;
                }
                device->setIrFloodLightIntensity(floodlightBrightness);
            }
@xhu4 xhu4 added the bug Something isn't working label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant