Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formula issue in generator_math.png #3

Open
jinyuanwong opened this issue Apr 2, 2024 · 1 comment
Open

Formula issue in generator_math.png #3

jinyuanwong opened this issue Apr 2, 2024 · 1 comment

Comments

@jinyuanwong
Copy link

G(z) is redundant in the formula, in which I added a text to point out.

Screenshot 2024-04-02 at 15 59 37
@terry891
Copy link

terry891 commented Jun 10, 2024

Hi @luisguiserrano, your video about GAN is informative and easy-to-follow! Thanks a lot!
@jinyuanwong, thanks for pointing this formula issue. I noticed it too and found it to be more than a redundant term.

Actually, this is supposed to be W_i instead, coming from the partial derivative ∂D/∂G. Below should be the correct formula from my understanding
generator_math

This corrected math formula is reflected truthfully in the codes, which is correct.
factor = -(1-dgz) * discriminator_weights * gz *(1-gz)

@luisguiserrano, if you approve it, perhaps you can modify the LaTeX for this image? Thanks again for the great video!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants