Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially an issue in ubuntu_install_prereqs.sh? #6

Open
mal-w opened this issue Apr 4, 2022 · 2 comments
Open

Potentially an issue in ubuntu_install_prereqs.sh? #6

mal-w opened this issue Apr 4, 2022 · 2 comments

Comments

@mal-w
Copy link

mal-w commented Apr 4, 2022

I'm not really a bash expert but this code was causing issues... It seemed like I was never getting passed the lsb_release checks... Of all things, removing the -e from the set worked... as you can see in the below diff...

-set -euo pipefail
+set -uo pipefail
 IFS=$'\n\t'
 
 # Check if it's Ubuntu 18.04 or 20.04
+# I believe there is a lack of compatibility between using the -e and the following
+# code...
 lsb_release -d | grep -qi '18.04'; is_ubuntu_18=$?
 lsb_release -d | grep -qi '20.04'; is_ubuntu_20=$?
 if [ $is_ubuntu_18 -ne 0 -a $is_ubuntu_20 -ne 0 ]; then
@mal-w
Copy link
Author

mal-w commented Apr 4, 2022

Obviously this causes other issues further on in the execution of the script on re-run... so it's not the correct solution... It was enough to get it to install the dependencies, but I think I would need to understand better what the failure is on the lines where the release is being checked...

@luiscastilho
Copy link
Owner

Hello! Sorry for the late reply. I'm making some changes to dungeoneering (adapting it to Processing 4) and if everything goes according to plan it will use a more recent version of GStreamer. If that works, this script shouldn't be needed anymore. I will update this issue when I get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants