Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NET 8.0 #316

Open
RomanLeonB opened this issue Dec 17, 2024 · 3 comments
Open

Add support for NET 8.0 #316

RomanLeonB opened this issue Dec 17, 2024 · 3 comments
Assignees
@luigiberrettini
Labels
enhancement

Comments

@RomanLeonB
Copy link

RomanLeonB commented Dec 17, 2024 •
edited
Loading

Describe the problem to solve
I want to add NLog.Targets.Syslog to a NET 8.0 application

Describe the enhancement proposed
Upgrade *.csproj to NET 8.0

I can also upgrade the *.csproj files if that's okay with you.
@RomanLeonB RomanLeonB changed the title Support for NET8 Add support for NET 8.0 Dec 17, 2024
@snakefoot
Copy link
Contributor

Maybe just remove net6.0 and just rely on netstandard2.0 ?

@RomanLeonB
Copy link
Author

RomanLeonB commented Dec 18, 2024 •
edited
Loading

I think this is not possible, because TestAppWithGU and TestAppWithTUI does explicitly use net6.0 or net6.0-windows
Or do you mean to set all targets to netstandard2.0?

My suggestion:
Remove net6.0 support in FakeSyslogServer
Remove net6.0 support in NLog.Targets.Syslog.Schema
Remove net6.0 support in NLog.Targets.Syslog
Upgrade TestAppWithGUI to net8.0
Upgrade TestAppWithTUI to net8.0

RomanLeonB pushed a commit to RomanLeonB/NLog.Targets.Syslog that referenced this issue Dec 18, 2024
Remove net6.0 support in FakeSyslogServer
0cedbff 
Closes luigiberrettini#316
RomanLeonB pushed a commit to RomanLeonB/NLog.Targets.Syslog that referenced this issue Dec 18, 2024
Remove net6.0 support in NLog.Targets.Syslog.Schema
2bf8870 
Closes luigiberrettini#316
RomanLeonB pushed a commit to RomanLeonB/NLog.Targets.Syslog that referenced this issue Dec 18, 2024
Remove net6.0 support in NLog.Targets.Syslog
d6e3379 
Closes luigiberrettini#316
RomanLeonB pushed a commit to RomanLeonB/NLog.Targets.Syslog that referenced this issue Dec 18, 2024
Upgrade TestAppWithGUI to net8.0
96c366b 
Closes luigiberrettini#316
RomanLeonB pushed a commit to RomanLeonB/NLog.Targets.Syslog that referenced this issue Dec 18, 2024
Upgrade TestAppWithTUI to net8.0
e0254e3 
Closes luigiberrettini#316
@RomanLeonB RomanLeonB mentioned this issue Dec 18, 2024
Closed
@RomanLeonB
Copy link
Author

Maybe just remove net6.0 and just rely on netstandard2.0 ?

I may have been too hasty with my solution. Do you agree with my suggestion so that I can create a PR afterwards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luigiberrettini luigiberrettini

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luigiberrettini @snakefoot @RomanLeonB