Skip to content

Commit afeeb6b

Browse files
committed
Rename Scala toolchains to avoid conflicts with other repos
Because we're using strings, names like zinc_3 would likely conflict in other repos.
1 parent 83d049c commit afeeb6b

File tree

22 files changed

+38
-38
lines changed

22 files changed

+38
-38
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ load("@rules_scala_annex//rules/scala:workspace.bzl", "scala_register_toolchains
7474
scala_repositories()
7575
load("@annex//:defs.bzl", annex_pinned_maven_install = "pinned_maven_install")
7676
annex_pinned_maven_install()
77-
scala_register_toolchains(default_scala_toolchain_name = "zinc_3")
77+
scala_register_toolchains(default_scala_toolchain_name = "annex_zinc_3")
7878

7979
load("@rules_scala_annex//rules/scalafmt:workspace.bzl", "scalafmt_default_config", "scalafmt_repositories")
8080
scalafmt_repositories()
@@ -116,7 +116,7 @@ protobuf_deps()
116116
# Specify the scala compiler we wish to use; in this case, we'll use the default one specified in rules_scala_annex
117117
bind(
118118
name = "default_scala",
119-
actual = "@rules_scala_annex//src/main/scala:zinc_2_13",
119+
actual = "@rules_scala_annex//src/main/scala:annex_zinc_2_13",
120120
)
121121
```
122122

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ load("@annex//:defs.bzl", annex_pinned_maven_install = "pinned_maven_install")
101101

102102
annex_pinned_maven_install()
103103

104-
scala_register_toolchains(default_scala_toolchain_name = "zinc_2_13")
104+
scala_register_toolchains(default_scala_toolchain_name = "annex_zinc_2_13")
105105

106106
# Scala 2.12
107107

docs/newdocs/scala_versions.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ compiler_classpath_2_13 = [
3535
runtime_classpath_2_13 = ["@scala_library_2_13//jar"]
3636

3737
register_bootstrap_toolchain(
38-
name = "bootstrap_2_13",
38+
name = "annex_bootstrap_2_13",
3939
compiler_classpath = compiler_classpath_2_13,
4040
runtime_classpath = runtime_classpath_2_13,
4141
version = "2.13.14",
@@ -46,7 +46,7 @@ register_bootstrap_toolchain(
4646
scala_library(
4747
name = "compiler_bridge_2_13",
4848
srcs = ["@compiler_bridge_2_13//:src"],
49-
scala_toolchain_name = "bootstrap_2_13",
49+
scala_toolchain_name = "annex_bootstrap_2_13",
5050
visibility = ["//visibility:public"],
5151
deps = compiler_classpath_2_13 + [
5252
"@scala_annex_org_scala_sbt_compiler_interface//jar",
@@ -56,7 +56,7 @@ scala_library(
5656

5757
# This augments the configuration to configure the zinc compiler
5858
register_zinc_toolchain(
59-
name = "zinc_2_13",
59+
name = "annex_zinc_2_13",
6060
compiler_bridge = ":compiler_bridge_2_13",
6161
compiler_classpath = compiler_classpath_2_13,
6262
runtime_classpath = runtime_classpath_2_13,
@@ -72,8 +72,8 @@ load("@rules_scala_annex//rules/scala:workspace.bzl", "scala_register_toolchains
7272
...
7373

7474
scala_register_toolchains(
75-
toolchains = ["//:bootstrap_2_13", "//:zinc_2_13"],
76-
default_scala_toolchain_name = "zinc_2_13",
75+
toolchains = ["//:annex_bootstrap_2_13", "//:annex_zinc_2_13"],
76+
default_scala_toolchain_name = "annex_zinc_2_13",
7777
)
7878

7979
...
@@ -90,13 +90,13 @@ For example:
9090
scala_library(
9191
name = "example_compiled_with_scalac",
9292
srcs = glob(["**/*.scala"])
93-
scala_toolchain_name = "bootstrap_2_13",
93+
scala_toolchain_name = "annex_bootstrap_2_13",
9494
)
9595

9696
scala_library(
9797
name = "example_compiled_with_zinc",
9898
srcs = glob(["**/*.scala"])
99-
scala_toolchain_name = "zinc_2_13",
99+
scala_toolchain_name = "annex_zinc_2_13",
100100
)
101101

102102
# This would use the default toolchain, which we configured via `scala_register_toolchains` above

rules/scala/workspace.bzl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ def scala_register_toolchains(default_scala_toolchain_name, toolchains = []):
135135
)
136136

137137
native.register_toolchains(
138-
"//src/main/scala:bootstrap_2_13",
139-
"//src/main/scala:bootstrap_3",
140-
"//src/main/scala:zinc_2_13",
141-
"//src/main/scala:zinc_3",
138+
"//src/main/scala:annex_bootstrap_2_13",
139+
"//src/main/scala:annex_bootstrap_3",
140+
"//src/main/scala:annex_zinc_2_13",
141+
"//src/main/scala:annex_zinc_3",
142142
*toolchains
143143
)

rules/scala_proto/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ scala_binary(
1616
name = "worker",
1717
srcs = ["private/ScalaProtoWorker.scala"],
1818
main_class = "annex.scala.proto.ScalaProtoWorker",
19-
scala_toolchain_name = "zinc_3",
19+
scala_toolchain_name = "annex_zinc_3",
2020
visibility = ["//visibility:public"],
2121
deps = [
2222
"//src/main/scala/higherkindness/rules_scala/common/args",

rules/scalafmt/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ scala_binary(
2121
name = "scalafmt",
2222
srcs = glob(["scalafmt/**/*.scala"]),
2323
main_class = "annex.scalafmt.ScalafmtRunner",
24-
scala_toolchain_name = "bootstrap_2_13",
24+
scala_toolchain_name = "annex_bootstrap_2_13",
2525
visibility = ["//visibility:public"],
2626
deps = [
2727
"//src/main/scala/higherkindness/rules_scala/common/interrupt",

src/main/scala/BUILD

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ shared_scala2_global_scalacopts = [
2727
scala2_global_scalacopts = shared_global_scalacopts + shared_scala2_global_scalacopts
2828

2929
register_bootstrap_toolchain(
30-
name = "bootstrap_2_13",
30+
name = "annex_bootstrap_2_13",
3131
compiler_classpath = compiler_classpath_2_13,
3232
global_scalacopts = scala2_global_scalacopts,
3333
runtime_classpath = runtime_classpath_2_13,
@@ -36,7 +36,7 @@ register_bootstrap_toolchain(
3636
)
3737

3838
register_zinc_toolchain(
39-
name = "zinc_2_13",
39+
name = "annex_zinc_2_13",
4040
compiler_bridge = "@annex//:org_scala_sbt_compiler_bridge_2_13",
4141
compiler_classpath = compiler_classpath_2_13,
4242
global_scalacopts = scala2_global_scalacopts,
@@ -52,7 +52,7 @@ register_zinc_toolchain(
5252
scala_library(
5353
name = "scala-sdk",
5454
deps_used_whitelist = compiler_classpath_2_13,
55-
scala_toolchain_name = "zinc_3",
55+
scala_toolchain_name = "annex_zinc_3",
5656
deps = compiler_classpath_2_13,
5757
)
5858

@@ -70,12 +70,12 @@ runtime_classpath_3 = [
7070
scala_library(
7171
name = "scala-sdk-3",
7272
deps_used_whitelist = compiler_classpath_3,
73-
scala_toolchain_name = "zinc_3",
73+
scala_toolchain_name = "annex_zinc_3",
7474
deps = compiler_classpath_3,
7575
)
7676

7777
register_bootstrap_toolchain(
78-
name = "bootstrap_3",
78+
name = "annex_bootstrap_3",
7979
compiler_classpath = compiler_classpath_3,
8080
global_scalacopts = shared_global_scalacopts,
8181
runtime_classpath = runtime_classpath_3,
@@ -85,7 +85,7 @@ register_bootstrap_toolchain(
8585
)
8686

8787
register_zinc_toolchain(
88-
name = "zinc_3",
88+
name = "annex_zinc_3",
8989
compiler_bridge = "@annex//:org_scala_lang_scala3_sbt_bridge",
9090
compiler_classpath = compiler_classpath_3,
9191
global_scalacopts = shared_global_scalacopts,

src/main/scala/higherkindness/rules_scala/common/args/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("//rules:scalafmt.bzl", "scala_format_test")
44
scala_library(
55
name = "args",
66
srcs = glob(["**/*.scala"]),
7-
scala_toolchain_name = "bootstrap_2_13",
7+
scala_toolchain_name = "annex_bootstrap_2_13",
88
visibility = ["//visibility:public"],
99
deps = [
1010
"//src/main/scala/higherkindness/rules_scala/common/error",

src/main/scala/higherkindness/rules_scala/common/classloaders/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("//rules:scalafmt.bzl", "scala_format_test")
44
scala_library(
55
name = "classloaders",
66
srcs = glob(["**/*.scala"]),
7-
scala_toolchain_name = "bootstrap_2_13",
7+
scala_toolchain_name = "annex_bootstrap_2_13",
88
visibility = ["//visibility:public"],
99
)
1010

src/main/scala/higherkindness/rules_scala/common/error/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ load("//rules:scalafmt.bzl", "scala_format_test")
44
scala_library(
55
name = "error",
66
srcs = glob(["**/*.scala"]),
7-
scala_toolchain_name = "bootstrap_2_13",
7+
scala_toolchain_name = "annex_bootstrap_2_13",
88
visibility = ["//visibility:public"],
99
)
1010

0 commit comments

Comments
 (0)