Skip to content

Commit 5de9438

Browse files
author
Jaden Peterson
committed
Made as many dependencies dev dependencies as can be
1 parent 4c0ec8d commit 5de9438

File tree

10 files changed

+79
-486
lines changed

10 files changed

+79
-486
lines changed

BUILD

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
load("@buildifier_prebuilt//:rules.bzl", "buildifier")
21
load(
32
"@rules_java//toolchains:default_java_toolchain.bzl",
43
"DEFAULT_TOOLCHAIN_CONFIGURATION",
@@ -19,12 +18,3 @@ register_scalafmt_toolchain(
1918
name = "annex_scalafmt",
2019
config = ".scalafmt.conf",
2120
)
22-
23-
buildifier(
24-
name = "buildifier",
25-
)
26-
27-
buildifier(
28-
name = "buildifier_check",
29-
mode = "check",
30-
)

MODULE.bazel

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ module(name = "rules_scala_annex")
22

33
bazel_dep(name = "bazel_skylib", version = "1.7.1")
44

5-
# TODO: Use buildifier instead of buildifier_prebuilt once
6-
# https://github.com/bazelbuild/bazel-central-registry/issues/380 is resolved
7-
bazel_dep(name = "buildifier_prebuilt", version = "7.3.1")
5+
bazel_dep(name = "buildifier_prebuilt", version = "7.3.1", dev_dependency = True)
6+
87
bazel_dep(name = "rules_java", version = "7.12.2")
98
bazel_dep(name = "rules_jvm_external", version = "6.5")
10-
bazel_dep(name = "rules_pkg", version = "1.0.1")
11-
bazel_dep(name = "stardoc", version = "0.7.1")
9+
10+
bazel_dep(name = "rules_pkg", version = "1.0.1", dev_dependency = True)
11+
bazel_dep(name = "stardoc", version = "0.7.1", dev_dependency = True)
1212

1313
register_toolchains(
1414
"//:annex_scalafmt",

dev/BUILD

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
load("@buildifier_prebuilt//:rules.bzl", "buildifier")
2+
3+
buildifier(
4+
name = "buildifier",
5+
)
6+
7+
buildifier(
8+
name = "buildifier_check",
9+
mode = "check",
10+
)

dev/stardoc/BUILD

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
load("@rules_pkg//pkg:pkg.bzl", "pkg_tar")
2+
load("@stardoc//stardoc:stardoc.bzl", "stardoc")
3+
load(":stardoc.bzl", "stardoc_targets")
4+
5+
[
6+
stardoc(
7+
name = stardoc_target.name,
8+
out = stardoc_target.out,
9+
input = stardoc_target.input,
10+
deps = ["//rules:scala-rules"],
11+
)
12+
for stardoc_target in stardoc_targets
13+
]
14+
15+
pkg_tar(
16+
name = "docs",
17+
srcs = [stardoc_target.out for stardoc_target in stardoc_targets],
18+
mode = "0644",
19+
)

rules/stardoc.bzl renamed to dev/stardoc/stardoc.bzl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
load("@bazel_skylib//lib:paths.bzl", "paths")
22

33
_bzl_files_containing_rules = [
4-
"scala.bzl",
5-
"scala_proto.bzl",
6-
"scala_with_scalafmt.bzl",
7-
"scalafmt.bzl",
4+
"//rules:scala.bzl",
5+
"//rules:scala_proto.bzl",
6+
"//rules:scala_with_scalafmt.bzl",
7+
"//rules:scalafmt.bzl",
88
"//rules/scalafmt:register_toolchain.bzl",
99
]
1010

1111
def _get_stardoc_targets():
1212
result = []
1313

1414
for label in _bzl_files_containing_rules:
15-
sanitized_name = label.removeprefix("//rules/").replace(":", "_")
15+
sanitized_name = label.removeprefix("//rules:").removeprefix("//rules/").replace(":", "_")
1616

1717
result.append(
1818
struct(

rules/BUILD

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,11 @@
11
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
2-
load("@rules_pkg//pkg:pkg.bzl", "pkg_tar")
3-
load("@stardoc//stardoc:stardoc.bzl", "stardoc")
4-
load(":stardoc.bzl", "stardoc_targets")
52

6-
[
7-
stardoc(
8-
name = stardoc_target.name,
9-
out = stardoc_target.out,
10-
input = stardoc_target.input,
11-
deps = [":scala-rules"],
12-
)
13-
for stardoc_target in stardoc_targets
14-
]
15-
16-
pkg_tar(
17-
name = "docs",
18-
srcs = [stardoc_target.out for stardoc_target in stardoc_targets],
19-
mode = "0644",
20-
)
3+
exports_files([
4+
"scala.bzl",
5+
"scala_proto.bzl",
6+
"scala_with_scalafmt.bzl",
7+
"scalafmt.bzl",
8+
])
219

2210
bzl_library(
2311
name = "bazel_tools_build_defs_repo",

scripts/format.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ else
1515
fi
1616

1717
if [ "$1" != check ]; then
18-
bazel run buildifier
18+
bazel run //dev:buildifier
1919
else
20-
bazel run buildifier_check
20+
bazel run //dev:buildifier_check
2121
fi

scripts/gen-docs.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ set -x
1111

1212
rm -fr docs/stardoc
1313
mkdir -p docs/stardoc
14-
bazel build rules:docs
15-
tar xf "$(bazel info bazel-bin)/rules/docs.tar" -C docs/stardoc
14+
bazel build //dev/stardoc:docs
15+
tar xf "$(bazel info bazel-bin)/dev/stardoc/docs.tar" -C docs/stardoc

tests/MODULE.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
module(name = "rules_scala_annex_tests")
22

3-
bazel_dep(name = "bazel_skylib", version = "1.7.1")
43
bazel_dep(name = "rules_java", version = "7.12.2")
54
bazel_dep(name = "rules_jvm_external", version = "6.5")
65
bazel_dep(name = "rules_scala_annex")

tests/MODULE.bazel.lock

Lines changed: 30 additions & 443 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)