Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw by agreement - make LegalPlayer not stuck #161

Open
lrozenblyum opened this issue Feb 3, 2016 · 5 comments
Open

Draw by agreement - make LegalPlayer not stuck #161

lrozenblyum opened this issue Feb 3, 2016 · 5 comments
Assignees
@lrozenblyum
Labels
core LegalPlayer, Position and related finiteGame rules
Milestone
0.8

Comments

@lrozenblyum
Copy link
Owner

Child of #154
Probably better to offer draw only after it moved?

Now if LegalPlayer offers draw it waits infinitely and doesn't execute the usual move itself.

So far disabled the special move evaluator.
@lrozenblyum lrozenblyum mentioned this issue Feb 3, 2016
Open
lrozenblyum added a commit that referenced this issue Feb 3, 2016
@lrozenblyum
Disabled special moves evaluator till #161
b8f6d64
lrozenblyum added a commit that referenced this issue Nov 16, 2016
@lrozenblyum
Removed need to treat 'special moves' in a special way.
542e440 
It simplifies the code but it reveals our old issue #161.

Consider it as a breaking change! Don't merge to master till it's not handled.
@lrozenblyum
Copy link
Owner Author

a) If LegalPlayer offers draw before his move he should wait some time before opponent's reaction?
if no answer from the opponent - think about the next move

b) if LegalPlayer offers draw after his move - no problems?

c) Disallow Offer draw immediately after offer draw?

lrozenblyum added a commit that referenced this issue Nov 20, 2016
@lrozenblyum
Filter out offer draws till #161 is implemented.
d5eac51
@lrozenblyum lrozenblyum mentioned this issue Nov 20, 2016
Merged
lrozenblyum added a commit that referenced this issue Feb 12, 2017
@lrozenblyum
Experiment to allow decision makers return multiple moves.
5b70475 
It also can make us closer to goal of implementing #161
lrozenblyum added a commit that referenced this issue Feb 16, 2017
@lrozenblyum
Multiple moves experiment continued. Allow a player send multiple mov…
437685c 
…es at once to another player.

This will potentially allow us not only simulate Simple Player in Legal Player but also at least particularly implement #161
@lrozenblyum lrozenblyum self-assigned this Feb 23, 2017
@lrozenblyum lrozenblyum added this to the 0.2 milestone Feb 23, 2017
@lrozenblyum
Copy link
Owner Author

It might be implemented during #198

@lrozenblyum lrozenblyum mentioned this issue Mar 7, 2017
Merged
@lrozenblyum
Copy link
Owner Author

Probably we should redesign this issue into the following:
LegalPlayer's evaluators should be taught about the possibility to make several moves at once.

If they just execute OFFER_DRAW it can be considered a problem of brain. They should execute it in pair with another move.

@lrozenblyum lrozenblyum removed this from the 0.2 milestone Apr 7, 2017
@lrozenblyum
Copy link
Owner Author

Maybe this explanation is also relevant: http://www.talkchess.com/forum/viewtopic.php?topic_view=threads&p=582928&t=53265

@lrozenblyum lrozenblyum mentioned this issue Dec 25, 2018
Closed
@lrozenblyum lrozenblyum added rules core LegalPlayer, Position and related labels Dec 26, 2018
@lrozenblyum lrozenblyum mentioned this issue Jan 6, 2019
Merged
@lrozenblyum lrozenblyum added this to the 0.5 milestone Jan 6, 2019
@lrozenblyum lrozenblyum mentioned this issue Feb 7, 2019
Open
@lrozenblyum lrozenblyum modified the milestones: 0.5, 0.6 Feb 16, 2019
@lrozenblyum lrozenblyum modified the milestones: 0.6, 0.7 Aug 20, 2019
@lrozenblyum lrozenblyum mentioned this issue Aug 25, 2019
Closed
15 tasks
@lrozenblyum
Copy link
Owner Author

LegalPlayer just exits in a simulation 'random vs random' when one of the opponents sends 'OFFER_DRAW'!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrozenblyum lrozenblyum

Labels
core LegalPlayer, Position and related finiteGame rules
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
1 participant
@lrozenblyum