Skip to content

Commit 75c0075

Browse files
committed
Adjust review comments for interrupt logic
1 parent ed9db92 commit 75c0075

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

rtl/system/ibex_demo_system.sv

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ module ibex_demo_system #(
7171
parameter logic [31:0] SIM_CTRL_START = 32'h20000;
7272
parameter logic [31:0] SIM_CTRL_MASK = ~(SIM_CTRL_SIZE-1);
7373

74-
localparam logic [31:0] PLIC_SIZE = 4 * 1024; // 4 KiB
75-
localparam logic [31:0] PLIC_START = 32'h80005000;
74+
localparam logic [31:0] PLIC_SIZE = 64 * 1024; // 64 KiB
75+
localparam logic [31:0] PLIC_START = 32'h8010000;
7676
localparam logic [31:0] PLIC_MASK = ~(PLIC_SIZE-1);
7777

7878
// Debug functionality is optional.
@@ -285,7 +285,7 @@ module ibex_demo_system #(
285285
.irq_software_i(1'b0),
286286
.irq_timer_i (timer_irq),
287287
.irq_external_i(irq_external),
288-
.irq_fast_i (1'b0),
288+
.irq_fast_i (15'b0),
289289
.irq_nm_i (1'b0),
290290

291291
.scramble_key_valid_i('0),
@@ -502,6 +502,11 @@ module ibex_demo_system #(
502502
assign ndmreset_req = 1'b0;
503503
end
504504

505+
// Interrupt signals
506+
logic [31:0] irq_sources;
507+
logic [31:0] irq_pending;
508+
logic irq_external;
509+
505510
assign irq_sources = {
506511
16'b0, // Reserved
507512
15'b0, // Reserved
@@ -550,3 +555,4 @@ module ibex_demo_system #(
550555
endfunction
551556
`endif
552557
endmodule
558+

rtl/system/plic.sv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,4 +150,4 @@ module plic #(
150150

151151
assign rdata_o = reg_rdata;
152152

153-
endmodule
153+
endmodule

0 commit comments

Comments
 (0)