Use rayon in inner product and update readme

Signed-off-by: lovesh <[email protected]>

Author: lovesh

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "amcl_wrapper"
-version = "0.3.4"
+version = "0.3.5"
 authors = ["lovesh harchandani <[email protected]>"]
 description = "Wapper over Milagro Cryptographic Library (version 3)"
 repository = "https://github.com/lovesh/amcl_rust_wrapper"

README.md

@@ -11,7 +11,7 @@
 
 ## Building
 The wrapper has to be built by enabling any one of the mentioned curve as a feature.   
-To build for BLS-381 curve, use (BLS381 is the default curve so not using `--no-default-features` is fine)
+To build for BLS-381 curve, use 
 
 ```
 cargo build --no-default-features --features bls381
@@ -27,11 +27,11 @@ To run tests for secp256k1, use
 cargo test --no-default-features --features secp256k1
 ```
 
-To use it as dependency crate, add the name of the curve as a feature. Something like this
+To use it as dependency crate, use the name of the curve as a feature. eg. for BLS12-381 curve, use
 ```
 [dependencies.amcl_wrapper]
-git = "https://github.com/lovesh/amcl_rust_wrapper"
-branch = "master"
+version = "0.3.4"
+default-features = false
 features = ["bls381"]
 ```
 
@@ -297,6 +297,7 @@ let diff = &poly1 - &poly2;
 let product = UnivarPolynomial::multiply(&poly1, &poly2);
 // Or use operator overloading
 let product = &poly1 * &poly2;
+// Dividing polynomials: poly1 / poly2 
 let (quotient, rem) = UnivarPolynomial::long_division(&poly1, &poly2);
 ```
 

src/field_elem.rs

@@ -886,11 +886,8 @@ impl FieldElementVector {
     /// [a1, a2, a3, ...field elements].[b1, b2, b3, ...field elements] = (a1*b1 + a2*b2 + a3*b3) % curve_order
     pub fn inner_product(&self, b: &FieldElementVector) -> Result<FieldElement, ValueError> {
         check_vector_size_for_equality!(self, b)?;
-        let mut accum = FieldElement::new();
-        for i in 0..self.len() {
-            accum += &self[i] * &b[i];
-        }
-        Ok(accum)
+        let r = (0..b.len()).into_par_iter().map(|i| (&self[i] * &b[i])).reduce(|| FieldElement::new(), |a, b| a + b);
+        Ok(r)
     }
 
     /// Calculates Hadamard product of 2 field element vectors.
@@ -1405,7 +1402,7 @@ mod test {
             assert_eq!(x, FieldElement::from_power_of_2_base(&b, 3));
         }
 
-        for i in 0..100 {
+        for _ in 0..100 {
             let x = FieldElement::random();
             for base in 2..8 {
                 let digits = x.to_power_of_2_base(base);

src/group_elem.rs

@@ -3,7 +3,6 @@ use rand::{CryptoRng, RngCore};
 use crate::errors::{SerzDeserzError, ValueError};
 use crate::field_elem::{FieldElement, FieldElementVector};
 
-use crate::rayon::iter::IntoParallelRefMutIterator;
 use rayon::prelude::*;
 use std::slice::Iter;
 

src/lib.rs

@@ -1,4 +1,5 @@
-#![allow(non_snake_case)]
+#[allow(non_snake_case)]
+#[allow(non_upper_case_globals)]
 
 pub extern crate amcl;
 
@@ -22,7 +23,6 @@ extern crate serde;
 #[macro_use]
 extern crate serde_derive;
 
-#[macro_use]
 extern crate serde_json;
 
 extern crate rayon;