Discord notifications having the wrong downtime duration

[Mikweb-fr]

📑 I have found these related issues/pull requests

Timestamp issues

🛡️ Security Policy

• I have read and agree to Uptime Kuma's Security Policy.

📝 Description

When a service is down, everything is fine. However, when the service comes back up, the 'went offline' timestamp is incorrect (it reflects the probe’s last attempt, not the actual start time of the downtime). As a result, the downtime duration is wrong. Additionally, the timezone is missing.

👟 Reproduction steps

.

👀 Expected behavior

.

😓 Actual Behavior

.

🐻 Uptime-Kuma Version

2.1.0

💻 Operating System and Arch

.

🌐 Browser

.

🖥️ Deployment Environment

.

📝 Relevant log output

[CommanderStorm]

Yea, that seems to have been one of the AI PRs that has slipped past me in trying to review all of them.
Would you like to dive into where the variables got mixed up and fix it?

[ryangurn]

@CommanderStorm is this related to the monitor model query on lines 1523-1526 using the wrong sort logic?

Seems like the timezone missing is just under the notification provider right?

[CommanderStorm]

COuld you post the link to the line?

[ryangurn]

For the monitor model:

It seems like we are getting a heartbeat where the status is down but it could be the wrong one, I guess the only change I see would be to include AND important = 1 which seems to denote the transitions.

uptime-kuma/server/model/monitor.js

Lines 1523 to 1525 in 2d30489

	const lastDownHeartbeat = await R.getRow(
	"SELECT time FROM heartbeat WHERE monitor_id = ? AND status = ? ORDER BY time DESC LIMIT 1",
	[monitor.id, DOWN]

For the part about timezones:

The code below seems to be for the down notification, but the up one is just missing this (Line 192-230).

uptime-kuma/server/notification-providers/discord.js

Lines 150 to 152 in 2d30489

	name: `Time (${heartbeatJSON["timezone"]})`,
	value: heartbeatJSON["localDateTime"],
	},

I am new to this code so I just want to make sure I am on the right track with this.

[CommanderStorm]

Yes, there we are using the users timezone <t:. That is apparently what discord users expect.
Could be clearer, no clue how though

[CommanderStorm]

On the first one, yes that seems to be the case.

[ryangurn]

If I put a PR out there for these two changes, are images needed (I do not use discord so not the easiest thing for me to check).

[CommanderStorm]

@Mikweb-fr Could you test if the PR works as expected?

Here are instructions on how to test-drive a PR -> https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests

[ryangurn]

@Mikweb-fr when you test if you could grab a screenshot of the timezone in the discord notification?

I do not use discord so I have no great way to test this.

[Mikweb-fr]

Too fast 😅 Thanks guys !
The downtime duration is fine, but the timezone doesn’t appear when the service comes back up.

[ryangurn]

@Mikweb-fr the change for the up notification to include the timezone is already within the PR, are you sure you included it in your test?

https://github.com/ryangurn/uptime-kuma/blob/d38ea5af1def20d29c4e8a84a08d02931b08f2ad/server/notification-providers/discord.js#L222C1-L226C35