Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for the QUERY HTTP method #1611

Open
gdubicki opened this issue Jan 11, 2025 · 3 comments
Open

Please add support for the QUERY HTTP method #1611

gdubicki opened this issue Jan 11, 2025 · 3 comments

Comments

@gdubicki
Copy link

gdubicki commented Jan 11, 2025

On 2025-01-07 the QUERY HTTP method, "a safe, idempotent request method that can carry request content." has reached the level of a Proposed Standard consensus and is on track to become a Proposed Standard.

It solves the problem of making complex queries where the GET method is sometimes sufficient as it (according to the standard) lacks support for sending the query in the body, leaving only the query part of the URL which is limited. An often used workaround of using the POST method has a downside in that it's just the wrong method for this purpose as queries do not cause side-effects and this limits the retryabilty and cacheability of such queries.

Therefore It would be great to implement support for QUERY in Faraday.

If you are open to it, I am interested in providing a PR.

@gdubicki
Copy link
Author

@iMacTia
Copy link
Member

iMacTia commented Jan 11, 2025

Hi @gdubicki and thank you for opening this! I personally really like this proposal and hope it will make it into a standard.

With that said, I'm cautious about giving the green light about adding this into Faraday just yet.
Adding a new method would be a non-trivial amount of effort and it would require maintenance going forward.

On top of that, the current stage of the proposal is, according to the IETF official documentation, far from a guarantee that it will make it into a final standard as

Proposed Standard (PS). The first official stage. Many standards never progress beyond this level.

With that in mind, I'd prefer waiting a little bit more, until the proposal makes into the "Internet Standard" status or is extremely close to that.

I'll keep this issue open so that we can track progress and decide if a when we get to the point where it makes sense to introduce the new method. Please feel free to nudge this issue in future as things evolve 🙂

@gdubicki
Copy link
Author

gdubicki commented Jan 12, 2025

Thanks for a prompt reply, @iMacTia!

However I am very sorry to mislead you, but I did get overexcited and missed that the document in question has NOT reached a Proposed Standard level yet, but only its Intended Status was set to Proposed Standard on 2025-01-07. The document itself is still an Internet-Draft. 😞

However I have also learned in the mean time that:

With that in mind, I'd prefer waiting a little bit more, until the proposal makes into the "Internet Standard" status or is extremely close to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants