Skip to content

Commit 56201c5

Browse files
KalleVsamarpanB
authored andcommitted
fix(sequelize): resolves SQL error when order filter is an empty string
Signed-off-by: KalleV <[email protected]>
1 parent 74aa049 commit 56201c5

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

extensions/sequelize/src/__tests__/integration/repository.integration.ts

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,23 @@ describe('Sequelize CRUD Repository (integration)', () => {
487487
expect(getResponse.body).to.be.deepEqual(reversedArray);
488488
});
489489

490+
it('ignores an empty `order` filter', async () => {
491+
const users = [
492+
getDummyUser({name: 'ABoy'}),
493+
getDummyUser({name: 'BBoy'}),
494+
getDummyUser({name: 'CBoy'}),
495+
];
496+
const createAllResponse = await client.post('/users-bulk').send(users);
497+
const filter = {
498+
order: '',
499+
};
500+
const getResponse = await client.get(`/users`).query({
501+
filter,
502+
});
503+
504+
expect(getResponse.body).to.be.deepEqual(createAllResponse.body);
505+
});
506+
490507
it('supports `limit` filter', async () => {
491508
const users = [getDummyUser(), getDummyUser(), getDummyUser()];
492509
await client.post('/users-bulk').send(users);

extensions/sequelize/src/sequelize/sequelize.repository.base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ export class SequelizeCrudRepository<
489489
* @returns Sequelize compatible order filter value
490490
*/
491491
protected buildSequelizeOrder(order?: string[] | string): Order | undefined {
492-
if (order === undefined) {
492+
if (order === undefined || order === '') {
493493
return undefined;
494494
}
495495

0 commit comments

Comments
 (0)