Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should push a release of lookout-statsd to rubygems.org #1

Closed
rtyler opened this issue Aug 7, 2012 · 4 comments
Closed

Should push a release of lookout-statsd to rubygems.org #1

rtyler opened this issue Aug 7, 2012 · 4 comments
Assignees

Comments

@rtyler
Copy link

rtyler commented Aug 7, 2012

No description provided.

@ghost ghost assigned rtyler Aug 7, 2012
@gingerlime
Copy link

+1 or any reason why those changes weren't pull-requested into upstream? I'm interested in gauges support in particular.

@rtyler
Copy link
Author

rtyler commented Sep 12, 2013

I noticed this issue sitting around, might as well close it.

@gingerlime To answer your question, I've mentioned it, and I actually think our efforts and goals are probably too divergent to merge our changes together. That said, both gems will probably pick things back and forth from one another :-P

@rtyler rtyler closed this as completed Sep 12, 2013
@gingerlime
Copy link

@rtyler - interested to know why there are divergent goals/efforts? Isn't the aim to create a statsd-compatible library implemented in ruby? Fragmentation in such a small space seems odd to me.

(in any case, not that my opinion matters, but I've personally switched to the node.js etsy 'official' implementation. I found it behaves more consistent with my expectations, and not having to wonder which parts are included/excluded etc)

@rtyler
Copy link
Author

rtyler commented Sep 12, 2013

@gingerlime I have no problem explaining :)

Our first and foremost goal is to have a statsd-compatible gem which meets @lookout's needs, as part of that there's work that was done to add gauges fairly early, and we've made some other minor tweaks to report accurate stats for us. Additionally, with @jof's work in this pull request we're updating the server-side component to support forwarding of stats to make it easier for us to aggregate and centralize stats across data centers/clouds into a central statsd.

As far as "divergent goals" go, I've already removed the (wacky IMHO) MongoDB code, and at some point in the not-too-distant future I'd like to remove the dependency on EventMachine and perhaps swap it out for Celluloid::IO or perhaps strictly Fibers to allow the statsd server to run under JRuby instead of the (wacky IMHO ;)) MRI VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants