Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc] make more sybil commands friendly to repeated execution #38

Open
okayzed opened this issue May 22, 2018 · 2 comments
Open

[grpc] make more sybil commands friendly to repeated execution #38

okayzed opened this issue May 22, 2018 · 2 comments
Labels

Comments

@okayzed
Copy link
Collaborator

okayzed commented May 22, 2018

currently, the sybil binary is designed to run once and then exit - we need to audit and fix the individual areas so we can ingest, digest and query multiple times in the same sybil process.

this means that sybil funcs shouldn't have nasty side effects that modify global state.

@tmc
Copy link
Contributor

tmc commented May 22, 2018

#40 paves the way for parallelism in tests which will allow the race detector to surface issues that relate to this.

@okayzed
Copy link
Collaborator Author

okayzed commented May 22, 2018

at first, i was wondering how -race will help with global state, but now i realize that the test runner will be running simultaneous query, ingest and digest tests which will all be touching global state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants