-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[distributed] investigate grpc service for sybil #37
Comments
Refs #42 |
[proto] add proto file [grpc] simplify response [grpc] stub out implementation [grpc] add sybild cmd skeleton [grpc] add stub comments to satisfy linter [grpc] use x/net/context for go<1.9 [grpc] add Trim methods [grpc] add initial grpc implementation [grpc] remove panics [grpc] implement GetTable [grpc] implement more of query [grpc] query - implement samples [grpc] populate histogram [grpc] fixup [grpc] use exec, implement more of query [query] use x/net/context for 1.6 support [grpc] implement time series queries [grpc] set large fields to uint64 [grpc] add filter support [grpc] populate distinct count [grpc] add set fields support in samples [grpc] add basic doc.go [grpc] implement ReadIngestionLog [grpc] implement ingest
[proto] add proto file [grpc] simplify response [grpc] stub out implementation [grpc] add sybild cmd skeleton [grpc] add stub comments to satisfy linter [grpc] use x/net/context for go<1.9 [grpc] add Trim methods [grpc] add initial grpc implementation [grpc] remove panics [grpc] implement GetTable [grpc] implement more of query [grpc] query - implement samples [grpc] populate histogram [grpc] fixup [grpc] use exec, implement more of query [query] use x/net/context for 1.6 support [grpc] implement time series queries [grpc] set large fields to uint64 [grpc] add filter support [grpc] populate distinct count [grpc] add set fields support in samples [grpc] add basic doc.go [grpc] implement ReadIngestionLog [grpc] implement ingest
[proto] add proto file [grpc] simplify response [grpc] stub out implementation [grpc] add sybild cmd skeleton [grpc] add stub comments to satisfy linter [grpc] use x/net/context for go<1.9 [grpc] add Trim methods [grpc] add initial grpc implementation [grpc] remove panics [grpc] implement GetTable [grpc] implement more of query [grpc] query - implement samples [grpc] populate histogram [grpc] fixup [grpc] use exec, implement more of query [query] use x/net/context for 1.6 support [grpc] implement time series queries [grpc] set large fields to uint64 [grpc] add filter support [grpc] populate distinct count [grpc] add set fields support in samples [grpc] add basic doc.go [grpc] implement ReadIngestionLog [grpc] implement ingest
[proto] add proto file [grpc] simplify response [grpc] stub out implementation [grpc] add sybild cmd skeleton [grpc] add stub comments to satisfy linter [grpc] use x/net/context for go<1.9 [grpc] add Trim methods [grpc] add initial grpc implementation [grpc] remove panics [grpc] implement GetTable [grpc] implement more of query [grpc] query - implement samples [grpc] populate histogram [grpc] fixup [grpc] use exec, implement more of query [query] use x/net/context for 1.6 support [grpc] implement time series queries [grpc] set large fields to uint64 [grpc] add filter support [grpc] populate distinct count [grpc] add set fields support in samples [grpc] add basic doc.go [grpc] implement ReadIngestionLog [grpc] implement ingest
[proto] add proto file [grpc] simplify response [grpc] stub out implementation [grpc] add sybild cmd skeleton [grpc] add stub comments to satisfy linter [grpc] use x/net/context for go<1.9 [grpc] add Trim methods [grpc] add initial grpc implementation [grpc] remove panics [grpc] implement GetTable [grpc] implement more of query [grpc] query - implement samples [grpc] populate histogram [grpc] fixup [grpc] use exec, implement more of query [query] use x/net/context for 1.6 support [grpc] implement time series queries [grpc] set large fields to uint64 [grpc] add filter support [grpc] populate distinct count [grpc] add set fields support in samples [grpc] add basic doc.go [grpc] implement ReadIngestionLog [grpc] implement ingest
[proto] add proto file [grpc] simplify response [grpc] stub out implementation [grpc] add sybild cmd skeleton [grpc] add stub comments to satisfy linter [grpc] use x/net/context for go<1.9 [grpc] add Trim methods [grpc] add initial grpc implementation [grpc] remove panics [grpc] implement GetTable [grpc] implement more of query [grpc] query - implement samples [grpc] populate histogram [grpc] fixup [grpc] use exec, implement more of query [query] use x/net/context for 1.6 support [grpc] implement time series queries [grpc] set large fields to uint64 [grpc] add filter support [grpc] populate distinct count [grpc] add set fields support in samples [grpc] add basic doc.go [grpc] implement ReadIngestionLog [grpc] implement ingest
Hi folks, 👋 I notice that a gRPC service implementation landed in-tree in 2018 with 364be19 but was later replaced with the Go API library in 2020 with 08beb86. I wasn't able to find any commentary about the removal (were the proto dependencies too heavy/technology specific?) Could someone summarize why the gRPC service was dropped & how it relates to the future of this issue? Is this a WONTFIX for the project or a TODO? Thanks! |
the gRPC service essentially was a new flag on the sybil binary that allows you to specify a remote host to connect to and execute a sybil query on. the sybild service would accept connections and receive the list of all options to run in the query. it then ran the query (by invoking the sybil binary) and returned the results over grpc to the client. the main reason for removal was extra upkeep + not enough usage + it was tied to gRPC. sybil is still capable of running queries remotely on hosts over SSH but we don't have a formal RPC API inside sybil itself. that can be built as a separate service that invokes sybil binaries and transfers results around as the sybil binary itself is capable of combining results from multiple runs on different machines. |
@okayzed That makes sense, thanks! 👍
I'm weighing the pros/cons of developing a fronting service like this but I think we've settled on a model that directly invokes one |
No description provided.
The text was updated successfully, but these errors were encountered: