### Describe the bug url generated by `GenerateSignInUri` at https://github.com/logto-io/go/blob/97fd30d2fad12575f34e76895026465130948f0a/core/sign_in.go#L31 is illegal due to not url-escaped query values. And unit test in `core/sign_in_test.go` is wrong as well since "https://example.com/authorize?client_id=clientId&code_challenge=codeChallenge&code_challenge_method=S256&prompt=login&redirect_uri=https://example.com/callback&resource=resourceA&resource=resourceB&response_type=code&scope=openid offline_access profile&state=state" is **not** a valid url (containing white space and browser link detection also shows). ### Expected behavior unit test `TestGenerateSignInUriShouldGenerateCorrectUri` should generate "https://example.com/authorize?client_id=clientId&code_challenge=codeChallenge&code_challenge_method=S256&prompt=login&redirect_uri=https%3A%2F%2Fexample.com%2Fcallback&resource=resourceA&resource=resourceB&response_type=code&scope=openid+offline_access+profile&state=state". ref: https://docs.microfocus.com/OMi/10.62/Content/OMi/ExtGuide/ExtApps/URL_encoding.htm ### How to reproduce? ```shell go test ./core/ ``` ### Environment Self-hosted (Docker image) ### Screenshots _No response_
Describe the bug
url generated by
GenerateSignInUriatgo/core/sign_in.go
Line 31 in 97fd30d
And unit test in
core/sign_in_test.gois wrong as well since "https://example.com/authorize?client_id=clientId&code_challenge=codeChallenge&code_challenge_method=S256&prompt=login&redirect_uri=https://example.com/callback&resource=resourceA&resource=resourceB&response_type=code&scope=openid offline_access profile&state=state" is not a valid url (containing white space and browser link detection also shows).Expected behavior
unit test
TestGenerateSignInUriShouldGenerateCorrectUrishould generate "https://example.com/authorize?client_id=clientId&code_challenge=codeChallenge&code_challenge_method=S256&prompt=login&redirect_uri=https%3A%2F%2Fexample.com%2Fcallback&resource=resourceA&resource=resourceB&response_type=code&scope=openid+offline_access+profile&state=state".ref: https://docs.microfocus.com/OMi/10.62/Content/OMi/ExtGuide/ExtApps/URL_encoding.htm
How to reproduce?
go test ./core/Environment
Self-hosted (Docker image)
Screenshots
No response