android_lint.filtering = true doesn't work

[afaucogney]

here is the config:

android_lint.skip_gradle_task = true
android_lint.report_file = "./app/build/reports/lint/lint-report.xml"
android_lint.filtering = true
android_lint.lint(inline_mode: true)

Danger report every issues in the PR
I use gitlab

How filtering should work ?

• is it a configuration of the gradle task that will apply lint to the expected filers ?
• or this is a filter of the issues files itself ?

[ShivamPokhriyal]

+1
Using filtering = true, danger should only commit lint issues in the added/modified lines. Instead it comments on everything in the PR(lines below the added ones).

[ShivamPokhriyal]

Example PR dimagi/commcare-android#2479

[barbosa]

Hey @ShivamPokhriyal
Thanks for pointing that out. It's indeed a current limitation of the plugin.
Do you want to give it a shot and send us a PR?

[ShivamPokhriyal]

Sure, I'll take a look at it.

[petitJAM]

I found that the new parameter added in #30 doesn't work when inline_mode: false, so I submitted a PR for that. I think this issue can be closed after that is merged.