subscribed() returns incorrect result

[cihantas]

Lemon Squeezy for Laravel Version

1.7

Laravel Version

10

PHP Version

8.3

Description

The documentation states the following for $user->subscribed():

This method, as well as the subscribed method, will return true if your subscription is active, on trial, past due, paused for free or on >> its cancelled grace period <<.

However, neither subscribed() nor $subscription->valid() actually check if the grace period is over.

public function subscribed(string $type = Subscription::DEFAULT_TYPE, ?string $variant = null): bool
    {
        $subscription = $this->subscription($type);

        if (! $subscription || ! $subscription->valid()) {
            return false;
        }

        return $variant ? $subscription->hasVariant($variant) : true;
    }

public function valid(): bool
    {
        return $this->active() ||
            $this->onTrial() ||
            $this->pastDue() ||
            $this->cancelled() ||
            ($this->paused() && $this->pause_mode === 'free');
    }

cancelled() needs to check if the grace period is over, otherwise subscribed() returns true, even if the user is already completely cancelled.

Steps To Reproduce

1. Subscribe
2. Cancel Now
3. Set ends at to a date in the past in the db
4. See that user can still access if you're relying on subscribed()