diff --git a/flang/lib/Semantics/resolve-names.cpp b/flang/lib/Semantics/resolve-names.cpp index 92a3277191ae0..3f4a06444c4f3 100644 --- a/flang/lib/Semantics/resolve-names.cpp +++ b/flang/lib/Semantics/resolve-names.cpp @@ -9376,7 +9376,7 @@ static void SetImplicitCUDADevice(bool inDeviceSubprogram, Symbol &symbol) { if (inDeviceSubprogram && symbol.has()) { auto *object{symbol.detailsIf()}; if (!object->cudaDataAttr() && !IsValue(symbol) && - (IsDummy(symbol) || object->IsArray())) { + !IsFunctionResult(symbol)) { // Implicitly set device attribute if none is set in device context. object->set_cudaDataAttr(common::CUDADataAttr::Device); } diff --git a/flang/test/Lower/CUDA/cuda-shared.cuf b/flang/test/Lower/CUDA/cuda-shared.cuf index f41011df06ae7..565857f01bdb8 100644 --- a/flang/test/Lower/CUDA/cuda-shared.cuf +++ b/flang/test/Lower/CUDA/cuda-shared.cuf @@ -9,4 +9,5 @@ end subroutine ! CHECK-LABEL: func.func @_QPsharedmem() attributes {cuf.proc_attr = #cuf.cuda_proc} ! CHECK: %{{.*}} = cuf.shared_memory !fir.array<32xf32> {bindc_name = "s", uniq_name = "_QFsharedmemEs"} -> !fir.ref> +! CHECK: cuf.free %{{.*}}#0 : !fir.ref {data_attr = #cuf.cuda} ! CHECK-NOT: cuf.free diff --git a/flang/test/Semantics/cuf21.cuf b/flang/test/Semantics/cuf21.cuf new file mode 100644 index 0000000000000..b8b99a8d1d9be --- /dev/null +++ b/flang/test/Semantics/cuf21.cuf @@ -0,0 +1,27 @@ +! RUN: %python %S/test_errors.py %s %flang_fc1 +! Test generic matching with scalars argument without device attr + +module mlocModule + interface maxlocUpdate + module procedure :: & + maxlocUpdateR_32F, & + maxlocUpdateR_64F + end interface maxlocUpdate +contains + + attributes(global) subroutine maxlocPartialMaskR_32F1D() + implicit none + real(4) :: mval + + call maxlocUpdate(mval) + + end subroutine maxlocPartialMaskR_32F1D + + attributes(device) subroutine maxlocUpdateR_32F(mval) + real(4) :: mval + end subroutine maxlocUpdateR_32F + + attributes(device) subroutine maxlocUpdateR_64F(mval) + real(8) :: mval + end subroutine maxlocUpdateR_64F +end module