[Utils] update_llc_test_checks.py - failure to generate checks for -asm-verbose=false tests

[RKSimon]

For test files with -asm-verbose=false enabled (for example llvm-project\llvm\test\CodeGen\ARM\fp16-fullfp16.ll) - running the update_llc_test_checks.py script strips the test checks and fails to regenerate them.

Not sure whats going on but most likely the ASM_FUNCTION_ARM_RE regexp pattern is failing to match without some of the asm verbose signature

I've seen problems with asm-verbose=false aarch64 tests as well

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor is working on this issue. If someone is assigned to the issue or claimed to be working on it, ping the person. After one week without a response, the assignee may be changed.
2. Leave a comment indicating that you are working on the issue, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Simon Pilgrim (RKSimon)

For test files with -asm-verbose=false enabled (for example llvm-project\llvm\test\CodeGen\ARM\fp16-fullfp16.ll) - running the update_llc_test_checks.py script strips the test checks and fails to regenerate them.

Not sure whats going on but most likely the ASM_FUNCTION_ARM_RE regexp pattern is failing to match without some of the asm verbose signature

I've seen problems with asm-verbose=false aarch64 tests as well

[Felle33]

Hello, I would like to work on this issue, could you assign to me please? On the other hand, I am a beginner of LLVM, I have tried to reproduce it but without success

[RKSimon]

Interesting - so if you run update_llc_test_checks.py fp16-fullfp16.ll you still see all the CHECK lines? Are you using linux or windows btw?

[Felle33]

I am using Ubuntu 20 LTS, when i run python update_llc_test_checks.py ../test/CodeGen/ARM/fp16-fullfp16.ll, I receive the following error:
llc: error: unable to get target for 'armv8a-none-none-eabihf', see --version and --triple.
Error: Failed to update test ../test/CodeGen/ARM/fp16-fullfp16.ll
Maybe I have done some error during the configuration of LLVM

[RKSimon]

you will probably need to build llvm for all standard targets (cmake def -DLLVM_TARGETS_TO_BUILD=all)

[Felle33]

You were right, I was using another version of the LLVM, now it does not print anything and returns with a code equal to 0

[RKSimon]

Do you want to investigate it? How are your python and regular expression skills :) ?

[Felle33]

I could give it a try, it could be a good learning experience, if it is ok for you :)