Skip to content

Commit ffddf33

Browse files
tomershafirtomershafir
authored
[AArch64] Remove wrong processor feature (#151289)
`fmov dX, dY` is not a preferred instruction. Previously introduced by: #144152
1 parent 8bd9897 commit ffddf33

File tree

2 files changed

+0
-44
lines changed

2 files changed

+0
-44
lines changed

‎llvm/lib/Target/AArch64/AArch64Processors.td

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,6 @@ def TuneAppleA7 : SubtargetFeature<"apple-a7", "ARMProcFamily", "AppleA7",
321321
FeatureFuseAES, FeatureFuseCryptoEOR,
322322
FeatureStorePairSuppress,
323323
FeatureZCRegMoveGPR64,
324-
FeatureZCRegMoveFPR64,
325324
FeatureZCZeroing,
326325
FeatureZCZeroingFPWorkaround]>;
327326

@@ -335,7 +334,6 @@ def TuneAppleA10 : SubtargetFeature<"apple-a10", "ARMProcFamily", "AppleA10",
335334
FeatureFuseCryptoEOR,
336335
FeatureStorePairSuppress,
337336
FeatureZCRegMoveGPR64,
338-
FeatureZCRegMoveFPR64,
339337
FeatureZCZeroing]>;
340338

341339
def TuneAppleA11 : SubtargetFeature<"apple-a11", "ARMProcFamily", "AppleA11",
@@ -348,7 +346,6 @@ def TuneAppleA11 : SubtargetFeature<"apple-a11", "ARMProcFamily", "AppleA11",
348346
FeatureFuseCryptoEOR,
349347
FeatureStorePairSuppress,
350348
FeatureZCRegMoveGPR64,
351-
FeatureZCRegMoveFPR64,
352349
FeatureZCZeroing]>;
353350

354351
def TuneAppleA12 : SubtargetFeature<"apple-a12", "ARMProcFamily", "AppleA12",
@@ -361,7 +358,6 @@ def TuneAppleA12 : SubtargetFeature<"apple-a12", "ARMProcFamily", "AppleA12",
361358
FeatureFuseCryptoEOR,
362359
FeatureStorePairSuppress,
363360
FeatureZCRegMoveGPR64,
364-
FeatureZCRegMoveFPR64,
365361
FeatureZCZeroing]>;
366362

367363
def TuneAppleA13 : SubtargetFeature<"apple-a13", "ARMProcFamily", "AppleA13",
@@ -374,7 +370,6 @@ def TuneAppleA13 : SubtargetFeature<"apple-a13", "ARMProcFamily", "AppleA13",
374370
FeatureFuseCryptoEOR,
375371
FeatureStorePairSuppress,
376372
FeatureZCRegMoveGPR64,
377-
FeatureZCRegMoveFPR64,
378373
FeatureZCZeroing]>;
379374

380375
def TuneAppleA14 : SubtargetFeature<"apple-a14", "ARMProcFamily", "AppleA14",
@@ -392,7 +387,6 @@ def TuneAppleA14 : SubtargetFeature<"apple-a14", "ARMProcFamily", "AppleA14",
392387
FeatureFuseLiterals,
393388
FeatureStorePairSuppress,
394389
FeatureZCRegMoveGPR64,
395-
FeatureZCRegMoveFPR64,
396390
FeatureZCZeroing]>;
397391

398392
def TuneAppleA15 : SubtargetFeature<"apple-a15", "ARMProcFamily", "AppleA15",
@@ -410,7 +404,6 @@ def TuneAppleA15 : SubtargetFeature<"apple-a15", "ARMProcFamily", "AppleA15",
410404
FeatureFuseLiterals,
411405
FeatureStorePairSuppress,
412406
FeatureZCRegMoveGPR64,
413-
FeatureZCRegMoveFPR64,
414407
FeatureZCZeroing]>;
415408

416409
def TuneAppleA16 : SubtargetFeature<"apple-a16", "ARMProcFamily", "AppleA16",
@@ -428,7 +421,6 @@ def TuneAppleA16 : SubtargetFeature<"apple-a16", "ARMProcFamily", "AppleA16",
428421
FeatureFuseLiterals,
429422
FeatureStorePairSuppress,
430423
FeatureZCRegMoveGPR64,
431-
FeatureZCRegMoveFPR64,
432424
FeatureZCZeroing]>;
433425

434426
def TuneAppleA17 : SubtargetFeature<"apple-a17", "ARMProcFamily", "AppleA17",
@@ -446,7 +438,6 @@ def TuneAppleA17 : SubtargetFeature<"apple-a17", "ARMProcFamily", "AppleA17",
446438
FeatureFuseLiterals,
447439
FeatureStorePairSuppress,
448440
FeatureZCRegMoveGPR64,
449-
FeatureZCRegMoveFPR64,
450441
FeatureZCZeroing]>;
451442

452443
def TuneAppleM4 : SubtargetFeature<"apple-m4", "ARMProcFamily", "AppleM4",
@@ -463,7 +454,6 @@ def TuneAppleM4 : SubtargetFeature<"apple-m4", "ARMProcFamily", "AppleM4",
463454
FeatureFuseCryptoEOR,
464455
FeatureFuseLiterals,
465456
FeatureZCRegMoveGPR64,
466-
FeatureZCRegMoveFPR64,
467457
FeatureZCZeroing
468458
]>;
469459

‎llvm/test/CodeGen/AArch64/arm64-zero-cycle-regmov-fpr.ll

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
; RUN: llc < %s -mtriple=arm64-linux-gnu | FileCheck %s -check-prefixes=NOTCPU-LINUX --match-full-lines
22
; RUN: llc < %s -mtriple=arm64-apple-macosx -mcpu=generic | FileCheck %s -check-prefixes=NOTCPU-APPLE --match-full-lines
3-
; RUN: llc < %s -mtriple=arm64-apple-macosx -mcpu=apple-m1 | FileCheck %s -check-prefixes=CPU --match-full-lines
4-
; RUN: llc < %s -mtriple=arm64-apple-macosx -mcpu=apple-m1 -mattr=-zcm-fpr64 | FileCheck %s -check-prefixes=NOTATTR --match-full-lines
53
; RUN: llc < %s -mtriple=arm64-apple-macosx -mattr=+zcm-fpr64 | FileCheck %s -check-prefixes=ATTR --match-full-lines
64

75
define void @zero_cycle_regmov_FPR32(float %a, float %b, float %c, float %d) {
@@ -23,22 +21,6 @@ entry:
2321
; NOTCPU-APPLE: fmov s0, [[REG1]]
2422
; NOTCPU-APPLE: fmov s1, [[REG2]]
2523

26-
; CPU: fmov [[REG2:d[0-9]+]], d3
27-
; CPU: fmov [[REG1:d[0-9]+]], d2
28-
; CPU: fmov d0, d2
29-
; CPU: fmov d1, d3
30-
; CPU-NEXT: bl {{_?foo_float}}
31-
; CPU: fmov d0, [[REG1]]
32-
; CPU: fmov d1, [[REG2]]
33-
34-
; NOTATTR: fmov [[REG2:s[0-9]+]], s3
35-
; NOTATTR: fmov [[REG1:s[0-9]+]], s2
36-
; NOTATTR: fmov s0, s2
37-
; NOTATTR: fmov s1, s3
38-
; NOTATTR-NEXT: bl {{_?foo_float}}
39-
; NOTATTR: fmov s0, [[REG1]]
40-
; NOTATTR: fmov s1, [[REG2]]
41-
4224
; ATTR: fmov d0, d2
4325
; ATTR: fmov d1, d3
4426
; ATTR: fmov [[REG2:d[0-9]+]], d3
@@ -72,22 +54,6 @@ entry:
7254
; NOTCPU-APPLE: fmov s0, [[REG1]]
7355
; NOTCPU-APPLE: fmov s1, [[REG2]]
7456

75-
; CPU: fmov [[REG2:d[0-9]+]], d3
76-
; CPU: fmov [[REG1:d[0-9]+]], d2
77-
; CPU: fmov d0, d2
78-
; CPU: fmov d1, d3
79-
; CPU-NEXT: bl {{_?foo_half}}
80-
; CPU: fmov d0, [[REG1]]
81-
; CPU: fmov d1, [[REG2]]
82-
83-
; NOTATTR: fmov [[REG2:s[0-9]+]], s3
84-
; NOTATTR: fmov [[REG1:s[0-9]+]], s2
85-
; NOTATTR: fmov s0, s2
86-
; NOTATTR: fmov s1, s3
87-
; NOTATTR-NEXT: bl {{_?foo_half}}
88-
; NOTATTR: fmov s0, [[REG1]]
89-
; NOTATTR: fmov s1, [[REG2]]
90-
9157
; ATTR: fmov d0, d2
9258
; ATTR: fmov d1, d3
9359
; ATTR: fmov [[REG2:d[0-9]+]], d3

0 commit comments

Comments
 (0)