Skip to content

Commit fd86e73

Browse files
authored
[mlir][memref][nfc] push early-exit to earlier (#140730)
Move early exit check to as early as possible, [email protected]
1 parent 7fe387a commit fd86e73

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1721,6 +1721,10 @@ struct ViewOpLowering : public ConvertOpToLLVMPattern<memref::ViewOp> {
17211721
MemRefDescriptor sourceMemRef(adaptor.getSource());
17221722
auto targetMemRef = MemRefDescriptor::poison(rewriter, loc, targetDescTy);
17231723

1724+
// Early exit for 0-D corner case.
1725+
if (viewMemRefType.getRank() == 0)
1726+
return rewriter.replaceOp(viewOp, {targetMemRef}), success();
1727+
17241728
// Field 1: Copy the allocated pointer, used for malloc/free.
17251729
Value allocatedPtr = sourceMemRef.allocatedPtr(rewriter, loc);
17261730
auto srcMemRefType = cast<MemRefType>(viewOp.getSource().getType());
@@ -1743,10 +1747,6 @@ struct ViewOpLowering : public ConvertOpToLLVMPattern<memref::ViewOp> {
17431747
rewriter, loc,
17441748
createIndexAttrConstant(rewriter, loc, indexType, offset));
17451749

1746-
// Early exit for 0-D corner case.
1747-
if (viewMemRefType.getRank() == 0)
1748-
return rewriter.replaceOp(viewOp, {targetMemRef}), success();
1749-
17501750
// Fields 4 and 5: Update sizes and strides.
17511751
Value stride = nullptr, nextSize = nullptr;
17521752
for (int i = viewMemRefType.getRank() - 1; i >= 0; --i) {

0 commit comments

Comments
 (0)