Revert "[clang-tidy] Fix bugprone-unchecked-optional-access in ClangTidyDiagnosticConsumer"

This reverts commit 7f6239f.

Author: zeyi2

clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

@@ -239,16 +239,13 @@ static bool parseFileExtensions(llvm::ArrayRef<std::string> AllFileExtensions,
 void ClangTidyContext::setCurrentFile(StringRef File) {
   CurrentFile = std::string(File);
   CurrentOptions = getOptionsForFile(CurrentFile);
-  CheckFilter =
-      std::make_unique<CachedGlobList>(getOptions().Checks.value_or(""));
-  WarningAsErrorFilter = std::make_unique<CachedGlobList>(
-      getOptions().WarningsAsErrors.value_or(""));
-  if (!parseFileExtensions(getOptions().HeaderFileExtensions.value_or(
-                               std::vector<std::string>()),
+  CheckFilter = std::make_unique<CachedGlobList>(*getOptions().Checks);
+  WarningAsErrorFilter =
+      std::make_unique<CachedGlobList>(*getOptions().WarningsAsErrors);
+  if (!parseFileExtensions(*getOptions().HeaderFileExtensions,
                            HeaderFileExtensions))
     this->configurationDiag("Invalid header file extensions");
-  if (!parseFileExtensions(getOptions().ImplementationFileExtensions.value_or(
-                               std::vector<std::string>()),
+  if (!parseFileExtensions(*getOptions().ImplementationFileExtensions,
                            ImplementationFileExtensions))
     this->configurationDiag("Invalid implementation file extensions");
 }
@@ -572,7 +569,7 @@ void ClangTidyDiagnosticConsumer::checkFilters(SourceLocation Location,
     return;
   }
 
-  if (!Context.getOptions().SystemHeaders.value_or(false) &&
+  if (!*Context.getOptions().SystemHeaders &&
       (Sources.isInSystemHeader(Location) || Sources.isInSystemMacro(Location)))
     return;
 
@@ -603,15 +600,15 @@ void ClangTidyDiagnosticConsumer::checkFilters(SourceLocation Location,
 
 llvm::Regex *ClangTidyDiagnosticConsumer::getHeaderFilter() {
   if (!HeaderFilter)
-    HeaderFilter = std::make_unique<llvm::Regex>(
-        Context.getOptions().HeaderFilterRegex.value_or(""));
+    HeaderFilter =
+        std::make_unique<llvm::Regex>(*Context.getOptions().HeaderFilterRegex);
   return HeaderFilter.get();
 }
 
 llvm::Regex *ClangTidyDiagnosticConsumer::getExcludeHeaderFilter() {
   if (!ExcludeHeaderFilter)
     ExcludeHeaderFilter = std::make_unique<llvm::Regex>(
-        Context.getOptions().ExcludeHeaderFilterRegex.value_or(""));
+        *Context.getOptions().ExcludeHeaderFilterRegex);
   return ExcludeHeaderFilter.get();
 }