Addressed Dylan's concerns on PR.

Author: ptranq

lib/algo/manifold_interp/Interpolator.cpp

@@ -149,8 +149,7 @@ std::vector<double> obtainRBFGradientToTrainingPoints(
     }
     else
     {
-        std::cout << "Interpolated gradients are only implemented for \"LS\" ";
-        CAROM_VERIFY(interp_method == "LS");
+        CAROM_ERROR("Interpolated gradients are only implemented for \"LS\"");
     }
     return rbfs;
 }
@@ -160,36 +159,34 @@ double obtainRBFGradient(std::string rbf, double epsilon, const Vector & point1,
 {
     Vector diff;
     point1.minus(point2, diff);
-    double eps_norm_squared = epsilon * epsilon * diff.norm2();
+    const double eps_norm_squared = epsilon * epsilon * diff.norm2();
     double res = 0.0;
 
     // Gaussian RBF
     if (rbf == "G")
     {
-        //res = std::exp(-eps_norm_squared);
+        //Derivative of Gaussian RBF, res = std::exp(-eps_norm_squared);
         res = -2.0*epsilon*epsilon*diff.item(index)*std::exp(-eps_norm_squared);
     }
     // Inverse quadratic RBF
     else if (rbf == "IQ")
     {
-        //res = 1.0 / (1.0 + eps_norm_squared);
+        //Derivative of Inverse Quadratic RBF, res = 1.0 / (1.0 + eps_norm_squared);
         res = -2.0*epsilon*epsilon*diff.item(index)/((1.0+eps_norm_squared)*
                 (1.0+eps_norm_squared));
 
     }
     // Inverse multiquadric RBF
     else if (rbf == "IMQ")
     {
-        //res = 1.0 / std::sqrt(1.0 + eps_norm_squared);
+        //Derivative of Inverse multiquadritic RBF, res = 1.0 / std::sqrt(1.0 + eps_norm_squared);
         res = -epsilon*epsilon*diff.item(index)/(std::sqrt(1.0+eps_norm_squared)*
                 (1.0+eps_norm_squared));
     }
 
     return res;
 }
 
-
-
 double rbfWeightedSum(std::vector<double>& rbf)
 {
     double sum = 0.0;
@@ -205,7 +202,7 @@ double obtainRBF(std::string rbf, double epsilon, const Vector & point1,
 {
     Vector diff;
     point1.minus(point2, diff);
-    double eps_norm_squared = epsilon * epsilon * diff.norm2();
+    const double eps_norm_squared = epsilon * epsilon * diff.norm2();
     double res = 0.0;
 
     // Gaussian RBF

lib/algo/manifold_interp/MatrixInterpolator.cpp

@@ -106,17 +106,15 @@ std::shared_ptr<Matrix> MatrixInterpolator::interpolate(const Vector & point,
     {
         if (d_compute_gradients)
         {
-            std::cout << "Gradients are only implemented for B or G";
-            CAROM_VERIFY(false);
+            CAROM_ERROR("Gradients are only implemented for B or G");
         }
         interpolated_matrix = interpolateSPDMatrix(point);
     }
     else if (d_matrix_type == "NS")
     {
         if (d_compute_gradients)
         {
-            std::cout << "Gradients are only implemented for B or G";
-            CAROM_VERIFY(false);
+            CAROM_ERROR("Gradients are only implemented for B or G");
         }
         interpolated_matrix = interpolateNonSingularMatrix(point);
     }
@@ -526,15 +524,12 @@ std::shared_ptr<Matrix> MatrixInterpolator::interpolateMatrix(
                                           d_rbf, d_epsilon, point, i);
 
                 std::shared_ptr<Matrix> gradient_matrix(obtainLogInterpolatedMatrix(rbf));
-                // *interpolated_matrix += *d_rotated_reduced_matrices[d_ref_point];
-
                 d_interpolation_gradient.push_back(gradient_matrix);
             }
         }
         else
         {
-            std::cout << "Interpolated gradients are only implemented for \"LS\" ";
-            CAROM_VERIFY(d_interp_method == "LS");
+            CAROM_ERROR("Interpolated gradients are only implemented for \"LS\"");
         }
     }
 

lib/algo/manifold_interp/VectorInterpolator.cpp

@@ -136,8 +136,7 @@ std::shared_ptr<Vector> VectorInterpolator::interpolate(const Vector & point)
         }
         else
         {
-            std::cout << "Interpolated gradients are only implemented for \"LS\" ";
-            CAROM_VERIFY(d_interp_method == "LS");
+            CAROM_ERROR("Interpolated gradients are only implemented for \"LS\"");
         }
     }
 

unit_tests/test_interpolation_gradients.cpp

@@ -1,6 +1,6 @@
 /******************************************************************************
  *
- * Copyright (c) 2013-2024, Lawrence Livermore National Security, LLC
+ * Copyright (c) 2013-2025, Lawrence Livermore National Security, LLC
  * and other libROM project developers. See the top-level COPYRIGHT
  * file for details.
  *