What would you like to be added:
Consolidate TLS version and cipher suite parsing for the EPP server and pd-sidecar onto the existing helpers in k8s.io/component-base/cli/flag:
flag.TLSVersion()
flag.TLSCipherSuites()
Remove the duplicated tlsVersions, parseTLSVersion, and parseCipherSuites implementations from pkg/epp/server/options.go and pkg/sidecar/proxy/options.go, while retaining coverage for valid and invalid CLI values in both components.
Confirm whether the Kubernetes helpers' stricter handling of whitespace and empty cipher names is acceptable for sidecar YAML configuration, and document or test that behavior as appropriate.
Why is this needed:
PR #2676 adds TLS security profile flags to the pd-sidecar by following the existing EPP implementation. Both components would otherwise maintain equivalent TLS name-to-ID parsing even though k8s.io/component-base is already a direct dependency and provides these helpers.
What would you like to be added:
Consolidate TLS version and cipher suite parsing for the EPP server and pd-sidecar onto the existing helpers in
k8s.io/component-base/cli/flag:flag.TLSVersion()flag.TLSCipherSuites()Remove the duplicated
tlsVersions,parseTLSVersion, andparseCipherSuitesimplementations frompkg/epp/server/options.goandpkg/sidecar/proxy/options.go, while retaining coverage for valid and invalid CLI values in both components.Confirm whether the Kubernetes helpers' stricter handling of whitespace and empty cipher names is acceptable for sidecar YAML configuration, and document or test that behavior as appropriate.
Why is this needed:
PR #2676 adds TLS security profile flags to the pd-sidecar by following the existing EPP implementation. Both components would otherwise maintain equivalent TLS name-to-ID parsing even though
k8s.io/component-baseis already a direct dependency and provides these helpers.