llm-d observability: finish remaining OpenTelemetry GenAI semconv and telemetry refactoring - #2516
Open
PlateauGao wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
size/XXL
PlateauGao
changed the title
This was referenced Aug 24, 2026
11 tasks
PlateauGao
force-pushed
the
feature/otel-semconv-proxy-and-remaining-llmd
branch
from
September 9, 2026 14:32
a7ddf64 to
ee2107f
Compare
PlateauGao
changed the title
PlateauGao
marked this pull request as ready for review
September 9, 2026 14:47
PlateauGao
requested review from
a team,
bongwoobak,
hyeongyun0916,
liu-cong,
nilig,
roytman,
sagearc,
vMaroon and
yankay
as code owners
September 9, 2026 14:47
Contributor
Author
|
/assign @gyliu513 |
gyliu513
reviewed
Sep 10, 2026
PlateauGao
force-pushed
the
feature/otel-semconv-proxy-and-remaining-llmd
branch
from
September 10, 2026 19:46
ee2107f to
29ec668
Compare
Complete migration of all remaining llm_d.* and gen_ai.* OpenTelemetry attributes across llm-d-router to centralized semantic conventions in pkg/common/observability/semconv: - Expand semconv/llm_d.go with typed keys and constructors for all EPP scheduling/filtering/scoring, token producer, KV cache indexing/lookup, KV events pub/sub, and sidecar proxy attributes. - Migrate EPP scheduling, profile handler, data producers, and tests to semconv keys and constructors. - Migrate kvcache indexer, prefix match, traced scorer, and kvblock to semconv. - Migrate kvevents pool and ZeroMQ subscriber to semconv. - Migrate sidecar proxy connectors (nixlv2, p2p, decode, pd_common, chat completions) to semconv. - Add unit tests for all new attribute constructors in semconv/llm_d_test.go. Signed-off-by: Yuan Gao <plateau451@gmail.com>
PlateauGao
force-pushed
the
feature/otel-semconv-proxy-and-remaining-llmd
branch
from
September 10, 2026 20:31
29ec668 to
a98cd2a
Compare
Member
|
lgtm, thanks @PlateauGao ! @ahg-g can you help approve? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a follow-up PR to #2503 (implemented subtasks 1&2 of #708), completing the migration of all remaining hardcoded
llm_d.*andgen_ai.*OpenTelemetry attributes across the codebase to centralized & type-safe semantic conventions inpkg/common/observability/semconvSummary of Changes:
pkg/common/observability/semconv):llm_d.gowith typedattribute.Keydefinitions and constructors for remaining legacy usagesVerification:
Which issue(s) this PR fixes:
#708
Release note (write
NONEif no user-facing change):