Replies: 1 comment
-
Converted to this issue: #3424 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Some cryptographic algorithms that are not FIPS-validated are currently used for different purposes in the llama-stack repo. These must be replaced so that llama-stack is considered to be "Designed for FIPS".
Examples:
calculate_md5
function. It's using the parameterusedforsecurity=False
despite being a security-sensitive operation._extract_model_identifiers
for another identifier generation purpose.Proposal:
There are differences in hash output when switching from MD5 to SHA-256. The hash length would increase from 32 to 64 characters. Would this pose an issue for any current use cases? e.g. It's possible some users have strict database schemas with a hard limit of 32 characters for fields in this column
For security sensitive operations like file checksum creation, I would recommend the full SHA-256 hash be used for validation. For other functions like
_extract_model_identifiers()
that currently only use 8 characters of the hash for testing purposes, we may opt to use the same truncated string, or choose another way to generate this identifier.I'll bring this topic up at the community meeting, and open a PR soon after if there are no issues with this approach.
Beta Was this translation helpful? Give feedback.
All reactions