Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use revertErr instead of err #730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use revertErr instead of err #730

wants to merge 1 commit into from

Conversation

heysujal
Copy link

What this PR does / why we need it:

As of now, err is not being used in https://github.com/litmuschaos/litmus-go/blob/master/chaoslib/litmus/network-chaos/helper/netem.go#L133C3-L135C4 instead of revertErr

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #720

Special notes for your reviewer:

Checklist:

  • Fixes error check with killnetem #720
  • PR messages has document related information
  • Labelled this PR & related issue with breaking-changes tag
  • PR messages has breaking changes related information
  • Labelled this PR & related issue with requires-upgrade tag
  • PR messages has upgrade related information
  • Commit has unit tests
  • Commit has integration tests
  • E2E run Required for the changes

@heysujal
use revertErr instead of err
4ca16e9 
Signed-off-by: Sujal Gupta <[email protected]>
@namkyu1999 namkyu1999 added the good first issue Good for newcomers label Dec 30, 2024
namkyu1999
namkyu1999 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🚀

@heysujal
Copy link
Author

@namkyu1999 can you guide me on how to get this failing tests fixed?
Is there any command to run tests locally? I wasn't able to find much here Contribute.md

I am new to devops in general.

@namkyu1999
Copy link
Member

@namkyu1999 can you guide me on how to get this failing tests fixed? Is there any command to run tests locally? I wasn't able to find much here Contribute.md

I am new to devops in general.

you don't have to do anything @heysujal . This is a temporary issue due to the hub.litmuschaos.io site being down. If you rerun github actions after adding the chore change, all tests should perform as expected.

@heysujal
Copy link
Author

Sorry, but I am not following. What is chore change?
Do I need to add it in title of PR?

@namkyu1999
Copy link
Member

Sorry, but I am not following. What is chore change? Do I need to add it in title of PR?

Oh I mean, you don't have to do anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namkyu1999 namkyu1999 namkyu1999 approved these changes

@ispeakc0de ispeakc0de Awaiting requested review from ispeakc0de ispeakc0de is a code owner

@ksatchit ksatchit Awaiting requested review from ksatchit ksatchit is a code owner

@uditgaurav uditgaurav Awaiting requested review from uditgaurav uditgaurav is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@heysujal heysujal

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error check with killnetem
2 participants
@heysujal @namkyu1999