perf: micro-optimize BaseFactory._infer_model_type (#731)

sobolevn · adhtruong · web-flow · commit e5fb6bf6c1f6 · 2025-11-15T11:53:01.000Z
Co-authored-by: Andrew Truong &lt;40660973+adhtruong@users.noreply.github.com&gt;
diff --git a/polyfactory/factories/base.py b/polyfactory/factories/base.py
@@ -275,7 +275,7 @@ class Foo(ModelFactory[MyModel]):  # <<< MyModel
         """
 
         factory_bases: Iterable[type[BaseFactory[T]]] = (
-            b for b in get_original_bases(cls) if get_origin(b) and issubclass(get_origin(b), BaseFactory)
+            b for b in get_original_bases(cls) if (orig := get_origin(b)) and issubclass(orig, BaseFactory)
         )
         generic_args: Sequence[type[T]] = [
             arg for factory_base in factory_bases for arg in get_args(factory_base) if not is_type_var(arg)

Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ class Foo(ModelFactory[MyModel]): # <<< MyModel`
`275`	`275`	`"""`
`276`	`276`
`277`	`277`	`factory_bases: Iterable[type[BaseFactory[T]]] = (`
`278`		`- b for b in get_original_bases(cls) if get_origin(b) and issubclass(get_origin(b), BaseFactory)`
	`278`	`+ b for b in get_original_bases(cls) if (orig := get_origin(b)) and issubclass(orig, BaseFactory)`
`279`	`279`	`)`
`280`	`280`	`generic_args: Sequence[type[T]] = [`
`281`	`281`	`arg for factory_base in factory_bases for arg in get_args(factory_base) if not is_type_var(arg)`