epub: Fix an incorrect sizeof call detected by AddressSanitizer (#635)

correctmost · web-flow · commit 1cde19228e6f · 2024-01-31T14:04:52.000-05:00
This commit also fixes a build directory typo in INSTALL.md.
diff --git a/INSTALL.md b/INSTALL.md
@@ -47,7 +47,7 @@ cd xreader
 # libraries, and shared files into /usr/local, and
 # enables all available options:
 
-meson buildir \
+meson builddir \
   --prefix=/usr/local \
   --buildtype=plain \
   -D deprecated_warnings=false \
diff --git a/backend/epub/epub-document.c b/backend/epub/epub-document.c
@@ -1055,7 +1055,7 @@ setup_document_content_list(const gchar* content_uri, GError** error,gchar *docu
         }
         if ( xmlStrcmp(itemrefptr->name,(xmlChar*)"itemref") == 0)
         {
-            contentListNode *newnode = g_malloc0(sizeof(newnode));
+            contentListNode *newnode = g_malloc0(sizeof(*newnode));
             newnode->key = (gchar*)xml_get_data_from_node(itemrefptr,XML_ATTRIBUTE,(xmlChar*)"idref");
             if ( newnode->key == NULL )
             {

Original file line number	Diff line number	Diff line change
`@@ -1055,7 +1055,7 @@ setup_document_content_list(const gchar* content_uri, GError** error,gchar *docu`
`1055`	`1055`	`}`
`1056`	`1056`	`if ( xmlStrcmp(itemrefptr->name,(xmlChar*)"itemref") == 0)`
`1057`	`1057`	`{`
`1058`		`- contentListNode *newnode = g_malloc0(sizeof(newnode));`
	`1058`	`+ contentListNode newnode = g_malloc0(sizeof(newnode));`
`1059`	`1059`	`newnode->key = (gchar)xml_get_data_from_node(itemrefptr,XML_ATTRIBUTE,(xmlChar)"idref");`
`1060`	`1060`	`if ( newnode->key == NULL )`
`1061`	`1061`	`{`