Redecorate when untile

[SoleInvictus]

Extension name and maintainer

cinnamon-maximus@fmete

What would you like to see?

I love the undecorate when tile feature, but would love it even more if it'd toggle back to decorated when the window is no longer tiled.

[MalteBrunn]

For me redecorating works just fine with Cinnamon 6.4.8 if I untile/unmaximize with keyboard shortcuts. However, wenn dragging a window to untile it does not work.

I looked in the log file and found an "Meta.WindowTileType is undefined" from the onUnmaximize function @ l378

I added a check if win.tile_type is defined an now it works. I.e.:
if (settings.undecorateTile && (typeof win.tile_type !== 'undefined') && (win.tile_type == Meta.WindowTileType.TILED || win.tile_type == Meta.WindowTileType.SNAPPED))

[SoleInvictus]

Thanks for getting back to me. I feel like such a dork - I never thought to check keyboard shortcuts...or the contents of the extension.js file! Sorry, I'm pretty new to all of this.

Your fix works but introduces or allows the display of one odd behavior, which I don't care about in the slightest but will document in case you or someone else does. If the window is tiled and therefore undecorated, then is dragged directly to a different tiled position (e.g., quadrant to half, half to another half, or quadrant to another quadrant), it redecorates until it is untiled, then retiled/maximized. That's all! I checked the log (because I RTFM this time) and there aren't any errors, didn't see anything unusual in the terminal under cinnamon --replace, plus disabled and uninstalled all non-standard extensions while testing and it persisted.

It's an edge case for me, so I'm quite content as is.

Thanks again for your effort on this, I really appreciate you.

edit: I just recalled the troubleshooting steps only reference GNOME in step 7. If it's of use to you, here's an update for us technically inept or terminology-challenged cinnamon users:

 * 7. Also include:
 * - your version of the extension (in metadata.json)
 * - list of all your installed extensions (including disabled ones, as
 *   this is no guarantee they won't interfere with other extensions)
 * - your version of GNOME-shell (gnome-shell --version) or Cinnamon (cinnamon --version)
 * 8. I'll try get back to you with a fix.
 * (Brownie points: open a terminal, do `gnome-shell --replace` or `cinnamon --replace` and reproduce the
 *  bug. Include any errors that pop up in this terminal.)

[MalteBrunn]

Just in case someone stumbels here like me. This is unrelated to the issue, but people interested in undecorating while tiling might find this interesting as well.

I wanted the tiled and undecorated windows to have still an indication if they are active or not. I did this by a custom gtk3 theme in the .config/gtk3-0/gtk.css

  border-top: 3px solid #76905B; }
.tiled headerbar, .maximized headerbar, .tiled .titlebar:not(headerbar), .maximized .titlebar:not(headerbar), .tiled-top headerbar, .tiled-top .titlebar:not(headerbar) {
  border-top: 3px solid #76905B; }
.tiled headerbar:backdrop, .maximized headerbar:backdrop, .tiled .titlebar:backdrop:not(headerbar), .maximized .titlebar:backdrop:not(headerbar) {
  border-top: 3px solid #464139; }
headerbar:backdrop, .titlebar:not(headerbar):backdrop {
  border-top: 3px solid #464139; }
decoration {
  background: #2F2F2F; }
.ssd.tiled decoration {
  border-top: 3px solid #76905B; }
.ssd.tiled decoration:backdrop {
  border-top: 3px solid #464139; }

[MalteBrunn]

I fixed the problem with redecorating the windows when dragged from a tiled/maximized position to a tiled position. I'm not sure how this interferes with older versions of Cinnamon using Metacity but for Cinnamon 6.4.8 this fix works fine.

I added an additional check to the grab-op-end callback in the onUnmaximize function.

if (isFullyMaximized(win) || isHalfMaximized(win)) {
  return;
}