Skip to content

Conversation

@Shining-N
Copy link
Contributor

@Shining-N Shining-N commented Dec 22, 2025

Summary by Sourcery

Update Debian packaging by adjusting the dde-kwin post-installation script and bumping the package changelog version accordingly.

Build:

  • Adjust debian/dde-kwin.postinst to change post-install configuration behavior for dde-kwin.

Chores:

  • Revise debian/changelog to reflect a new dde-kwin package version.

…ing system upgrade

撤销 73e8f3f 提交, 解决系统升级时 dde-kwin 配置卡住问题

PMS: BUG-344935
Log: 撤销 73e8f3f 提交, 解决系统升级时 dde-kwin 配置卡住问题
Influence:
去掉景嘉微显卡的特殊配置,v25 无需该脚本,v20 该部分逻辑已被 os-config 接管。
需要测试景嘉微显卡是否正常运行,对应 pms 单号:https://pms.uniontech.com/zentao/task-view-61749.html
@github-actions
Copy link

TAG Bot

TAG: 6.0.5
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian packaging for dde-kwin to a new version and adjusts the post-installation script to resolve a configuration-time hang during package installation or upgrade.

File-Level Changes

Change Details Files
Bump dde-kwin Debian package version and document the packaging change.
  • Add a new changelog entry for the updated dde-kwin package version.
  • Describe the fix for the configuration hang in the changelog metadata (version, urgency, maintainer, and summary).
debian/changelog
Modify the dde-kwin post-installation script to prevent or resolve a hang during dpkg configuration.
  • Adjust the maintainer script logic that runs during post-install (e.g., guarding long-running commands, fixing blocking calls, or adding condition checks).
  • Ensure the postinst script exits cleanly after configuration, avoiding deadlocks or waiting on unavailable services.
debian/dde-kwin.postinst

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

CLA Assistant Lite bot:
提交邮箱中包含我们的合作伙伴,但您似乎并非合作伙伴的成员或对接人,请联系相关对接人将您添加至组织之中,或由其重新发起 Pull Request。
The commit email domain belongs to one of our partners, but it seems you are not yet a member of the current organization, please contact the contact person to add you to the organization or let them submit the Pull Request.

You can retrigger this bot by commenting recheck in this Pull Request

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

我来分析一下这个git diff中的变更:

  1. changelog变更:
  • 新增了6.0.5版本记录,修复了dde-kwin配置挂起的问题
  1. postinst脚本变更:
  • 删除了KWINRCTMP_FILENAME变量定义
  • 删除了iniDisplayDevicdId和iniShieldDevicdId变量定义
  • 删除了针对特定显卡设备(JM7200)的OpenGL不安全检查逻辑

改进建议:

  1. 代码质量方面:
  • 删除未使用的变量定义是好的做法,提高了代码的整洁性
  • 移除了硬编码的显卡设备检查逻辑,使代码更加通用
  1. 逻辑方面:
  • 原代码中针对JM7200显卡的特殊处理可能有其特定原因,建议在删除这类代码时确保:
    • 有充分的测试证明这个改动不会影响特定硬件的用户
    • 在commit信息中说明删除这个检查的原因
  1. 安全性方面:
  • 变更看起来是安全的,主要是删除了一些特定的硬件检查逻辑
  • 建议确保删除这些检查不会导致某些硬件配置下出现系统不稳定的情况
  1. 性能方面:
  • 删除了lshw命令调用和字符串匹配,会轻微提升安装脚本的执行速度
  • 减少了不必要的文件写入操作
  1. 建议补充:
  • 建议在changelog中更详细地说明为什么移除这些显卡检查逻辑
  • 建议添加相关的测试用例来验证这个改动不会影响特定硬件的用户体验

总体来说,这个变更看起来是合理的,主要是简化了安装脚本,移除了一些特定的硬件检查逻辑。但建议确保这个改动经过了充分的测试,特别是对于之前需要特殊处理的硬件配置。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, Shining-N

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justforlxz justforlxz merged commit acf78f1 into linuxdeepin:master Dec 22, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants