Skip to content

Conversation

@Groveer
Copy link
Contributor

@Groveer Groveer commented Dec 11, 2025

This reverts commit 8ee3beb.

PMS: TASK-384659
Log: 应功耗专项要求,回退该提交,允许应用修改合成状态
Influence:
向日葵连接还是会修改合成状态,但不再强制关闭合成,如有诉求,应该由向日葵修改。

Summary by Sourcery

Revert a previous change that prevented Sunlogin and similar applications from modifying the window compositing state, restoring the original compositing behavior.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 11, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Reverts a previous change in kwinrc that prevented Sunlogin from modifying the compositing status, restoring the original behavior where applications are allowed to change the compositor state.

File-Level Changes

Change Details Files
Revert previous restriction on applications (specifically Sunlogin) modifying the window compositing status, restoring original kwinrc configuration behavior.
  • Remove configuration changes that forced compositing to remain enabled/blocked changes triggered by Sunlogin.
  • Restore prior compositing-related settings so that remote desktop connections can again adjust the compositing state.
configures/kwinrc

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hudeng-go
Copy link
Contributor

/retest

@hudeng-go
Copy link
Contributor

/retest github-trigger-obs-ci

@deepin-ci-robot
Copy link

@hudeng-go: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test deepin-auto-translation
  • /test github-pr-review-ci
  • /test github-trigger-obs-ci

Use /test all to run the following jobs that were automatically triggered:

  • github-pr-review-ci
  • github-trigger-obs-ci
Details

In response to this:

/retest github-trigger-obs-ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hudeng-go
Copy link
Contributor

/test github-trigger-obs-ci

This reverts commit 8ee3beb.

PMS: TASK-384659
Log: 应功耗专项要求,回退该提交,允许应用修改合成状态
Influence:
向日葵连接还是会修改合成状态,但不再强制关闭合成,如有诉求,应该由向日葵修改。
应重新激活PMS:BUG-226643,需更新测试用例。
@deepin-ci-robot
Copy link

deepin pr auto review

我来对这个配置文件修改进行审查:

  1. 语法逻辑:
  • 修改的语法符合KDE配置文件(kwinrc)的标准格式
  • 删除了WindowsBlockCompositing=false这一行配置
  • 其他配置项保持不变
  1. 代码质量:
  • 配置修改简洁明了
  • 注释清晰,说明了动画速度的调整目的
  • 删除了关于向日葵的配置注释,可能是认为这个配置不再需要
  1. 代码性能:
  • 删除WindowsBlockCompositing=false可能会对性能产生影响:
    • 这个设置原本是阻止某些应用程序(如向日葵)修改合成器状态
    • 删除后,应用程序可能可以自由修改合成器状态,可能影响系统性能
  1. 代码安全:
  • 删除WindowsBlockCompositing=false可能会带来安全风险:
    • 允许应用程序修改合成器状态可能被恶意软件利用
    • 建议保留这个安全限制,除非有特定需求

改进建议:

  1. 如果确实需要删除WindowsBlockCompositing配置,建议:

    • 添加新的注释说明删除原因
    • 考虑是否需要添加其他安全限制
  2. 建议保留WindowsBlockCompositing=false,除非:

    • 确实需要允许特定应用程序修改合成器状态
    • 有其他安全措施可以替代这个限制
  3. 如果是为了解决特定应用程序的兼容性问题,建议:

    • 考虑使用更精确的配置方式
    • 只对特定应用程序允许修改合成器状态

总的来说,这个修改虽然语法正确,但可能会影响系统性能和安全性,建议谨慎考虑是否真的需要删除这个配置。

@zccrs zccrs merged commit e51ba98 into linuxdeepin:master Dec 11, 2025
18 of 19 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Groveer, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants