Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails with 'nvramcui' as second payload #731

Closed
Siproqu opened this issue May 30, 2020 · 5 comments
Closed

Build fails with 'nvramcui' as second payload #731

Siproqu opened this issue May 30, 2020 · 5 comments

Comments

@Siproqu
Copy link

Siproqu commented May 30, 2020

It fails with:

** Default configuration is based on 'configs/defconfig'
#
# configuration written to /home/user/work/heads/build/coreboot-4.8.1/payloads/nvramcui/.config
#
#
# configuration written to /home/user/work/heads/build/coreboot-4.8.1/payloads/nvramcui/.config
#
    CC         libpci/libpci.libpci.o
cc1: error: -mpreferred-stack-boundary=2 is not between 3 and 12
make[3]: *** [Makefile:274: /home/user/work/heads/build/coreboot-4.8.1/payloads/nvramcui/build/libpci/libpci.libpci.o] Error 1
make[2]: *** [Makefile:12: /home/user/work/heads/build/coreboot-4.8.1/payloads/nvramcui/libpayload] Error 2
make[1]: *** [payloads/Makefile.inc:43: payloads/nvramcui/nvramcui.elf] Error 2
make[1]: Leaving directory '/home/user/work/heads/build/coreboot-4.8.1'
make: *** [Makefile:382: /home/user/work/heads/build/coreboot-4.8.1/t430s/.build] Error 1

After changing mpreferred-stack-boundary to 3 in
heads/build/coreboot-4.8.1/payloads/libpayload/arch/x86/Makefile.inc

it fails with:

    CC         libpci/libpci.libpci.o
<command-line>: error: "_LP64" redefined [-Werror]
<built-in>: note: this is the location of the previous definition
cc1: all warnings being treated as errors
make[3]: *** [Makefile:274: /home/user/work/heads/build/coreboot-4.8.1/payloads/nvramcui/build/libpci/libpci.libpci.o] Error 1
make[2]: *** [Makefile:12: /home/user/work/heads/build/coreboot-4.8.1/payloads/nvramcui/libpayload] Error 2
make[1]: *** [payloads/Makefile.inc:43: payloads/nvramcui/nvramcui.elf] Error 2
make[1]: Leaving directory '/home/user/work/heads/build/coreboot-4.8.1'
make: *** [Makefile:382: /home/user/work/heads/build/coreboot-4.8.1/t430s/.build] Error 1

Unfortunately, I can't find the source of this error.
Any suggestions?

@MrChromebox
Copy link
Contributor

what's the point of building secondary payloads since Heads can't launch them?

@tlaurion
Copy link
Collaborator

tlaurion commented Jun 2, 2020

what's the point of building secondary payloads since Heads can't launch them?

@MrChromebox those are ELF binaries. Why couldn't we launch them? (Not from menu now, but from Head's recovery shell?)

@Siproqu
Copy link
Author

Siproqu commented Jun 3, 2020

I have built the nvramcui in a standalone coreboot build (i386), but couldn't run it. The kernel doesn't accept it and the elf file is interpreted as a shell script.
Heads is built as an i386 kernel, isn't it?

@tlaurion
Copy link
Collaborator

tlaurion commented Jun 7, 2020

@Siproqu coreboot only is I386

@Siproqu
Copy link
Author

Siproqu commented Jul 16, 2020

As I do not have the time to test it again and the settings applied by nvramcui won't change frequently anyways, here is a workaround.
Obviously the linked patch file of the workaround has to be adjusted for the user's needs.

@Siproqu Siproqu closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants