default driver parameters #7

sthibaul · 2021-02-08T09:27:55Z

It would be useful to be able to specify the default driver parameters among the module command parameters, so that one can record for instance

options speakup_dectlk rate=200

in /etc/modprobe.d/something.conf

The text was updated successfully, but these errors were encountered:

osmten · 2022-09-26T13:11:27Z

I'm fairly new to kernel development and Speakup seems very interesting and meaningful project for me. Since this is tagged as "good first issue", I would start with this.

Modprobe command seems to take arguments specified in /etc/modprobe.d/something.conf for every kernel module. I think modprobe would do the same for speakup modules as well. This will be done by a user in userspace, writing arguments to a .conf file in /etc/modprobe.d/filename.conf and running modprobe command on a speakup module.

I'm trying to understand the issue, please correct me if I'm wrong. Is this the issue about specifying sane default arguments in the docs so the users can write to /etc/modprobe.d/filename.conf. Any help or elaboration would be appreciated.

Thank you.

sthibaul · 2022-09-26T14:31:10Z

Hello,
Thanks for joining!
Support for taking parameters from something.conf is already there indeed, but the parameters don't exist yet. In the speakup_dectlk case, speakup_dectlk.c only supports the ser, dev, and start parameters, see the calls to module_param_named and MODULE_PARM_DESC. It would be useful to introduce the other parameters, to change the compile-time default value already set in the vars array.

sthibaul · 2022-09-26T14:32:39Z

See for instance https://lore.kernel.org/r/20220829203625.6s6x57miowu4p664@begin
In that example we hardcoded DIRECT being the first entry of the vars array. To make it more general, we'd probably want to introduce in each file an enum that provides the index of each variable.

osmten · 2022-09-28T18:35:22Z

Thank you for detailed answer. I will look into it.

… the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_soft module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]>

… the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_soft module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]>

… the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_acntpc.c and speakup_acntsa.c module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_audptr module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_apollo module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]>

…mong the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_bns module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]>

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_soft module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

… the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_acntpc.c and speakup_acntsa.c module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_apollo module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…mong the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_bns module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_audptr module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_decext module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_dectlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_dummy module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_spkout module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_txprt module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_ltlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

SikkiLadho · 2022-10-31T07:31:21Z

Hi,
There's spk_vars for core speakup module(speakup.ko), should they also be parametrized as module parameters?

sthibaul · 2022-10-31T08:51:04Z

That would be useful as well, yes

SikkiLadho · 2022-11-01T06:07:17Z

Moreover, there's a description for these vars in Documentation/ABI/stable/sysfs-driver-speakup. Should we add that description in the MODULE_PARAM_DESC() or just "set x variable on load" will be enough?

sthibaul · 2022-11-01T10:08:38Z

The description from Documentation would be useful yes.

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_dtlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_soft module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_apollo module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_audptr module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…mong the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_bns module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_decext module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_decpc module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_dectlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_dtlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_dummy module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_keypc module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_ltlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_spkout module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_txprt module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_acntpc module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_acntsa module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]>

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_soft module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_apollo module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_audptr module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…mong the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_bns module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_decext module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_decpc module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_dectlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_dtlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_dummy module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_keypc module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_ltlk module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_spkout module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

… among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding a default variables to the speakup_txprt module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_acntpc module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

…s among the module params This is an enhancement which allows to specify the default driver parameters among the module parameters. Adding default variables to the speakup_acntsa module allows to easily set that at boot, rather than setting the sys variables after boot. More details can be found here: linux-speakup/speakup#7 Signed-off-by: Osama Muhammad <[email protected]> Reviewed-by: Samuel Thibault <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>

sthibaul added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

default driver parameters #7

default driver parameters #7

sthibaul commented Feb 8, 2021

osmten commented Sep 26, 2022

sthibaul commented Sep 26, 2022

sthibaul commented Sep 26, 2022

osmten commented Sep 28, 2022

SikkiLadho commented Oct 31, 2022

sthibaul commented Oct 31, 2022

SikkiLadho commented Nov 1, 2022

sthibaul commented Nov 1, 2022

default driver parameters #7

default driver parameters #7

Comments

sthibaul commented Feb 8, 2021

osmten commented Sep 26, 2022

sthibaul commented Sep 26, 2022

sthibaul commented Sep 26, 2022

osmten commented Sep 28, 2022

SikkiLadho commented Oct 31, 2022

sthibaul commented Oct 31, 2022

SikkiLadho commented Nov 1, 2022

sthibaul commented Nov 1, 2022