Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply LlamaConfig(head_dim) #526

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Apply LlamaConfig(head_dim) #526

wants to merge 2 commits into from

Conversation

austin362667
Copy link
Collaborator

Summary

Closes #525. Update LlamaRotaryEmbedding inputs.

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@austin362667
use LlamaConfig(head_dim)
460cfaf 
Signed-off-by: Austin Liu <[email protected]>
@austin362667
fix
83dcd59 
Signed-off-by: Austin Liu <[email protected]>
@austin362667
Copy link
Collaborator Author

#523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LlamaRotaryEmbedding Input Argument Is Inconsistent with Hugging Face
1 participant
@austin362667