Skip to content

Remove 2 deprecated CLI options of linera wallet init #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ma2bd opened this issue Feb 23, 2025 · 3 comments · Fixed by #3910
Closed

Remove 2 deprecated CLI options of linera wallet init #3399

ma2bd opened this issue Feb 23, 2025 · 3 comments · Fixed by #3910
Assignees
@afck
Labels
needs discussion triage

Comments

@ma2bd
Copy link
Contributor

ma2bd commented Feb 23, 2025

Remove 2 CLI options of linera wallet init:

  • --with-new-chain (people should use linera wallet request-chain)
  • --with-other-chains (people should use linera wallet follow-chain)

Also remove the FaucetOptions in cli_wrapper.

This should be easy but

  • e2e tests need to be upgraded (mostly simplified)
  • We need to decide what to do with print_peg_certificate_hash
@ownwift

This comment was marked as spam.

Sign in to view
@afck
Copy link
Contributor

afck commented Feb 25, 2025

We need to decide what to do with print_peg_certificate_hash

Maybe linera wallet init should just always synchronize the admin chain, and print its latest hash.

@afck
Copy link
Contributor

afck commented May 8, 2025

I realized we already don't sync automatically on wallet initialization anymore.

I'll remove the info message for now and created #3909.

@afck afck mentioned this issue May 8, 2025
Merged
@afck afck closed this as completed in ad89e29 May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afck afck

Labels
needs discussion triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove 2 deprecated CLI options of linera wallet init. afck/linera-protocol
3 participants
@ma2bd @afck @ownwift