Skip to content

Commit 94d2c83

Browse files
committed
Add new queue wait time metrics to dashboard
1 parent cc4890a commit 94d2c83

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

kubernetes/linera-validator/grafana-dashboards/linera/execution.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1158,8 +1158,8 @@
11581158
"uid": "prometheus"
11591159
},
11601160
"editorMode": "code",
1161-
"expr": "histogram_quantile(0.50, sum(rate(linera_chain_worker_request_queue_wait_time_bucket{validator=~\"$validator\"}[1m])) by (le))",
1162-
"legendFormat": "p50",
1161+
"expr": "histogram_quantile(0.50, sum(rate(linera_chain_worker_queue_wait_time_bucket{validator=~\"$validator\"}[1m])) by (le, queue_type))",
1162+
"legendFormat": "p50 {{queue_type}}",
11631163
"range": true,
11641164
"refId": "A"
11651165
},
@@ -1169,8 +1169,8 @@
11691169
"uid": "prometheus"
11701170
},
11711171
"editorMode": "code",
1172-
"expr": "histogram_quantile(0.90, sum(rate(linera_chain_worker_request_queue_wait_time_bucket{validator=~\"$validator\"}[1m])) by (le))",
1173-
"legendFormat": "p90",
1172+
"expr": "histogram_quantile(0.90, sum(rate(linera_chain_worker_queue_wait_time_bucket{validator=~\"$validator\"}[1m])) by (le, queue_type))",
1173+
"legendFormat": "p90 {{queue_type}}",
11741174
"range": true,
11751175
"refId": "B"
11761176
},
@@ -1180,13 +1180,13 @@
11801180
"uid": "prometheus"
11811181
},
11821182
"editorMode": "code",
1183-
"expr": "histogram_quantile(0.99, sum(rate(linera_chain_worker_request_queue_wait_time_bucket{validator=~\"$validator\"}[1m])) by (le))",
1184-
"legendFormat": "p99",
1183+
"expr": "histogram_quantile(0.99, sum(rate(linera_chain_worker_queue_wait_time_bucket{validator=~\"$validator\"}[1m])) by (le, queue_type))",
1184+
"legendFormat": "p99 {{queue_type}}",
11851185
"range": true,
11861186
"refId": "C"
11871187
}
11881188
],
1189-
"title": "Chain Worker Request Queue Wait Time",
1189+
"title": "Chain Worker Queue Wait Time",
11901190
"type": "timeseries"
11911191
},
11921192
{

linera-core/src/chain_worker/actor.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -551,11 +551,11 @@ where
551551

552552
while count < cross_chain_batch_size {
553553
match Pin::new(&mut cross_chain_updates).next().now_or_never() {
554-
Some(Some((req, _span, enqueued_at))) => {
554+
Some(Some((req, _span, _enqueued_at))) => {
555555
#[cfg(with_metrics)]
556556
metrics::CHAIN_WORKER_QUEUE_WAIT_TIME
557557
.with_label_values(&["cross_chain_updates"])
558-
.observe(enqueued_at.elapsed().as_millis() as f64);
558+
.observe(_enqueued_at.elapsed().as_millis() as f64);
559559
updates.entry(req.origin).or_default().extend(req.bundles);
560560
callbacks_by_origin
561561
.entry(req.origin)
@@ -613,11 +613,11 @@ where
613613

614614
while count < cross_chain_batch_size {
615615
match Pin::new(&mut confirmations).next().now_or_never() {
616-
Some(Some((req, _span, enqueued_at))) => {
616+
Some(Some((req, _span, _enqueued_at))) => {
617617
#[cfg(with_metrics)]
618618
metrics::CHAIN_WORKER_QUEUE_WAIT_TIME
619619
.with_label_values(&["confirmations"])
620-
.observe(enqueued_at.elapsed().as_millis() as f64);
620+
.observe(_enqueued_at.elapsed().as_millis() as f64);
621621
confirmations_map
622622
.entry(req.recipient)
623623
.and_modify(|h| *h = (*h).max(req.latest_height))
@@ -646,15 +646,15 @@ where
646646
}
647647
RequestType::Regular => {
648648
for _ in 0..regular_batch_size {
649-
let Some(Some((request, span, enqueued_at))) =
649+
let Some(Some((request, span, _enqueued_at))) =
650650
Pin::new(&mut requests).next().now_or_never()
651651
else {
652652
break;
653653
};
654654
#[cfg(with_metrics)]
655655
metrics::CHAIN_WORKER_QUEUE_WAIT_TIME
656656
.with_label_values(&["regular"])
657-
.observe(enqueued_at.elapsed().as_millis() as f64);
657+
.observe(_enqueued_at.elapsed().as_millis() as f64);
658658
Box::pin(worker.handle_request(request))
659659
.instrument(span)
660660
.await;

0 commit comments

Comments
 (0)