Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serde support for re-exported Peniko types #614

Closed
timtom-dev opened this issue Jun 17, 2024 · 1 comment
Closed

Serde support for re-exported Peniko types #614

timtom-dev opened this issue Jun 17, 2024 · 1 comment

Comments

@timtom-dev
Copy link
Contributor

Peniko has a "serde" feature flag that derives serialization for its types. Vello re-exports Peniko, but doesn't have a serde flag. So, if you use the Peniko exported from Vello, there's no way to enable serde for those types.

@DJMcNab
Copy link
Member

DJMcNab commented Jun 18, 2024

Vello does not currently directly support serialisation - I think if we were to create a serde flag, it would when we added actual support for doing serialisation properly.

I'd recommend using:

[dependencies]
vello = "..."
peniko = { version = "*", default-features = false, features = ["serde"] }

in the near term, which should enable what you need.
Using a "*" dependency is not normally what you want, but in this case you want the version to be selected by Vello.

@DJMcNab DJMcNab closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants