Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename scene.reset() to scene.clear() #472

Closed
wants to merge 1 commit into from
Closed

Rename scene.reset() to scene.clear() #472

wants to merge 1 commit into from

Conversation

DasLixou
Copy link
Collaborator

Closes #469

@dfrg
Copy link
Collaborator

dfrg commented Feb 26, 2024

FWIW I specifically chose reset over clear because clear might be ambiguous in that it could apply filling the target with a color.

@DasLixou
Copy link
Collaborator Author

Closing this and the issue then? (Issue is not from me)

@xStrom
Copy link
Member

xStrom commented Feb 29, 2024

We decided at office hours 2024-02-29 that we will not go ahead with this rename. Thank you for your effort anyway!

@xStrom xStrom closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scene::reset() should be renamed to Scene::clear()
3 participants
@DasLixou @dfrg @xStrom