Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to render emojis causes system freeze #142

Closed
dvc94ch opened this issue Jan 10, 2022 · 4 comments
Closed

trying to render emojis causes system freeze #142

dvc94ch opened this issue Jan 10, 2022 · 4 comments

Comments

@dvc94ch
Copy link

dvc94ch commented Jan 10, 2022

hard to provide a reproducer as I've modified stuff in different places. also it would be bordering on distributing malware. any suggestions how to debug a system freeze?

@raphlinus
Copy link
Contributor

It's very hard to diagnose. Can you say more about what you're running it on?

I do have one place I'm seeing GPU timeouts, which is #139. I started digging into it but have put it on the back burner for now.

@dvc94ch
Copy link
Author

dvc94ch commented Jan 10, 2022

so made sure that the thing panics before rendering to avoid system freezes. seems like the problem is that the glyph only provides a bitmap and no outlines which isn't handled and then causes a ctx.fill_glyph without a glyph being encoded. Letting make_path return None doesn't render the emoji, but it prevents a freeze.

next question would be, how to go about rendering the bitmap?

@raphlinus
Copy link
Contributor

There is FillImage support in the shaders, but the CPU-side support for it is currently missing. I will add it, but no guarantees when.

@DJMcNab
Copy link
Member

DJMcNab commented Feb 11, 2023

Since this issue was opened, we've migrated to wgpu (in #193)

I think things are likely to be different enough since then, and since no reproduction was reached, I'm going to close this out.

@DJMcNab DJMcNab closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants