CLI v1.1.0+ doesn't read tsconfig.json when --project is not specified

[heguro]

Current behavior

Initialize my repository for reproduce:

$ git clone https://github.com/heguro/20241216-tsr-test
$ cd 20241216-tsr-test
$ npm i

When running tsr without --project: Incorrect output, doesn't read tsconfig.json

$ npx tsr 'main\.ts$'
tsconfig using default options
Project has 3 files. Found 1 entrypoint file
file   src/app/app.ts
file   src/fn/util.ts
✖ delete 2 files

When running tsr with --project: Correct output

$ npx tsr -p tsconfig.json 'main\.ts$'
tsconfig tsconfig.json
Project has 3 files. Found 1 entrypoint file
export src/fn/util.ts:4:0     'unusedFunc'
✖ remove 1 export

Root Cause

• In the new CLI implementation released in v1.1.0, --project's default value is '', not undefined or 'tsconfig.json'.

  • tsr/lib/cli.ts

    Lines 8 to 15 in 83a7f3b

    	{
    	name: 'project',
    	alias: 'p',
    	type: 'string',
    	param: '<file>',
    	description: 'Path to your tsconfig.json',
    	default: '',
    	},

• While 'tsconfig.json' is set as the default value for the configFile parameter in the tsr function, it is not used when '' is passed.

  • tsr/lib/cli.ts

    Line 104 in 83a7f3b

    configFile: parsed.project ?? undefined,

  • tsr/lib/tsr.ts

    Line 41 in 83a7f3b

    configFile = 'tsconfig.json',

• This generates an incorrect configPath, causing ts.readConfigFile() to fail.

[kazushisan]

@heguro thank you very much for the detailed report! I've fixed this issue in https://github.com/line/tsr/releases/tag/v1.3.1

[kazushisan]

added test cases to prevent future degrade in #107