Skip to content

Conversation

@dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Aug 25, 2025

Fixes #334

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (919fe82) to head (ad7a825).
⚠️ Report is 144 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          18       18           
  Lines        1774     1774           
=======================================
  Hits         1741     1741           
  Misses         33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

Before [919fe82] After [9b52ecf] Ratio Benchmark (Parameter)
927M 994M 1.07 benchmarks.ReadFewColumnsS3.peakmem_run
44.6±0.8ms 45.1±0.5ms 1.01 benchmarks.ReassignHalfOfNestedSeries.time_run
250M 250M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
32.4±1ms 32.5±1ms 1 benchmarks.AssignSingleDfToNestedSeries.time_run
64.5±0.2ms 64.5±0.5ms 1 benchmarks.CountNestedBy.time_run
177M 176M 1 benchmarks.ReadFewColumnsHTTPS.peakmem_run
1.92±0.01s 1.93±0.03s 1 benchmarks.ReadFewColumnsHTTPS.time_run
270M 270M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
136M 135M 0.99 benchmarks.CountNestedBy.peakmem_run
103M 102M 0.99 benchmarks.NestedFrameAddNested.peakmem_run

Click here to view all benchmarks.

@dougbrn dougbrn marked this pull request as ready for review August 25, 2025 19:19
@dougbrn dougbrn requested a review from gitosaurus August 25, 2025 19:19
Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dougbrn dougbrn merged commit 34cd4d6 into main Aug 25, 2025
11 checks passed
@dougbrn dougbrn deleted the nest_lists_fix branch August 25, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Identical catalog indices cause nest_lists to duplicate rows

3 participants