TF-4081 Auto re-login with user email on 401 error for mobile

Author: dab246

lib/features/base/base_controller.dart

@@ -25,9 +25,11 @@ import 'package:tmail_ui_user/features/home/domain/extensions/session_extensions
 import 'package:tmail_ui_user/features/login/data/network/config/oidc_constant.dart';
 import 'package:tmail_ui_user/features/login/data/network/interceptors/authorization_interceptors.dart';
 import 'package:tmail_ui_user/features/login/domain/exceptions/logout_exception.dart';
+import 'package:tmail_ui_user/features/login/domain/model/login_source.dart';
 import 'package:tmail_ui_user/features/login/domain/usecases/delete_authority_oidc_interactor.dart';
 import 'package:tmail_ui_user/features/login/domain/usecases/delete_credential_interactor.dart';
 import 'package:tmail_ui_user/features/login/presentation/login_form_type.dart';
+import 'package:tmail_ui_user/features/login/presentation/model/auto_refresh_arguments.dart';
 import 'package:tmail_ui_user/features/login/presentation/model/login_arguments.dart';
 import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/bindings/contact_autocomplete_bindings.dart';
 import 'package:tmail_ui_user/features/mailbox_dashboard/presentation/bindings/tmail_autocomplete_bindings.dart';
@@ -195,10 +197,12 @@ abstract class BaseController extends GetxController
     }
   }
 
-  Future<void> _executeBeforeReconnectAndLogOut() async {
+  Future<void> _executeBeforeReconnectAndLogOut({
+    LoginSource source = LoginSource.manual,
+  }) async {
     twakeAppManager.setExecutingBeforeReconnect(true);
     await executeBeforeReconnect();
-    clearDataAndGoToLoginPage();
+    clearDataAndGoToLoginPage(source: source);
   }
 
   void onCancelReconnectWhenSessionExpired() {}
@@ -229,9 +233,9 @@ abstract class BaseController extends GetxController
   void handleBadCredentialsException() {
     log('$runtimeType::handleBadCredentialsException:');
     if (twakeAppManager.hasComposer) {
-      _performSaveAndReconnection();
+      _performSaveAndReconnection(source: LoginSource.auto);
     } else {
-      _performReconnection();
+      _performReconnection(source: LoginSource.auto);
     }
   }
 
@@ -250,16 +254,20 @@ abstract class BaseController extends GetxController
     }
   }
 
-  void _performSaveAndReconnection() {
+  void _performSaveAndReconnection({
+    LoginSource source = LoginSource.manual,
+  }) {
     if (PlatformInfo.isWeb) {
-      _executeBeforeReconnectAndLogOut();
+      _executeBeforeReconnectAndLogOut(source: source);
     } else if (PlatformInfo.isMobile) {
-      clearDataAndGoToLoginPage();
+      clearDataAndGoToLoginPage(source: source);
     }
   }
 
-  void _performReconnection() {
-    clearDataAndGoToLoginPage();
+  void _performReconnection({
+    LoginSource source = LoginSource.manual,
+  }) {
+    clearDataAndGoToLoginPage(source: source);
   }
 
   void onDataFailureViewState(Failure failure) {
@@ -420,9 +428,24 @@ abstract class BaseController extends GetxController
     }
   }
 
-  void removeAllPageAndGoToLogin() {
+  void removeAllPageAndGoToLogin({
+    LoginSource source = LoginSource.manual,
+  }) {
     if (PlatformInfo.isMobile) {
-      pushAndPopAll(AppRoutes.twakeWelcome);
+      final jmapUrl = dynamicUrlInterceptors.jmapUrl ?? '';
+
+      final isAutoRefresh = source == LoginSource.auto &&
+          Get.currentRoute != AppRoutes.login &&
+          jmapUrl.isNotEmpty;
+
+      if (isAutoRefresh) {
+        pushAndPopAll(
+          AppRoutes.login,
+          arguments: AutoRefreshArguments(jmapUrl),
+        );
+      } else {
+        pushAndPopAll(AppRoutes.twakeWelcome);
+      }
     } else {
       navigateToLoginPage();
     }
@@ -564,10 +587,12 @@ abstract class BaseController extends GetxController
     await beforeReconnectManager?.executeBeforeReconnectListeners();
   }
 
-  Future<void> clearDataAndGoToLoginPage() async {
-    log('$runtimeType::clearDataAndGoToLoginPage:');
+  Future<void> clearDataAndGoToLoginPage({
+    LoginSource source = LoginSource.manual,
+  }) async {
+    log('$runtimeType::clearDataAndGoToLoginPage: Login source is $source');
     await clearAllData();
-    removeAllPageAndGoToLogin();
+    removeAllPageAndGoToLogin(source: source);
   }
 
   Future<void> clearAllData() async {

lib/features/login/domain/model/login_source.dart

@@ -0,0 +1,4 @@
+enum LoginSource {
+  manual,   // User manually logs in
+  auto     // Auto retry after 401
+}

lib/features/login/presentation/login_controller.dart

@@ -53,6 +53,7 @@ import 'package:tmail_ui_user/features/login/domain/usecases/try_guessing_web_fi
 import 'package:tmail_ui_user/features/login/presentation/extensions/generate_oidc_guessing_urls.dart';
 import 'package:tmail_ui_user/features/login/presentation/extensions/handle_openid_configuration.dart';
 import 'package:tmail_ui_user/features/login/presentation/login_form_type.dart';
+import 'package:tmail_ui_user/features/login/presentation/model/auto_refresh_arguments.dart';
 import 'package:tmail_ui_user/features/login/presentation/model/login_arguments.dart';
 import 'package:tmail_ui_user/features/starting_page/domain/state/sign_in_twake_workplace_state.dart';
 import 'package:tmail_ui_user/features/starting_page/domain/usecase/sign_in_twake_workplace_interactor.dart';
@@ -140,6 +141,8 @@ class LoginController extends ReloadableController {
       if (PlatformInfo.isWeb) {
         _checkOIDCIsAvailable();
       }
+    } else if (arguments is AutoRefreshArguments) {
+      _handleDNSLookupToGetJmapUrlSuccess(arguments.jmapUrl);
     } else if (PlatformInfo.isWeb) {
       _getAuthenticationInfo();
     }
@@ -194,7 +197,7 @@ class LoginController extends ReloadableController {
     } else if (success is AuthenticationUserSuccess) {
       _loginSuccessAction(success);
     } else if (success is DNSLookupToGetJmapUrlSuccess) {
-      _handleDNSLookupToGetJmapUrlSuccess(success);
+      _handleDNSLookupToGetJmapUrlSuccess(success.jmapUrl);
     } else if (success is TryGuessingWebFingerSuccess) {
       onBaseUrlChange(success.oidcResponse.subject);
       getOIDCConfiguration(success.oidcResponse);
@@ -542,8 +545,8 @@ class LoginController extends ReloadableController {
     }
   }
 
-  void _handleDNSLookupToGetJmapUrlSuccess(DNSLookupToGetJmapUrlSuccess success) {
-    onBaseUrlChange(success.jmapUrl);
+  void _handleDNSLookupToGetJmapUrlSuccess(String jmapUrl) {
+    onBaseUrlChange(jmapUrl);
     _checkOIDCIsAvailable();
   }
 

lib/features/login/presentation/model/auto_refresh_arguments.dart

@@ -0,0 +1,10 @@
+import 'package:tmail_ui_user/main/routes/router_arguments.dart';
+
+class AutoRefreshArguments extends RouterArguments {
+  final String jmapUrl;
+
+  AutoRefreshArguments(this.jmapUrl);
+
+  @override
+  List<Object?> get props => [jmapUrl];
+}

lib/main/exceptions/remote_exception_thrower.dart

@@ -1,6 +1,7 @@
 import 'dart:io';
 
 import 'package:core/utils/app_logger.dart';
+import 'package:core/utils/platform_info.dart';
 import 'package:dio/dio.dart';
 import 'package:get/get_connect/http/src/status/http_status.dart';
 import 'package:jmap_dart_client/jmap/core/error/method/error_method_response.dart';
@@ -30,16 +31,21 @@ class RemoteExceptionThrower extends ExceptionThrower {
   }
 
   void handleDioError(dynamic error) {
+    logError('RemoteExceptionThrower::handleDioError(): ${error.runtimeType}');
     if (error is ChainedRequestError) {
       final statusCode = error.primaryError.response?.statusCode;
       final secondaryError = error.secondaryError;
-      if (statusCode == HttpStatus.unauthorized && secondaryError != null) {
+      if (PlatformInfo.isMobile &&
+          statusCode == HttpStatus.unauthorized &&
+          secondaryError != null) {
         throw ClientAuthenticationException(
           code: HttpStatus.unauthorized,
           secondErrorCode: getCodeByError(secondaryError),
           message: getMessageByError(secondaryError),
         );
       }
+
+      error = error.primaryError.copyWith(error: secondaryError);
     }
 
     if (error is DioError) {

lib/main/utils/toast_manager.dart

@@ -149,7 +149,7 @@ class ToastManager {
             exception,
             useDefaultMessage: true,
           );
-    } else if (_isEmptySpamFolderFailure(exception)) {
+    } else if (_isEmptySpamFolderFailure(failure)) {
       message = message ?? AppLocalizations.of(context).emptySpamFolderFailed;
     } else if (_isEmptyTrashFolderFailure(failure)) {
       message = message ?? AppLocalizations.of(context).emptyTrashFolderFailed;