TF-4081 Try to categorize the errors and display them to the user.

dab246 · dab246 · commit 4c933de7e516 · 2025-10-22T09:34:16.000+07:00
diff --git a/lib/features/base/base_controller.dart b/lib/features/base/base_controller.dart
@@ -1,11 +1,12 @@
 import 'dart:async';
-import 'package:core/core.dart';
-import 'package:flutter/services.dart' as services;
+
 import 'package:contact/contact/model/capability_contact.dart';
+import 'package:core/core.dart';
 import 'package:dartz/dartz.dart';
 import 'package:fcm/model/firebase_capability.dart';
 import 'package:fcm/model/firebase_registration_id.dart';
 import 'package:flutter/material.dart';
+import 'package:flutter/services.dart' as services;
 import 'package:flutter_svg/flutter_svg.dart';
 import 'package:forward/forward/capability_forward.dart';
 import 'package:get/get.dart';
@@ -56,8 +57,8 @@ import 'package:tmail_ui_user/main/exceptions/remote_exception.dart';
 import 'package:tmail_ui_user/main/localizations/app_localizations.dart';
 import 'package:tmail_ui_user/main/routes/app_routes.dart';
 import 'package:tmail_ui_user/main/routes/route_navigation.dart';
-import 'package:tmail_ui_user/main/utils/app_config.dart';
 import 'package:tmail_ui_user/main/universal_import/html_stub.dart' as html;
+import 'package:tmail_ui_user/main/utils/app_config.dart';
 import 'package:tmail_ui_user/main/utils/toast_manager.dart';
 import 'package:tmail_ui_user/main/utils/twake_app_manager.dart';
 import 'package:uuid/uuid.dart';
@@ -152,7 +153,8 @@ abstract class BaseController extends GetxController
   bool validateUrgentException(dynamic exception) {
     return exception is NoNetworkError
       || exception is BadCredentialsException
-      || exception is ConnectionError;
+      || exception is ConnectionError
+      || exception is ClientAuthenticationException;
   }
 
   void handleErrorViewState(Object error, StackTrace stackTrace) {}
@@ -169,10 +171,14 @@ abstract class BaseController extends GetxController
 
   void handleUrgentExceptionOnMobile({Failure? failure, Exception? exception}) {
     logError('$runtimeType::handleUrgentExceptionOnMobile():Failure: $failure | Exception: $exception');
-    if (exception is ConnectionError) {
+    if (exception is NoNetworkError) {
+      _handleNotNetworkErrorException();
+    } else if (exception is ConnectionError) {
       _handleConnectionErrorException();
     } else if (exception is BadCredentialsException) {
       handleBadCredentialsException();
+    } else if (exception is ClientAuthenticationException) {
+      handleClientAuthenticationException(exception);
     }
   }
 
@@ -184,6 +190,8 @@ abstract class BaseController extends GetxController
       _handleConnectionErrorException();
     } else if (exception is BadCredentialsException) {
       handleBadCredentialsException();
+    } else if (exception is ClientAuthenticationException) {
+      handleClientAuthenticationException(exception);
     }
   }
 
@@ -213,7 +221,8 @@ abstract class BaseController extends GetxController
         leadingSVGIcon: imagePaths.icNotConnection,
         backgroundColor: AppColor.textFieldErrorBorderColor,
         textColor: Colors.white,
-        infinityToast: true);
+        infinityToast: PlatformInfo.isWeb,
+      );
     }
   }
 
@@ -226,6 +235,21 @@ abstract class BaseController extends GetxController
     }
   }
 
+  void handleClientAuthenticationException(
+    ClientAuthenticationException exception,
+  ) {
+    final message = exception.message;
+    final firstErrorCode = exception.code;
+    final secondErrorCode = exception.secondErrorCode;
+    log('$runtimeType::handleClientAuthenticationException: Message is $message, [$firstErrorCode - $secondErrorCode]');
+    if (currentOverlayContext != null && currentContext != null) {
+      appToast.showToastErrorMessage(
+        currentOverlayContext!,
+        '$message [$firstErrorCode - $secondErrorCode]',
+      );
+    }
+  }
+
   void _performSaveAndReconnection() {
     if (PlatformInfo.isWeb) {
       _executeBeforeReconnectAndLogOut();
diff --git a/lib/features/login/data/network/interceptors/authorization_interceptors.dart b/lib/features/login/data/network/interceptors/authorization_interceptors.dart
@@ -14,9 +14,9 @@ import 'package:model/oidc/token_oidc.dart';
 import 'package:tmail_ui_user/features/login/data/local/account_cache_manager.dart';
 import 'package:tmail_ui_user/features/login/data/local/token_oidc_cache_manager.dart';
 import 'package:tmail_ui_user/features/login/data/network/authentication_client/authentication_client_base.dart';
-import 'package:tmail_ui_user/features/login/domain/exceptions/oauth_authorization_error.dart';
 import 'package:tmail_ui_user/features/login/domain/extensions/oidc_configuration_extensions.dart';
 import 'package:tmail_ui_user/features/upload/data/network/file_uploader.dart';
+import 'package:tmail_ui_user/main/exceptions/chained_request_error.dart';
 import 'package:tmail_ui_user/main/utils/ios_sharing_manager.dart';
 
 class AuthorizationInterceptors extends QueuedInterceptorsWrapper {
@@ -86,81 +86,46 @@ class AuthorizationInterceptors extends QueuedInterceptorsWrapper {
     logError('AuthorizationInterceptors::onError(): DIO_ERROR = $err');
     try {
       final requestOptions = err.requestOptions;
-      final extraInRequest = requestOptions.extra;
-      bool isRetryRequest = false;
+      final extra = requestOptions.extra;
 
-      if (validateToRefreshToken(
+      // Decide whether we need to refresh or retry
+      final shouldRefresh = validateToRefreshToken(
         responseStatusCode: err.response?.statusCode,
-        tokenOIDC: _token
-      )) {
-        log('AuthorizationInterceptors::onError: Perform get New Token');
-        final newTokenOidc = PlatformInfo.isIOS
-          ? await _getNewTokenForIOSPlatform()
-          : await _getNewTokenForOtherPlatform();
-
-        if (newTokenOidc.token == _token?.token) {
-          log('AuthorizationInterceptors::onError: Token duplicated');
-          return super.onError(err, handler);
-        }
-        _updateNewToken(newTokenOidc);
-
-        final personalAccount = await _updateCurrentAccount(tokenOIDC: newTokenOidc);
-
-        if (PlatformInfo.isIOS) {
-          await _iosSharingManager.saveKeyChainSharingSession(personalAccount);
-        }
-
-        isRetryRequest = true;
-      } else if (validateToRetryTheRequestWithNewToken(
+        tokenOIDC: _token,
+      );
+      final shouldRetryWithNewToken = validateToRetryTheRequestWithNewToken(
         authHeader: requestOptions.headers[HttpHeaders.authorizationHeader],
-        tokenOIDC: _token
-      )) {
-        log('AuthorizationInterceptors::onError: Request using old token');
-        isRetryRequest = true;
-      } else {
+        tokenOIDC: _token,
+      );
+
+      if (!shouldRefresh && !shouldRetryWithNewToken) {
         return super.onError(err, handler);
       }
 
-      if (isRetryRequest) {
-        if (extraInRequest.containsKey(FileUploader.uploadAttachmentExtraKey)) {
-          log('AuthorizationInterceptors::onError: Retry upload request with TokenId = ${_token?.tokenIdHash}');
-          final uploadExtra = extraInRequest[FileUploader.uploadAttachmentExtraKey];
-
-          requestOptions.headers[HttpHeaders.authorizationHeader] = _getTokenAsBearerHeader(_token!.token);
+      // Refresh token if required
+      if (shouldRefresh) {
+        final newToken = await _refreshToken();
+        if (newToken == null) {
+          // Failed or duplicate token
+          return super.onError(err, handler);
+        }
+      }
 
-          final newOptions = Options(
-            method: requestOptions.method,
-            headers: requestOptions.headers,
-          );
+      // Retry request with updated token
+      final updatedAuthHeader = _getTokenAsBearerHeader(_token!.token);
+      requestOptions.headers[HttpHeaders.authorizationHeader] =
+          updatedAuthHeader;
 
-          final response = await _dio.request(
-            requestOptions.path,
-            data: _getDataUploadRequest(uploadExtra),
-            queryParameters: requestOptions.queryParameters,
-            options: newOptions,
-          );
+      final bool isUploadRequest =
+          extra.containsKey(FileUploader.uploadAttachmentExtraKey);
 
-          return handler.resolve(response);
-        } else {
-          log('AuthorizationInterceptors::onError: Retry request with TokenId = ${_token?.tokenIdHash}');
-          requestOptions.headers[HttpHeaders.authorizationHeader] = _getTokenAsBearerHeader(_token!.token);
+      final response = isUploadRequest
+          ? await _retryUploadRequest(requestOptions, extra)
+          : await _retryNormalRequest(requestOptions);
 
-          final response = await _dio.fetch(requestOptions);
-          return handler.resolve(response);
-        }
-      } else {
-        return super.onError(err, handler);
-      }
+      return handler.resolve(response);
     } catch (e) {
-      logError('AuthorizationInterceptors::onError:Exception: $e');
-      if (e is ServerError || e is TemporarilyUnavailable) {
-        return super.onError(
-          DioError(requestOptions: err.requestOptions, error: e),
-          handler,
-        );
-      } else {
-        return super.onError(err.copyWith(error: e), handler);
-      }
+      return _handleRetryException(err, handler, e);
     }
   }
 
@@ -211,24 +176,29 @@ class AuthorizationInterceptors extends QueuedInterceptorsWrapper {
 
   String _getTokenAsBearerHeader(String token) => 'Bearer $token';
 
-  Future<PersonalAccount> _updateCurrentAccount({required TokenOIDC tokenOIDC}) async {
-    final currentAccount = await _accountCacheManager.getCurrentAccount();
+  Future<PersonalAccount?> _updateCurrentAccount({required TokenOIDC tokenOIDC}) async {
+    try {
+      final currentAccount = await _accountCacheManager.getCurrentAccount();
 
-    await _accountCacheManager.deleteCurrentAccount(currentAccount.id);
+      await _accountCacheManager.deleteCurrentAccount(currentAccount.id);
 
-    await _tokenOidcCacheManager.persistOneTokenOidc(tokenOIDC);
+      await _tokenOidcCacheManager.persistOneTokenOidc(tokenOIDC);
 
-    final personalAccount = PersonalAccount(
-      tokenOIDC.tokenIdHash,
-      AuthenticationType.oidc,
-      isSelected: true,
-      accountId: currentAccount.accountId,
-      apiUrl: currentAccount.apiUrl,
-      userName: currentAccount.userName
-    );
-    await _accountCacheManager.setCurrentAccount(personalAccount);
+      final personalAccount = PersonalAccount(
+          tokenOIDC.tokenIdHash,
+          AuthenticationType.oidc,
+          isSelected: true,
+          accountId: currentAccount.accountId,
+          apiUrl: currentAccount.apiUrl,
+          userName: currentAccount.userName
+      );
+      await _accountCacheManager.setCurrentAccount(personalAccount);
 
-    return personalAccount;
+      return personalAccount;
+    } catch (e) {
+      logError('AuthorizationInterceptors::_updateCurrentAccount: Exception = $e');
+      return null;
+    }
   }
 
   Future<TokenOIDC?> _getTokenInKeychain(TokenOIDC currentTokenOidc) async {
@@ -275,6 +245,67 @@ class AuthorizationInterceptors extends QueuedInterceptorsWrapper {
     return _invokeRefreshTokenFromServer();
   }
 
+  Future<TokenOIDC?> _refreshToken() async {
+    log('AuthorizationInterceptors::onError: Perform get New Token');
+
+    final newToken = PlatformInfo.isIOS
+        ? await _getNewTokenForIOSPlatform()
+        : await _getNewTokenForOtherPlatform();
+
+    // Skip if duplicated
+    if (newToken.token == _token?.token) {
+      log('AuthorizationInterceptors::onError: Token duplicated');
+      return null;
+    }
+
+    _updateNewToken(newToken);
+
+    final account = await _updateCurrentAccount(tokenOIDC: newToken);
+    if (PlatformInfo.isIOS && account != null) {
+      await _iosSharingManager.saveKeyChainSharingSession(account);
+    }
+
+    return newToken;
+  }
+
+  Future<Response<dynamic>> _retryNormalRequest(RequestOptions options) async {
+    log('AuthorizationInterceptors::_retryNormalRequest: Retry request with TokenId = ${_token?.tokenIdHash}');
+    return _dio.fetch(options);
+  }
+
+  Future<Response<dynamic>> _retryUploadRequest(
+    RequestOptions options,
+    Map<String, dynamic> extra,
+  ) async {
+    log('AuthorizationInterceptors::_retryUploadRequest: Retry upload request with TokenId = ${_token?.tokenIdHash}');
+    final uploadExtra = extra[FileUploader.uploadAttachmentExtraKey];
+    final newOptions = Options(
+      method: options.method,
+      headers: options.headers,
+    );
+
+    return _dio.request(
+      options.path,
+      data: _getDataUploadRequest(uploadExtra),
+      queryParameters: options.queryParameters,
+      options: newOptions,
+    );
+  }
+
+  Future<void> _handleRetryException(
+    DioError err,
+    ErrorInterceptorHandler handler,
+    Object e,
+  ) async {
+    logError('AuthorizationInterceptors::_handleRetryException:Exception: $e');
+    final chainedError = ChainedRequestError(
+      requestOptions: err.requestOptions,
+      primaryError: err,
+      secondaryError: e,
+    );
+    return super.onError(chainedError, handler);
+  }
+
   void clear() {
     _authorization = null;
     _token = null;
diff --git a/lib/main/exceptions/chained_request_error.dart b/lib/main/exceptions/chained_request_error.dart
@@ -0,0 +1,15 @@
+import 'package:dio/dio.dart';
+
+class ChainedRequestError extends DioError {
+  /// Error from the first request
+  final DioError primaryError;
+
+  /// Error from the second request (retry/refresh)
+  final Object? secondaryError;
+
+  ChainedRequestError({
+    required super.requestOptions,
+    required this.primaryError,
+    this.secondaryError,
+  });
+}
diff --git a/lib/main/exceptions/remote_exception.dart b/lib/main/exceptions/remote_exception.dart
@@ -9,6 +9,7 @@ abstract class RemoteException with EquatableMixin implements Exception {
   static const internalServerError = 'Internal Server Error';
   static const noNetworkError = 'No network error';
   static const badCredentials = 'Bad credentials';
+  static const badResponse = 'Bad response';
   static const socketException = 'Socket exception';
 
   final Object? message;
@@ -28,6 +29,10 @@ class UnknownError extends RemoteException {
   const UnknownError({int? code, Object? message}) : super(code: code, message: message);
 }
 
+class BadResponseException extends RemoteException {
+  const BadResponseException({String? message}) : super(message: message ?? RemoteException.badResponse);
+}
+
 class ConnectionError extends RemoteException {
   const ConnectionError({String? message}) : super(message: message ?? RemoteException.connectionError);
 }
@@ -62,4 +67,14 @@ class CannotCalculateChangesMethodResponseException extends MethodLevelErrors {
 
 class NoNetworkError extends RemoteException {
   const NoNetworkError() : super(message: RemoteException.noNetworkError);
+}
+
+class ClientAuthenticationException extends RemoteException {
+  final String? secondErrorCode;
+
+  const ClientAuthenticationException({
+    super.code,
+    super.message,
+    this.secondErrorCode,
+  });
 }
diff --git a/lib/main/exceptions/remote_exception_thrower.dart b/lib/main/exceptions/remote_exception_thrower.dart
