From b8f8c3a8af24786e3092946918cab58468bc65ad Mon Sep 17 00:00:00 2001 From: emeroad Date: Mon, 25 Sep 2017 16:13:18 +0900 Subject: [PATCH] [#noissue] code style cleanup --- .../handler/AgentStatHandlerV2Test.java | 2 +- .../hbase/parallel/ParallelResultScanner.java | 8 ++++---- .../common/hbase/parallel/ScanTask.java | 2 +- .../server/bo/ActiveTraceHistogramBo.java | 2 +- .../common/server/bo/ServerMetaDataBo.java | 4 ++-- .../common/server/bo/ServiceInfoBo.java | 4 ++-- .../codec/stat/AgentStatDataPointCodec.java | 4 ++-- .../stat/header/BitCountingHeaderEncoder.java | 2 +- .../bo/codec/stat/join/ActiveTraceCodec.java | 2 +- .../bo/codec/stat/join/CpuLoadCodec.java | 2 +- .../bo/codec/stat/join/MemoryCodec.java | 2 +- .../bo/codec/stat/join/ResponseTimeCodec.java | 2 +- .../bo/codec/stat/join/TransactionCodec.java | 2 +- .../server/bo/codec/stat/v1/JvmGcCodecV1.java | 2 +- .../bo/codec/stat/v2/DataSourceCodecV2.java | 2 +- .../strategy/impl/DeltaEncodingStrategy.java | 4 ++-- .../impl/DeltaOfDeltaEncodingStrategy.java | 4 ++-- .../impl/RepeatCountEncodingStrategy.java | 2 +- .../StringRepeatCountEncodingStrategy.java | 2 +- .../impl/StringValueEncodingStrategy.java | 2 +- .../strategy/impl/ValueEncodingStrategy.java | 2 +- .../bo/codec/stat/AgentStatCodecTestBase.java | 4 ++-- .../stat/AgentStatDataPointCodecTest.java | 2 +- .../bo/codec/stat/AgentStatEncoderTest.java | 4 ++-- .../stat/TestAgentStatDataPointFactory.java | 10 +++++----- .../bo/codec/stat/TestAgentStatFactory.java | 18 ++++++++--------- .../header/BitCountingHeaderEncoderTest.java | 20 +++++++++---------- .../UnsignedIntegerEncodingStrategyTest.java | 2 +- .../UnsignedLongEncodingStrategyTest.java | 2 +- .../UnsignedShortEncodingStrategyTest.java | 2 +- .../strategy/EncodingStrategyTestBase.java | 6 +++--- .../AgentStatHbaseOperationFactoryTest.java | 4 ++-- .../plugin/hystrix/HystrixPlugin.java | 2 +- .../profiler/instrument/ASMTryCatch.java | 2 +- .../profiler/AgentInfoSenderTest.java | 6 +++--- ...aultServerMetaDataRegistryServiceTest.java | 4 ++-- .../context/DefaultTraceContextTest.java | 6 +++--- .../active/ActiveTraceRepositoryTest.java | 6 +++--- .../id/DefaultTransactionCounterTest.java | 19 ++++++++---------- .../DefaultTransactionMetricTest.java | 2 +- .../web/controller/MapController.java | 4 ++-- ...aSourceConnectionUsageRateCheckerTest.java | 2 +- .../ApplicationMapBuilderTestHelper.java | 4 ++-- .../mapper/stat/AgentStatMapperV2Test.java | 6 +++--- .../SampledAgentStatResultExtractorTest.java | 2 +- .../web/service/map/LinkSelectorTestBase.java | 2 +- .../web/service/map/LinkVisitCheckerTest.java | 4 ++-- .../vo/stat/chart/DownSamplerTestBase.java | 2 +- 48 files changed, 101 insertions(+), 104 deletions(-) diff --git a/collector/src/test/java/com/navercorp/pinpoint/collector/handler/AgentStatHandlerV2Test.java b/collector/src/test/java/com/navercorp/pinpoint/collector/handler/AgentStatHandlerV2Test.java index e14bfe8d3d74..48e1cebb5d97 100644 --- a/collector/src/test/java/com/navercorp/pinpoint/collector/handler/AgentStatHandlerV2Test.java +++ b/collector/src/test/java/com/navercorp/pinpoint/collector/handler/AgentStatHandlerV2Test.java @@ -201,7 +201,7 @@ private TAgentStatBatch createAgentStatBatch(String agentId, long startTimestamp agentStatBatch.setAgentId(agentId); agentStatBatch.setStartTimestamp(startTimestamp); final List agentStats = new ArrayList<>(numBatches); - for (int i = 0; i < numBatches; ++i) { + for (int i = 0; i < numBatches; i++) { agentStats.add(createAgentStat(agentId, startTimestamp)); } agentStatBatch.setAgentStats(agentStats); diff --git a/commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ParallelResultScanner.java b/commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ParallelResultScanner.java index 8e4a8738599a..3d597bf13262 100644 --- a/commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ParallelResultScanner.java +++ b/commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ParallelResultScanner.java @@ -68,7 +68,7 @@ public ParallelResultScanner(TableName tableName, HbaseAccessor hbaseAccessor, E private Scan[] splitScans(Scan originalScan) throws IOException { Scan[] scans = this.keyDistributor.getDistributedScans(originalScan); - for (int i = 0; i < scans.length; ++i) { + for (int i = 0; i < scans.length; i++) { Scan scan = scans[i]; scan.setId(originalScan.getId() + "-" + i); } @@ -85,10 +85,10 @@ private List createScanTasks(ScanTaskConfig scanTaskConfig, Scan[] spl } else { int maxIndividualScans = (splitScans.length + (numParallelThreads - 1)) / numParallelThreads; List> scanDistributions = new ArrayList<>(numParallelThreads); - for (int i = 0; i < numParallelThreads; ++i) { + for (int i = 0; i < numParallelThreads; i++) { scanDistributions.add(new ArrayList(maxIndividualScans)); } - for (int i = 0; i < splitScans.length; ++i) { + for (int i = 0; i < splitScans.length; i++) { scanDistributions.get(i % numParallelThreads).add(splitScans[i]); } List scanTasks = new ArrayList<>(numParallelThreads); @@ -121,7 +121,7 @@ public Result next() throws IOException { private Result nextInternal() throws IOException { Result result = null; int indexOfResultToUse = -1; - for (int i = 0; i < this.scanTasks.size(); ++i) { + for (int i = 0; i < this.scanTasks.size(); i++) { ScanTask scanTask = this.scanTasks.get(i); // fail fast in case of errors checkTask(scanTask); diff --git a/commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ScanTask.java b/commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ScanTask.java index f5e5fbf272a0..320148c78133 100644 --- a/commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ScanTask.java +++ b/commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ScanTask.java @@ -97,7 +97,7 @@ private ResultScanner createResultScanner(Table table) throws IOException { return table.getScanner(scan); } else { ResultScanner[] scanners = new ResultScanner[this.scans.length]; - for (int i = 0; i < scanners.length; ++i) { + for (int i = 0; i < scanners.length; i++) { scanners[i] = table.getScanner(this.scans[i]); } return new DistributedScanner(this.rowKeyDistributor, scanners); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ActiveTraceHistogramBo.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ActiveTraceHistogramBo.java index 4c785cd22b26..57100ceefe26 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ActiveTraceHistogramBo.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ActiveTraceHistogramBo.java @@ -94,7 +94,7 @@ public ActiveTraceHistogramBo(byte[] serializedActiveTraceHistogramBo) { case 0: int numActiveTraceCounts = buffer.readVInt(); List activeTraceCounts = new ArrayList(numActiveTraceCounts); - for (int i = 0; i < numActiveTraceCounts; ++i) { + for (int i = 0; i < numActiveTraceCounts; i++) { activeTraceCounts.add(buffer.readVInt()); } this.activeTraceCountMap = createActiveTraceCountMap(version, activeTraceCounts); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ServerMetaDataBo.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ServerMetaDataBo.java index c11f672f18ad..d65b9586a349 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ServerMetaDataBo.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ServerMetaDataBo.java @@ -130,12 +130,12 @@ public Builder(final byte[] value) { this.serverInfo = buffer.read2PrefixedString(); final int numVmArgs = buffer.readVInt(); this.vmArgs = new ArrayList(numVmArgs); - for (int i = 0; i < numVmArgs; ++i) { + for (int i = 0; i < numVmArgs; i++) { this.vmArgs.add(buffer.read2PrefixedString()); } final int numServiceInfos = buffer.readVInt(); this.serviceInfos = new ArrayList(numServiceInfos); - for (int i = 0; i < numServiceInfos; ++i) { + for (int i = 0; i < numServiceInfos; i++) { ServiceInfoBo serviceInfoBo = new ServiceInfoBo.Builder(buffer.readPrefixedBytes()).build(); this.serviceInfos.add(serviceInfoBo); } diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ServiceInfoBo.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ServiceInfoBo.java index d52e38c97dff..1467f000ae7c 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ServiceInfoBo.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/ServiceInfoBo.java @@ -50,7 +50,7 @@ public byte[] writeValue() { buffer.put2PrefixedString(this.serviceName); int numServiceLibs = this.serviceLibs == null ? 0 : this.serviceLibs.size(); buffer.putVInt(numServiceLibs); - for (int i = 0; i < numServiceLibs; ++i) { + for (int i = 0; i < numServiceLibs; i++) { buffer.put2PrefixedString(this.serviceLibs.get(i)); } return buffer.getBuffer(); @@ -106,7 +106,7 @@ public Builder(final byte[] value) { this.serviceName = buffer.read2PrefixedString(); final int numServiceLibs = buffer.readVInt(); this.serviceLibs = new ArrayList(numServiceLibs); - for (int i = 0; i < numServiceLibs; ++i) { + for (int i = 0; i < numServiceLibs; i++) { this.serviceLibs.add(buffer.read2PrefixedString()); } } diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatDataPointCodec.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatDataPointCodec.java index 56c4ff37cb5d..d8364779be61 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatDataPointCodec.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatDataPointCodec.java @@ -33,7 +33,7 @@ public void encodeTimestamps(Buffer buffer, List timestamps) { long prevTimestamp = timestamps.get(0); long prevDelta = 0; // skip first timestamp as this value is encoded as the qualifier and delta is meaningless - for (int i = 1; i < timestamps.size(); ++i) { + for (int i = 1; i < timestamps.size(); i++) { long timestamp = timestamps.get(i); long timestampDelta = timestamp - prevTimestamp; buffer.putVLong(timestampDelta - prevDelta); @@ -48,7 +48,7 @@ public List decodeTimestamps(long initialTimestamp, Buffer buffer, int num long prevTimestamp = initialTimestamp; long prevDelta = 0; // loop through numValues - 1 as the first timestamp is gotten from the qualifier - for (int i = 0; i < numValues - 1; ++i) { + for (int i = 0; i < numValues - 1; i++) { long timestampDelta = prevDelta + buffer.readVLong(); long timestamp = prevTimestamp + timestampDelta; timestamps.add(timestamp); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/header/BitCountingHeaderEncoder.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/header/BitCountingHeaderEncoder.java index 6c938d22f0eb..2d9c64b1cf6b 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/header/BitCountingHeaderEncoder.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/header/BitCountingHeaderEncoder.java @@ -58,7 +58,7 @@ public byte[] getHeader() { // strictly follows JDK 7's BitSet.toByteArray() int len = (headerBitSet.length() + (NUM_BITS_PER_BYTE - 1)) / NUM_BITS_PER_BYTE; byte[] header = new byte[len]; - for (int i = 0; i < len * NUM_BITS_PER_BYTE; ++i) { + for (int i = 0; i < len * NUM_BITS_PER_BYTE; i++) { int index = i / NUM_BITS_PER_BYTE; int bitMask = (headerBitSet.get(i) ? 1 : 0) << (i % NUM_BITS_PER_BYTE); header[index] |= bitMask; diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/ActiveTraceCodec.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/ActiveTraceCodec.java index 13d3a7271387..bc18bda6b2ab 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/ActiveTraceCodec.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/ActiveTraceCodec.java @@ -137,7 +137,7 @@ public List decodeValues(Buffer valueBuffer, ApplicationStatDecoding List maxTotalCountAgentIdList = this.codec.decodeValues(valueBuffer, maxTotalCountAgentIdEncodingStrategy, numValues); List joinActiveTraceBoList = new ArrayList(); - for (int i = 0 ; i < numValues ; ++i) { + for (int i = 0 ; i < numValues ; i++) { JoinActiveTraceBo joinActiveTraceBo = new JoinActiveTraceBo(); joinActiveTraceBo.setId(id); joinActiveTraceBo.setVersion(versionList.get(i)); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/CpuLoadCodec.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/CpuLoadCodec.java index c7f69beaaad9..523c32b3bcc9 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/CpuLoadCodec.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/CpuLoadCodec.java @@ -171,7 +171,7 @@ public List decodeValues(Buffer valueBuffer, ApplicationStatDecoding List maxSysCpuAgentIds = this.codec.decodeValues(valueBuffer, maxSysCpuAgentIdEncodingStrategy, numValues); List joinCpuLoadBoList = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { JoinCpuLoadBo joinCpuLoadBo = new JoinCpuLoadBo(); joinCpuLoadBo.setId(id); joinCpuLoadBo.setTimestamp(timestamps.get(i)); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/MemoryCodec.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/MemoryCodec.java index b6372447298d..27705634f52a 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/MemoryCodec.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/MemoryCodec.java @@ -170,7 +170,7 @@ public List decodeValues(Buffer valueBuffer, ApplicationStatDecoding List maxNonHeapAGentidList = this.codec.decodeValues(valueBuffer, maxNonHeapAgentIdEncodingStrategy, numValues); List joinCpuLoadBoList = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { JoinMemoryBo joinMemoryBo = new JoinMemoryBo(); joinMemoryBo.setId(id); joinMemoryBo.setTimestamp(timestamps.get(i)); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/ResponseTimeCodec.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/ResponseTimeCodec.java index 992cef812ce2..28657a8591d7 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/ResponseTimeCodec.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/ResponseTimeCodec.java @@ -129,7 +129,7 @@ public List decodeValues(Buffer valueBuffer, ApplicationStatDecoding List maxAvgAgentIdList = this.codec.decodeValues(valueBuffer, maxAvgAgentIdEncodingStrategy, numValues); List joinResponseTimeBoList = new ArrayList(); - for (int i = 0 ; i < numValues ; ++i) { + for (int i = 0 ; i < numValues ; i++) { JoinResponseTimeBo joinResponseTimeBo = new JoinResponseTimeBo(); joinResponseTimeBo.setId(id); joinResponseTimeBo.setTimestamp(timestampList.get(i)); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/TransactionCodec.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/TransactionCodec.java index e83302e8d051..9a37b4c8e180 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/TransactionCodec.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/join/TransactionCodec.java @@ -131,7 +131,7 @@ public List decodeValues(Buffer valueBuffer, ApplicationStatDecoding List maxTotalCountAgentIdList = this.codec.decodeValues(valueBuffer, maxTotalCountAgentIdEncodingStrategy, numValues); List joinTransactionBoList = new ArrayList(); - for (int i = 0 ; i < numValues ; ++i) { + for (int i = 0 ; i < numValues ; i++) { JoinTransactionBo joinTransactionBo = new JoinTransactionBo(); joinTransactionBo.setId(id); joinTransactionBo.setTimestamp(timestampList.get(i)); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/v1/JvmGcCodecV1.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/v1/JvmGcCodecV1.java index fe498c9f8ad4..708f291ac299 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/v1/JvmGcCodecV1.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/v1/JvmGcCodecV1.java @@ -96,7 +96,7 @@ public List decodeValues(Buffer valueBuffer, AgentStatDecodingContext d decoder.decode(valueBuffer, headerDecoder, numValues); List jvmGcBos = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { JvmGcBo jvmGcBo = decoder.getValue(i); jvmGcBo.setAgentId(agentId); jvmGcBo.setTimestamp(timestamps.get(i)); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/v2/DataSourceCodecV2.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/v2/DataSourceCodecV2.java index 8ccb0c3ce5ed..cf49b568a53e 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/v2/DataSourceCodecV2.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/stat/v2/DataSourceCodecV2.java @@ -183,7 +183,7 @@ private DataSourceListBo decodeValue(Buffer valueBuffer, AgentStatDecodingContex List maxConnectionSizes = this.codec.decodeValues(valueBuffer, maxConnectionSizeStrategy, numValues); DataSourceListBo dataSourceListBo = new DataSourceListBo(); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { if (i == 0) { dataSourceListBo.setAgentId(agentId); dataSourceListBo.setTimestamp(timestamps.get(i)); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/DeltaEncodingStrategy.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/DeltaEncodingStrategy.java index f3843fc4e35d..33db48314e46 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/DeltaEncodingStrategy.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/DeltaEncodingStrategy.java @@ -60,7 +60,7 @@ public void encodeValues(Buffer buffer, List values) { this.bufferHandler.putV(buffer, initialValue); T previousValue = initialValue; // skip first value as this value is stored without compression - for (int i = 1; i < values.size(); ++i) { + for (int i = 1; i < values.size(); i++) { T value = values.get(i); this.bufferHandler.putV(buffer, this.operation.xor(value, previousValue)); previousValue = value; @@ -77,7 +77,7 @@ public List decodeValues(Buffer buffer, int numValues) { values.add(initialValue); T previousValue = initialValue; // loop through numValues - 1 as the first value is simply read from buffer - for (int i = 0; i < numValues - 1; ++i) { + for (int i = 0; i < numValues - 1; i++) { T value = this.operation.xor(previousValue, this.bufferHandler.readV(buffer)); values.add(value); previousValue = value; diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/DeltaOfDeltaEncodingStrategy.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/DeltaOfDeltaEncodingStrategy.java index 4f55148cb3a8..7ef8619caaf8 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/DeltaOfDeltaEncodingStrategy.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/DeltaOfDeltaEncodingStrategy.java @@ -61,7 +61,7 @@ public void encodeValues(Buffer buffer, List values) { T previousValue = initialValue; T previousDelta = this.operation.zero(); // skip first value as this value is stored without compression - for (int i = 1; i < values.size(); ++i) { + for (int i = 1; i < values.size(); i++) { T value = values.get(i); T delta = this.operation.diff(value, previousValue); this.bufferHandler.putSV(buffer, this.operation.diff(delta, previousDelta)); @@ -81,7 +81,7 @@ public List decodeValues(Buffer buffer, int numValues) { T previousValue = initialValue; T previousDelta = this.operation.zero(); // loop through numValues - 1 as the first value is simply read from buffer - for (int i = 0; i < numValues - 1; ++i) { + for (int i = 0; i < numValues - 1; i++) { T delta = this.operation.add(previousDelta, this.bufferHandler.readSV(buffer)); T value = this.operation.add(previousValue, delta); values.add(value); diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/RepeatCountEncodingStrategy.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/RepeatCountEncodingStrategy.java index cd8bbe26e5dd..bb84bbdcd950 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/RepeatCountEncodingStrategy.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/RepeatCountEncodingStrategy.java @@ -76,7 +76,7 @@ public List decodeValues(Buffer buffer, int numValues) { while (totalCount < numValues) { int count = buffer.readVInt(); T value = this.bufferHandler.readV(buffer); - for (int i = 0; i < count; ++i) { + for (int i = 0; i < count; i++) { values.add(value); totalCount++; } diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/StringRepeatCountEncodingStrategy.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/StringRepeatCountEncodingStrategy.java index fecc14a490fd..42f580e25d10 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/StringRepeatCountEncodingStrategy.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/StringRepeatCountEncodingStrategy.java @@ -71,7 +71,7 @@ public List decodeValues(Buffer buffer, int numValues) { while (totalCount < numValues) { int count = buffer.readVInt(); String value = this.bufferHandler.read(buffer); - for (int i = 0; i < count; ++i) { + for (int i = 0; i < count; i++) { values.add(value); totalCount++; } diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/StringValueEncodingStrategy.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/StringValueEncodingStrategy.java index bbbe6348dce8..1564ff9efd61 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/StringValueEncodingStrategy.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/StringValueEncodingStrategy.java @@ -51,7 +51,7 @@ public void encodeValues(Buffer buffer, List values) { @Override public List decodeValues(Buffer buffer, int numValues) { List values = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { values.add(this.bufferHandler.read(buffer)); } return values; diff --git a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/ValueEncodingStrategy.java b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/ValueEncodingStrategy.java index 9e656367bd24..af165a3b39da 100644 --- a/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/ValueEncodingStrategy.java +++ b/commons-server/src/main/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/impl/ValueEncodingStrategy.java @@ -57,7 +57,7 @@ public void encodeValues(Buffer buffer, List values) { @Override public List decodeValues(Buffer buffer, int numValues) { List values = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { values.add(this.bufferHandler.readV(buffer)); } return values; diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatCodecTestBase.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatCodecTestBase.java index d1fa2c17e769..f77a7934637b 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatCodecTestBase.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatCodecTestBase.java @@ -44,7 +44,7 @@ public abstract class AgentStatCodecTestBase { @Test public void should_be_encoded_and_decoded_to_same_value() { - for (int i = 0; i < NUM_TEST_RUNS; ++i) { + for (int i = 0; i < NUM_TEST_RUNS; i++) { runTest(); } } @@ -67,7 +67,7 @@ private void runTest() { Buffer valueBuffer = new FixedBuffer(encodedValueBuffer.getBuffer()); List actualAgentStats = getCodec().decodeValues(valueBuffer, decodingContext); Assert.assertEquals(expectedAgentStats.size(), actualAgentStats.size()); - for (int i = 0; i < expectedAgentStats.size(); ++i) { + for (int i = 0; i < expectedAgentStats.size(); i++) { T expectedAgentStat = expectedAgentStats.get(i); T actualAgentStat = actualAgentStats.get(i); verify(expectedAgentStat, actualAgentStat); diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatDataPointCodecTest.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatDataPointCodecTest.java index b850b6ca10c5..53c5c34ce219 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatDataPointCodecTest.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatDataPointCodecTest.java @@ -66,7 +66,7 @@ private List createTimestamps(long initialTimestampMs, long intervalMs, lo List timestamps = new ArrayList(numValues); timestamps.add(initialTimestampMs); long prevTimestamp = initialTimestampMs; - for (int i = 1; i < numValues; ++i) { + for (int i = 1; i < numValues; i++) { long delta = ((long) (Math.random() * (randomDelta * 2))) - randomDelta; long timestamp = prevTimestamp + (intervalMs + delta); timestamps.add(timestamp); diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatEncoderTest.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatEncoderTest.java index da3ee2643598..0b4dd299bb24 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatEncoderTest.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/AgentStatEncoderTest.java @@ -70,7 +70,7 @@ public void stats_should_be_encoded_and_decoded_into_same_value() { private List createTestAgentStats(long initialTimestamp, int numStats) { List agentStats = new ArrayList(numStats); - for (int i = 0; i < numStats; ++i) { + for (int i = 0; i < numStats; i++) { long timestamp = initialTimestamp + (COLLECT_INTERVAL * i); TestAgentStat agentStat = new TestAgentStat(); agentStat.setAgentId(AGENT_ID); @@ -113,7 +113,7 @@ public void encodeValues(Buffer valueBuffer, List agentStats) { public List decodeValues(Buffer valueBuffer, AgentStatDecodingContext decodingContext) { int size = valueBuffer.readInt(); List agentStats = new ArrayList(size); - for (int i = 0; i < size; ++i) { + for (int i = 0; i < size; i++) { TestAgentStat agentStat = new TestAgentStat(); agentStat.setAgentId(decodingContext.getAgentId()); agentStat.setStartTimestamp(valueBuffer.readLong()); diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/TestAgentStatDataPointFactory.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/TestAgentStatDataPointFactory.java index 68492d20f5eb..864ee1c21f65 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/TestAgentStatDataPointFactory.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/TestAgentStatDataPointFactory.java @@ -169,7 +169,7 @@ public List createConstantValues(T minValue, T maxValue) { public List createConstantValues(T minValue, T maxValue, int numValues) { T value = this.createValue(minValue, maxValue); List values = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { values.add(value); } return values; @@ -184,7 +184,7 @@ public List createRandomValues(T minValue, T maxValue) { @Override public List createRandomValues(T minValue, T maxValue, int numValues) { List values = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { T value = this.createValue(minValue, maxValue); values.add(value); } @@ -202,7 +202,7 @@ public List createIncreasingValues(T minValue, T maxValue, T minIncrement, T List values = new ArrayList(numValues); T value = this.createValue(minValue, maxValue); values.add(value); - for (int i = 0; i < numValues - 1; ++i) { + for (int i = 0; i < numValues - 1; i++) { T increment = this.createValue(minIncrement, maxIncrement); value = add(value, increment); values.add(value); @@ -221,7 +221,7 @@ public List createDecreasingValues(T minValue, T maxValue, T minDecrement, T List values = new ArrayList(numValues); T value = this.createValue(minValue, maxValue); values.add(value); - for (int i = 0; i < numValues - 1; ++i) { + for (int i = 0; i < numValues - 1; i++) { T decrement = this.createValue(minDecrement, maxDecrement); value = diff(value, decrement); values.add(value); @@ -241,7 +241,7 @@ public List createFluctuatingValues(T minValue, T maxValue, T minFluctuation, T value = this.createValue(minValue, maxValue); values.add(value); boolean sign = RANDOM.nextBoolean(); - for (int i = 0; i < numValues - 1; ++i) { + for (int i = 0; i < numValues - 1; i++) { T fluctuation = this.createValue(minFluctuation, maxFluctuation); // randomly add or substract fluctuation if (sign) { diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/TestAgentStatFactory.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/TestAgentStatFactory.java index 8bf6803ef541..da2317b2a4b3 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/TestAgentStatFactory.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/TestAgentStatFactory.java @@ -89,7 +89,7 @@ public static List createJvmGcBos(String agentId, long startTimestamp, 100L, 5000L, numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { JvmGcBo jvmGcBo = new JvmGcBo(); jvmGcBo.setAgentId(agentId); jvmGcBo.setStartTimestamp(startTimestamps.get(i)); @@ -133,7 +133,7 @@ public static List createJvmGcDetailedBos(String agentId, long List survivorSpaceUseds = createRandomPercentageValues(numValues); List permGenUseds = createRandomPercentageValues(numValues); List metaspaceUseds = createRandomPercentageValues(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { JvmGcDetailedBo jvmGcDetailedBo = new JvmGcDetailedBo(); jvmGcDetailedBo.setAgentId(agentId); jvmGcDetailedBo.setStartTimestamp(startTimestamps.get(i)); @@ -162,7 +162,7 @@ public static List createCpuLoadBos(String agentId, long startTimesta List timestamps = createTimestamps(initialTimestamp, numValues); List jvmCpuLoads = createRandomPercentageValues(numValues); List systemCpuLoads = createRandomPercentageValues(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { CpuLoadBo cpuLoadBo = new CpuLoadBo(); cpuLoadBo.setStartTimestamp(startTimestamps.get(i)); cpuLoadBo.setAgentId(agentId); @@ -213,7 +213,7 @@ public static List createTransactionBos(String agentId, long star 10L, 100L, numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { TransactionBo transactionBo = new TransactionBo(); transactionBo.setAgentId(agentId); transactionBo.setStartTimestamp(startTimestamps.get(i)); @@ -242,7 +242,7 @@ public static List createActiveTraceBos(String agentId, long star List slowTraceCounts = TestAgentStatDataPointFactory.INTEGER.createRandomValues(0, 1000, numValues); List verySlowTraceCounts = TestAgentStatDataPointFactory.INTEGER.createRandomValues(0, 1000, numValues); int histogramSchemaType = 1; - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { ActiveTraceBo activeTraceBo = new ActiveTraceBo(); activeTraceBo.setAgentId(agentId); activeTraceBo.setStartTimestamp(startTimestamps.get(i)); @@ -273,7 +273,7 @@ public static List createResponseTimeBos(String agentId, long st List startTimestamps = createStartTimestamps(startTimestamp, numValues); List timestamps = createTimestamps(initialTimestamp, numValues); List avgs = TestAgentStatDataPointFactory.LONG.createRandomValues(0L, 1000L, numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { ResponseTimeBo responseTimeBo = new ResponseTimeBo(); responseTimeBo.setAgentId(agentId); responseTimeBo.setStartTimestamp(startTimestamps.get(i)); @@ -294,7 +294,7 @@ public static List createDeadlockBos(String agentId, long startTimes List startTimestamps = createStartTimestamps(startTimestamp, numValues); List timestamps = createTimestamps(initialTimestamp, numValues); List deadlockCounts = TestAgentStatDataPointFactory.INTEGER.createRandomValues(0, 1000, numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { DeadlockBo deadlockBo = new DeadlockBo(); deadlockBo.setAgentId(agentId); deadlockBo.setStartTimestamp(startTimestamps.get(i)); @@ -316,7 +316,7 @@ public static List createDataSourceListBos(String agentId, lon public static List createDataSourceListBos(String agentId, long startTimestamp, long initialTimestamp, int numValues) { List dataSourceListBos = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { int maxConnectionSize = RandomUtils.nextInt(MIN_VALUE_OF_MAX_CONNECTION_SIZE, MIN_VALUE_OF_MAX_CONNECTION_SIZE * 2); int dataSourceBoSize = RandomUtils.nextInt(1, MAX_NUM_TEST_VALUES); DataSourceListBo dataSourceListBo = createDataSourceListBo(agentId, startTimestamp, initialTimestamp, i + 1, maxConnectionSize, dataSourceBoSize); @@ -366,7 +366,7 @@ private static List createTimestamps(long initialTimestamp, int numValues) private static List createRandomPercentageValues(int numValues) { List values = new ArrayList(numValues); - for (int i = 0; i < numValues; ++i) { + for (int i = 0; i < numValues; i++) { int randomInt = RANDOM.nextInt(101); double value = randomInt; if (randomInt != 100) { diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/header/BitCountingHeaderEncoderTest.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/header/BitCountingHeaderEncoderTest.java index 2e8e920ee328..e3922373c3ec 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/header/BitCountingHeaderEncoderTest.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/header/BitCountingHeaderEncoderTest.java @@ -38,19 +38,19 @@ public void test_with_random_codes() { // Given final int numCodes = RandomUtils.nextInt(1, MAX_NUM_TEST_VALUES); final List givenCodes = new ArrayList(numCodes); - for (int i = 0; i < numCodes; ++i) { + for (int i = 0; i < numCodes; i++) { givenCodes.add(RANDOM.nextInt(5)); } // When BitCountingHeaderEncoder encoder = new BitCountingHeaderEncoder(); - for (int i = 0; i < givenCodes.size(); ++i) { + for (int i = 0; i < givenCodes.size(); i++) { encoder.addCode(givenCodes.get(i)); } final byte[] header = encoder.getHeader(); // Then List decodedCodes = new ArrayList(numCodes); BitCountingHeaderDecoder decoder = new BitCountingHeaderDecoder(header); - for (int i = 0; i < numCodes; ++i) { + for (int i = 0; i < numCodes; i++) { int code = decoder.getCode(); decodedCodes.add(code); } @@ -63,13 +63,13 @@ public void test_zeroes() { final int numCodes = RandomUtils.nextInt(1, MAX_NUM_TEST_VALUES); // When BitCountingHeaderEncoder encoder = new BitCountingHeaderEncoder(); - for (int i = 0; i < numCodes; ++i) { + for (int i = 0; i < numCodes; i++) { encoder.addCode(0); } final byte[] header = encoder.getHeader(); // Then BitCountingHeaderDecoder decoder = new BitCountingHeaderDecoder(header); - for (int i = 0; i < numCodes; ++i) { + for (int i = 0; i < numCodes; i++) { Assert.assertEquals(0, decoder.getCode()); } } @@ -81,10 +81,10 @@ public void test_zeroes_followed_by_random_codes() { final int numRandomCodes = RandomUtils.nextInt(1, MAX_NUM_TEST_VALUES); final int numTotalCodes = numZeroes + numRandomCodes; List givenCodes = new ArrayList(numTotalCodes); - for (int i = 0; i < numZeroes; ++i) { + for (int i = 0; i < numZeroes; i++) { givenCodes.add(0); } - for (int i = 0; i < numRandomCodes; ++i) { + for (int i = 0; i < numRandomCodes; i++) { givenCodes.add(RANDOM.nextInt(5)); } // When @@ -96,7 +96,7 @@ public void test_zeroes_followed_by_random_codes() { // Then BitCountingHeaderDecoder decoder = new BitCountingHeaderDecoder(header); List decodedCodes = new ArrayList(numTotalCodes); - for (int i = 0; i < numTotalCodes; ++i) { + for (int i = 0; i < numTotalCodes; i++) { decodedCodes.add(decoder.getCode()); } Assert.assertEquals(givenCodes, decodedCodes); @@ -116,7 +116,7 @@ public void regression_against_jdk7() { for (int numRun = 0; numRun < numRuns; ++numRun) { final int numCodes = RandomUtils.nextInt(1, MAX_NUM_TEST_VALUES); final List givenCodes = new ArrayList(); - for (int i = 0; i < numCodes; ++i) { + for (int i = 0; i < numCodes; i++) { givenCodes.add(RANDOM.nextInt(5)); } BitCountingHeaderEncoder encoder = new BitCountingHeaderEncoder(); @@ -133,7 +133,7 @@ public void regression_against_jdk7() { Jdk7BitCountingHeaderDecoder jdk7Decoder = new Jdk7BitCountingHeaderDecoder(encodedHeader); List decodedCodes = new ArrayList(); List jdk7DecodedCodes = new ArrayList(); - for (int i = 0; i < numCodes; ++i) { + for (int i = 0; i < numCodes; i++) { decodedCodes.add(decoder.getCode()); jdk7DecodedCodes.add(jdk7Decoder.getCode()); } diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedIntegerEncodingStrategyTest.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedIntegerEncodingStrategyTest.java index dc52669406d7..70ae45a305ee 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedIntegerEncodingStrategyTest.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedIntegerEncodingStrategyTest.java @@ -74,7 +74,7 @@ public void test_large_values() { } private void testValues(int minValue, int maxValue) { - for (int i = 0; i < NUM_TEST_RUNS; ++i) { + for (int i = 0; i < NUM_TEST_RUNS; i++) { List constantValues = TestAgentStatDataPointFactory.INTEGER.createConstantValues(minValue, maxValue); testFor(constantValues); List randomValues = TestAgentStatDataPointFactory.INTEGER.createRandomValues(minValue, maxValue); diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedLongEncodingStrategyTest.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedLongEncodingStrategyTest.java index e95b3361cd0b..fb5f782da9cc 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedLongEncodingStrategyTest.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedLongEncodingStrategyTest.java @@ -81,7 +81,7 @@ public void test_huge_values() { } private void testValues(long minValue, long maxValue) { - for (int i = 0; i < NUM_TEST_RUNS; ++i) { + for (int i = 0; i < NUM_TEST_RUNS; i++) { List constantValues = TestAgentStatDataPointFactory.LONG.createConstantValues(minValue, maxValue); testFor(constantValues); List randomValues = TestAgentStatDataPointFactory.LONG.createRandomValues(minValue, maxValue); diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedShortEncodingStrategyTest.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedShortEncodingStrategyTest.java index 6b4ac5638760..78946c89f08e 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedShortEncodingStrategyTest.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/stat/strategy/UnsignedShortEncodingStrategyTest.java @@ -71,7 +71,7 @@ public void test_large_values() { } private void testValues(short minValue, short maxValue) { - for (int i = 0; i < NUM_TEST_RUNS; ++i) { + for (int i = 0; i < NUM_TEST_RUNS; i++) { List constantValues = TestAgentStatDataPointFactory.SHORT.createConstantValues(minValue, maxValue); testFor(constantValues); List randomValues = TestAgentStatDataPointFactory.SHORT.createRandomValues(minValue, maxValue); diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/EncodingStrategyTestBase.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/EncodingStrategyTestBase.java index 8ca81caed028..a7931a13179a 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/EncodingStrategyTestBase.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/codec/strategy/EncodingStrategyTestBase.java @@ -44,7 +44,7 @@ public void testStrategy(List expectedValues, EncodingStrategy strateg public List createRandomShorts(int numTestValues, boolean unsigned) { List values = new ArrayList(numTestValues); - for (int i = 0; i < numTestValues; ++i) { + for (int i = 0; i < numTestValues; i++) { if (unsigned) { values.add((short) RANDOM.nextInt(Short.MAX_VALUE)); } else { @@ -57,7 +57,7 @@ public List createRandomShorts(int numTestValues, boolean unsigned) { public List createRandomIntegers(int numTestValues, boolean unsigned) { List values = new ArrayList(numTestValues); - for (int i = 0; i < numTestValues; ++i) { + for (int i = 0; i < numTestValues; i++) { if (unsigned) { values.add(RANDOM.nextInt(Integer.MAX_VALUE)); } else { @@ -69,7 +69,7 @@ public List createRandomIntegers(int numTestValues, boolean unsigned) { public List createRandomLongs(int numTestValues, boolean unsigned) { List values = new ArrayList(numTestValues); - for (int i = 0; i < numTestValues; ++i) { + for (int i = 0; i < numTestValues; i++) { long value = RANDOM.nextLong(); if (unsigned) { value = Math.abs(value); diff --git a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/serializer/stat/AgentStatHbaseOperationFactoryTest.java b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/serializer/stat/AgentStatHbaseOperationFactoryTest.java index b165e574fef2..02710e997e6d 100644 --- a/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/serializer/stat/AgentStatHbaseOperationFactoryTest.java +++ b/commons-server/src/test/java/com/navercorp/pinpoint/common/server/bo/serializer/stat/AgentStatHbaseOperationFactoryTest.java @@ -141,7 +141,7 @@ public void create_should_create_the_same_number_of_puts_as_dataPoints_if_collec List puts = this.agentStatHbaseOperationFactory.createPuts(TEST_AGENT_ID, TEST_AGENT_STAT_TYPE, testDataPoints, this.mockSerializer); // Then assertEquals(numDataPoints, puts.size()); - for (int i = 0; i < puts.size(); ++i) { + for (int i = 0; i < puts.size(); i++) { Put put = puts.get(i); assertEquals(TEST_AGENT_ID, this.agentStatHbaseOperationFactory.getAgentId(put.getRow())); assertEquals(TEST_AGENT_STAT_TYPE, this.agentStatHbaseOperationFactory.getAgentStatType(put.getRow())); @@ -177,7 +177,7 @@ public void test_using_current_timestamp() { private List createTestDataPoints(long initialTimestamp, long interval, int count) { List dataPoints = new ArrayList(count); long timestamp = initialTimestamp; - for (int i = 0; i < count; ++i) { + for (int i = 0; i < count; i++) { AgentStatDataPoint dataPoint = createTestDataPoint(timestamp); dataPoints.add(dataPoint); timestamp += interval; diff --git a/plugins/hystrix/src/main/java/com/navercorp/pinpoint/plugin/hystrix/HystrixPlugin.java b/plugins/hystrix/src/main/java/com/navercorp/pinpoint/plugin/hystrix/HystrixPlugin.java index 52b1156e9172..1ee6f6f6f081 100644 --- a/plugins/hystrix/src/main/java/com/navercorp/pinpoint/plugin/hystrix/HystrixPlugin.java +++ b/plugins/hystrix/src/main/java/com/navercorp/pinpoint/plugin/hystrix/HystrixPlugin.java @@ -70,7 +70,7 @@ private void addTransformers(int numHystrixCommandAnonymousLocalClass) { // We start with 3 only because the most recent version requires this many. May be better to make this // configurable but for now let's just hard-code it. final int numAnonymousInnerClassesToTest = numHystrixCommandAnonymousLocalClass; - for (int i = 0; i < numAnonymousInnerClassesToTest; ++i) { + for (int i = 0; i < numAnonymousInnerClassesToTest; i++) { String anonymousInnerClassName = "com.netflix.hystrix.HystrixCommand$" + (i + 1); logger.debug("Registering transformer for {}", anonymousInnerClassName); diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/instrument/ASMTryCatch.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/instrument/ASMTryCatch.java index 48d3515b0cb6..78474cc8d601 100644 --- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/instrument/ASMTryCatch.java +++ b/profiler/src/main/java/com/navercorp/pinpoint/profiler/instrument/ASMTryCatch.java @@ -68,7 +68,7 @@ private int blockLength(TryCatchBlockNode block) { }); // Updates the 'target' of each try catch block annotation. - for (int i = 0; i < this.methodNode.tryCatchBlocks.size(); ++i) { + for (int i = 0; i < this.methodNode.tryCatchBlocks.size(); i++) { this.methodNode.tryCatchBlocks.get(i).updateIndex(i); } } diff --git a/profiler/src/test/java/com/navercorp/pinpoint/profiler/AgentInfoSenderTest.java b/profiler/src/test/java/com/navercorp/pinpoint/profiler/AgentInfoSenderTest.java index 391ea56b95a9..f392df51abdf 100644 --- a/profiler/src/test/java/com/navercorp/pinpoint/profiler/AgentInfoSenderTest.java +++ b/profiler/src/test/java/com/navercorp/pinpoint/profiler/AgentInfoSenderTest.java @@ -271,7 +271,7 @@ public void reconnectPerformed(PinpointClient client) { waitExpectedRequestCount(requestCount, 1); serverAcceptor.close(); // reconnect - for (int i = 0; i < expectedReconnectCount; ++i) { + for (int i = 0; i < expectedReconnectCount; i++) { PinpointServerAcceptor reconnectServerAcceptor = createServerAcceptor(serverListener); // wait for agent to reconnect reconnectEventBarrier.await(); @@ -346,7 +346,7 @@ public void onServerMetaDataChange() { // When try { - for (int i = 0; i < expectedRequestCount; ++i) { + for (int i = 0; i < expectedRequestCount; i++) { serverMetaDataRegistryService.notifyListeners(); } @@ -389,7 +389,7 @@ public void onServerMetaDataChange() { }); // When - for (int i = 0; i < threadCount; ++i) { + for (int i = 0; i < threadCount; i++) { final String serviceName = "/name" + i; executorService.submit(new Runnable() { @Override diff --git a/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/DefaultServerMetaDataRegistryServiceTest.java b/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/DefaultServerMetaDataRegistryServiceTest.java index 2d1e9d6f618c..244c2738d81b 100644 --- a/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/DefaultServerMetaDataRegistryServiceTest.java +++ b/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/DefaultServerMetaDataRegistryServiceTest.java @@ -68,7 +68,7 @@ public void testRaceConditionWhenAddingConnectors() throws InterruptedException final ServerMetaDataRegistryService serverMetaDataRegistryService = new DefaultServerMetaDataRegistryService(VM_ARGS); serverMetaDataRegistryService.setServerName(SERVER_INFO); // When - for (int i = 0; i < THREAD_COUNT; ++i) { + for (int i = 0; i < THREAD_COUNT; i++) { final int port = i; final String protocol = protocolPrefix + i; executorService.submit(new Runnable() { @@ -116,7 +116,7 @@ public void testRaceConditionWhenAddingServiceInfo() throws InterruptedException final ServerMetaDataRegistryService serverMetaDataRegistryService = new DefaultServerMetaDataRegistryService(VM_ARGS); serverMetaDataRegistryService.setServerName(SERVER_INFO); // When - for (int i = 0; i < THREAD_COUNT; ++i) { + for (int i = 0; i < THREAD_COUNT; i++) { final List serviceLibs = new ArrayList(); executorService.submit(new Runnable() { @Override diff --git a/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/DefaultTraceContextTest.java b/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/DefaultTraceContextTest.java index b2727d782bd9..fec65865c3db 100644 --- a/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/DefaultTraceContextTest.java +++ b/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/DefaultTraceContextTest.java @@ -101,19 +101,19 @@ public void transactionCountTest() { @SuppressWarnings("unused") final long expectedSampledNewCount = newTransactionCount / samplingRate + (newTransactionCount % samplingRate > 0 ? 1 : 0); final long expectedUnsampledNewCount = newTransactionCount - expectedSampledNewCount; - for (int i = 0; i < newTransactionCount; ++i) { + for (int i = 0; i < newTransactionCount; i++) { traceContext.newTraceObject(); traceContext.removeTraceObject(); } final long expectedSampledContinuationCount = 5L; - for (int i = 0; i < expectedSampledContinuationCount; ++i) { + for (int i = 0; i < expectedSampledContinuationCount; i++) { traceContext.continueTraceObject(new DefaultTraceId("agentId", 0L, i)); traceContext.removeTraceObject(); } final long expectedUnsampledContinuationCount = 10L; - for (int i = 0; i < expectedUnsampledContinuationCount; ++i) { + for (int i = 0; i < expectedUnsampledContinuationCount; i++) { traceContext.disableSampling(); traceContext.removeTraceObject(); } diff --git a/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/active/ActiveTraceRepositoryTest.java b/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/active/ActiveTraceRepositoryTest.java index 6bd7a02cdceb..479c058470a5 100644 --- a/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/active/ActiveTraceRepositoryTest.java +++ b/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/active/ActiveTraceRepositoryTest.java @@ -115,13 +115,13 @@ private ListenableFuture> executeTransactions(CountDownLa final int totalTransactionCount = newTransactionCount + sampledContinuationCount + unsampledContinuationCount; final ListeningExecutorService executor = MoreExecutors.listeningDecorator(Executors.newFixedThreadPool(totalTransactionCount)); final List> futures = new ArrayList>(); - for (int i = 0; i < newTransactionCount; ++i) { + for (int i = 0; i < newTransactionCount; i++) { futures.add(executeNewTrace(executor, awaitLatch, executeLatch)); } - for (int i = 0; i < sampledContinuationCount; ++i) { + for (int i = 0; i < sampledContinuationCount; i++) { futures.add(executeSampledContinuedTrace(executor, awaitLatch, executeLatch, i)); } - for (int i = 0; i < unsampledContinuationCount; ++i) { + for (int i = 0; i < unsampledContinuationCount; i++) { futures.add(executeUnsampledContinuedTrace(executor, awaitLatch, executeLatch)); } return Futures.allAsList(futures); diff --git a/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/id/DefaultTransactionCounterTest.java b/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/id/DefaultTransactionCounterTest.java index 344d2323aa53..458300f6c994 100644 --- a/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/id/DefaultTransactionCounterTest.java +++ b/profiler/src/test/java/com/navercorp/pinpoint/profiler/context/id/DefaultTransactionCounterTest.java @@ -18,9 +18,6 @@ import static org.junit.Assert.*; -import com.navercorp.pinpoint.profiler.context.id.AtomicIdGenerator; -import com.navercorp.pinpoint.profiler.context.id.DefaultTransactionCounter; -import com.navercorp.pinpoint.profiler.context.id.TransactionCounter; import org.junit.Before; import org.junit.Test; @@ -127,7 +124,7 @@ public void testMultipleTransaction_SAMPLED_NEW() { // Given final long expectedTransactionCount = 99L; // When - for (int i = 0; i < expectedTransactionCount; ++i) { + for (int i = 0; i < expectedTransactionCount; i++) { this.idGenerator.nextTransactionId(); } final long actualCount = this.transactionCounter.getSampledNewCount(); @@ -140,7 +137,7 @@ public void testMultipleTransaction_SAMPLED_CONTINUATION() { // Given final long expectedTransactionCount = 99L; // When - for (int i = 0; i < expectedTransactionCount; ++i) { + for (int i = 0; i < expectedTransactionCount; i++) { this.idGenerator.nextContinuedTransactionId(); } final long actualCount = this.transactionCounter.getSampledContinuationCount(); @@ -153,7 +150,7 @@ public void testMultipleTransaction_UNSAMPLED_NEW() { // Given final long expectedTransactionCount = 99L; // When - for (int i = 0; i < expectedTransactionCount; ++i) { + for (int i = 0; i < expectedTransactionCount; i++) { this.idGenerator.nextDisabledId(); } final long actualCount = this.transactionCounter.getUnSampledNewCount(); @@ -166,7 +163,7 @@ public void testMultipleTransaction_UNSAMPLED_CONTINUATION() { // Given final long expectedTransactionCount = 99L; // When - for (int i = 0; i < expectedTransactionCount; ++i) { + for (int i = 0; i < expectedTransactionCount; i++) { this.idGenerator.nextContinuedDisabledId(); } final long actualCount = this.transactionCounter.getUnSampledContinuationCount(); @@ -183,16 +180,16 @@ public void testTotalTransaction() { final long expectedUnsampledContinuationCount = 9L; final long expectedTotalCount = expectedSampledNewCount + expectedSampledContinuationCount + expectedUnsampledNewCount + expectedUnsampledContinuationCount; // When - for (int i = 0; i < expectedSampledNewCount; ++i) { + for (int i = 0; i < expectedSampledNewCount; i++) { this.idGenerator.nextTransactionId(); } - for (int i = 0; i < expectedSampledContinuationCount; ++i) { + for (int i = 0; i < expectedSampledContinuationCount; i++) { this.idGenerator.nextContinuedTransactionId(); } - for (int i = 0; i < expectedUnsampledNewCount; ++i) { + for (int i = 0; i < expectedUnsampledNewCount; i++) { this.idGenerator.nextDisabledId(); } - for (int i = 0; i < expectedUnsampledContinuationCount; ++i) { + for (int i = 0; i < expectedUnsampledContinuationCount; i++) { this.idGenerator.nextContinuedDisabledId(); } final long actualSampledNewCount = this.transactionCounter.getSampledNewCount(); diff --git a/profiler/src/test/java/com/navercorp/pinpoint/profiler/monitor/metric/transaction/DefaultTransactionMetricTest.java b/profiler/src/test/java/com/navercorp/pinpoint/profiler/monitor/metric/transaction/DefaultTransactionMetricTest.java index 79bae03399bd..970aa79e14b0 100644 --- a/profiler/src/test/java/com/navercorp/pinpoint/profiler/monitor/metric/transaction/DefaultTransactionMetricTest.java +++ b/profiler/src/test/java/com/navercorp/pinpoint/profiler/monitor/metric/transaction/DefaultTransactionMetricTest.java @@ -132,7 +132,7 @@ public void checkContinuousTransactions() throws Exception { final long expectedNumberOfTransactionsPerCollection = 100L; initTransactionMetric(); // When - for (int i = 0; i < testCnt; ++i) { + for (int i = 0; i < testCnt; i++) { this.transactionCounter.addSampledNewCount(expectedNumberOfTransactionsPerCollection); this.transactionCounter.addSampledContinuationCount(expectedNumberOfTransactionsPerCollection); this.transactionCounter.addUnSampledNewCount(expectedNumberOfTransactionsPerCollection); diff --git a/web/src/main/java/com/navercorp/pinpoint/web/controller/MapController.java b/web/src/main/java/com/navercorp/pinpoint/web/controller/MapController.java index 17f37d57d204..dfdb332f2527 100644 --- a/web/src/main/java/com/navercorp/pinpoint/web/controller/MapController.java +++ b/web/src/main/java/com/navercorp/pinpoint/web/controller/MapController.java @@ -298,12 +298,12 @@ public NodeHistogramSummary getResponseTimeHistogramDataV2( Application application = applicationFactory.createApplication(applicationName, serviceTypeCode); List fromApplications = new ArrayList<>(fromApplicationNames.size()); - for (int i = 0; i < fromApplicationNames.size(); ++i) { + for (int i = 0; i < fromApplicationNames.size(); i++) { Application fromApplication = applicationFactory.createApplication(fromApplicationNames.get(i), fromServiceTypeCodes.get(i)); fromApplications.add(fromApplication); } List toApplications = new ArrayList<>(toApplicationNames.size()); - for (int i = 0; i < toApplicationNames.size(); ++i) { + for (int i = 0; i < toApplicationNames.size(); i++) { Application toApplication = applicationFactory.createApplication(toApplicationNames.get(i), toServiceTypeCodes.get(i)); toApplications.add(toApplication); } diff --git a/web/src/test/java/com/navercorp/pinpoint/web/alarm/checker/DataSourceConnectionUsageRateCheckerTest.java b/web/src/test/java/com/navercorp/pinpoint/web/alarm/checker/DataSourceConnectionUsageRateCheckerTest.java index 05e834f77185..43d8eddc830c 100644 --- a/web/src/test/java/com/navercorp/pinpoint/web/alarm/checker/DataSourceConnectionUsageRateCheckerTest.java +++ b/web/src/test/java/com/navercorp/pinpoint/web/alarm/checker/DataSourceConnectionUsageRateCheckerTest.java @@ -152,7 +152,7 @@ private List createIncreasingValues(Long minValue, Long maxValue, Long min List values = new ArrayList(numValues); long value = RandomUtils.nextLong(minValue, maxValue); values.add(value); - for (int i = 0; i < numValues - 1; ++i) { + for (int i = 0; i < numValues - 1; i++) { long increment = RandomUtils.nextLong(minIncrement, maxIncrement); value = value + increment; values.add(value); diff --git a/web/src/test/java/com/navercorp/pinpoint/web/applicationmap/ApplicationMapBuilderTestHelper.java b/web/src/test/java/com/navercorp/pinpoint/web/applicationmap/ApplicationMapBuilderTestHelper.java index c1778bc69009..4580eccbebaf 100644 --- a/web/src/test/java/com/navercorp/pinpoint/web/applicationmap/ApplicationMapBuilderTestHelper.java +++ b/web/src/test/java/com/navercorp/pinpoint/web/applicationmap/ApplicationMapBuilderTestHelper.java @@ -79,7 +79,7 @@ public static LinkDataDuplexMap createLinkDataDuplexMap(int calleeDepth, int cal throw new IllegalArgumentException("callerDepth must be greater than 0"); } LinkDataDuplexMap linkDataDuplexMap = new LinkDataDuplexMap(); - for (int i = 0; i < calleeDepth - 1; ++i) { + for (int i = 0; i < calleeDepth - 1; i++) { LinkData targetLinkData = createTargetLinkData(i); linkDataDuplexMap.addTargetLinkData(targetLinkData); } @@ -87,7 +87,7 @@ public static LinkDataDuplexMap createLinkDataDuplexMap(int calleeDepth, int cal linkDataDuplexMap.addSourceLinkData(createTerminalSourceLinkData(0)); - for (int i = 0; i < callerDepth - 1; ++i) { + for (int i = 0; i < callerDepth - 1; i++) { LinkData sourceLinkData = createSourceLinkData(i); linkDataDuplexMap.addSourceLinkData(sourceLinkData); } diff --git a/web/src/test/java/com/navercorp/pinpoint/web/mapper/stat/AgentStatMapperV2Test.java b/web/src/test/java/com/navercorp/pinpoint/web/mapper/stat/AgentStatMapperV2Test.java index 1ba2b8f06ef4..0d554460d55f 100644 --- a/web/src/test/java/com/navercorp/pinpoint/web/mapper/stat/AgentStatMapperV2Test.java +++ b/web/src/test/java/com/navercorp/pinpoint/web/mapper/stat/AgentStatMapperV2Test.java @@ -88,7 +88,7 @@ public void mapperTest() throws Exception { List puts = new ArrayList<>(); long initialTimestamp = System.currentTimeMillis(); int numBatch = RandomUtils.nextInt(1, MAX_NUM_TEST_VALUES); - for (int i = 0; i < numBatch; ++i) { + for (int i = 0; i < numBatch; i++) { int batchSize = RandomUtils.nextInt(1, MAX_NUM_TEST_VALUES); List agentStatBatch = createAgentStats(initialTimestamp, COLLECT_INVERVAL, batchSize); givenAgentStats.addAll(agentStatBatch); @@ -113,7 +113,7 @@ public void mapperTest() throws Exception { private List createAgentStats(long initialTimestamp, long interval, int batchSize) { List agentStats = new ArrayList<>(batchSize); - for (int i = 0; i < batchSize; ++i) { + for (int i = 0; i < batchSize; i++) { long timestamp = initialTimestamp + (interval * i); TestAgentStat agentStat = new TestAgentStat(); agentStat.setAgentId(AGENT_ID); @@ -144,7 +144,7 @@ public void encodeValues(Buffer valueBuffer, List agentStats) { public List decodeValues(Buffer valueBuffer, AgentStatDecodingContext decodingContext) { int size = valueBuffer.readInt(); List agentStats = new ArrayList<>(size); - for (int i = 0; i < size; ++i) { + for (int i = 0; i < size; i++) { TestAgentStat agentStat = new TestAgentStat(); agentStat.setAgentId(decodingContext.getAgentId()); agentStat.setTimestamp(valueBuffer.readLong()); diff --git a/web/src/test/java/com/navercorp/pinpoint/web/mapper/stat/SampledAgentStatResultExtractorTest.java b/web/src/test/java/com/navercorp/pinpoint/web/mapper/stat/SampledAgentStatResultExtractorTest.java index 084282ff92d7..68f71317099b 100644 --- a/web/src/test/java/com/navercorp/pinpoint/web/mapper/stat/SampledAgentStatResultExtractorTest.java +++ b/web/src/test/java/com/navercorp/pinpoint/web/mapper/stat/SampledAgentStatResultExtractorTest.java @@ -167,7 +167,7 @@ private Map> getExpectedDataPointSlotMap(Time private List createDataPoints(long finalTimestamp, long timeInterval, int numDataPoints) { List dataPoints = new ArrayList<>(numDataPoints); - for (int i = 0; i < numDataPoints; ++i) { + for (int i = 0; i < numDataPoints; i++) { TestAgentStatDataPoint dataPoint = new TestAgentStatDataPoint(); dataPoint.setTimestamp(finalTimestamp - (timeInterval * i)); dataPoint.setValue(i); diff --git a/web/src/test/java/com/navercorp/pinpoint/web/service/map/LinkSelectorTestBase.java b/web/src/test/java/com/navercorp/pinpoint/web/service/map/LinkSelectorTestBase.java index 90c14f811d0a..a651522dd5c8 100644 --- a/web/src/test/java/com/navercorp/pinpoint/web/service/map/LinkSelectorTestBase.java +++ b/web/src/test/java/com/navercorp/pinpoint/web/service/map/LinkSelectorTestBase.java @@ -126,7 +126,7 @@ public void testCaller_multiple() throws Exception { int numTargets = RANDOM.nextInt(100); int callCount_A_APP = 4; LinkDataMap linkDataMap = new LinkDataMap(); - for (int i = 0; i < numTargets; ++i) { + for (int i = 0; i < numTargets; i++) { String targetAppName = "TARGET_" + (i + 1); String targetAppAgentId = "target" + (i + 1); Application targetApp = new Application(targetAppName, ServiceType.TEST_STAND_ALONE); diff --git a/web/src/test/java/com/navercorp/pinpoint/web/service/map/LinkVisitCheckerTest.java b/web/src/test/java/com/navercorp/pinpoint/web/service/map/LinkVisitCheckerTest.java index ca0451cae44b..961bd0adb1c7 100644 --- a/web/src/test/java/com/navercorp/pinpoint/web/service/map/LinkVisitCheckerTest.java +++ b/web/src/test/java/com/navercorp/pinpoint/web/service/map/LinkVisitCheckerTest.java @@ -75,7 +75,7 @@ public void testVisitCallerParallel() throws Exception { VisitJobContext jobContext = new VisitJobContext(linkVisitor, visitedLatch, submitLatch, firstVisitCount, alreadyVisitedCount); final Application testApplication = new Application("test1", ServiceType.STAND_ALONE); - for (int i = 0; i < concurrency; ++i) { + for (int i = 0; i < concurrency; i++) { executorService.submit(new VisitJob(jobContext, testApplication)); } submitLatch.countDown(); @@ -101,7 +101,7 @@ public void testVisitCallerParallelMultipleApplications() throws Exception { final Application testApplication2 = new Application("test2", ServiceType.STAND_ALONE); final Application testApplication3 = new Application("test3", ServiceType.STAND_ALONE); - for (int i = 0; i < concurrency; ++i) { + for (int i = 0; i < concurrency; i++) { if (i % 3 == 0) { executorService.submit(new VisitJob(jobContext, testApplication1)); } else if (i % 3 == 1) { diff --git a/web/src/test/java/com/navercorp/pinpoint/web/vo/stat/chart/DownSamplerTestBase.java b/web/src/test/java/com/navercorp/pinpoint/web/vo/stat/chart/DownSamplerTestBase.java index 29f761279754..f3d00264308a 100644 --- a/web/src/test/java/com/navercorp/pinpoint/web/vo/stat/chart/DownSamplerTestBase.java +++ b/web/src/test/java/com/navercorp/pinpoint/web/vo/stat/chart/DownSamplerTestBase.java @@ -103,7 +103,7 @@ public void sampler_should_sample_correctly_for_single_sample() { private List createSamples(int sampleCount) { List samples = new ArrayList<>(sampleCount); - for (int i = 0; i < sampleCount; ++i) { + for (int i = 0; i < sampleCount; i++) { samples.add(createSample()); } return samples;