|
39 | 39 | has been removed from the public key parsing methods, and proper mutex |
40 | 40 | protection has been added to the cache access in `DisconnectBlockAtHeight`. |
41 | 41 |
|
42 | | -- [Fixed TLV decoders to reject malformed records with incorrect lengths](https://github.com/lightningnetwork/lnd/pull/10249). |
| 42 | +- [Fixed TLV decoders to reject malformed records with incorrect lengths](https://github.com/lightningnetwork/lnd/pull/10249). |
43 | 43 | TLV decoders now strictly enforce fixed-length requirements for Fee (8 bytes), |
44 | 44 | Musig2Nonce (66 bytes), ShortChannelID (8 bytes), Vertex (33 bytes), and |
45 | 45 | DBytes33 (33 bytes) records, preventing malformed TLV data from being |
46 | 46 | accepted. |
47 | 47 |
|
| 48 | +- [Fixed a bug](https://github.com/lightningnetwork/lnd/pull/10487) that could |
| 49 | + cause co-op aux channel closures to become stuck if the aux closer failed to |
| 50 | + broadcast the closing transaction (e.g., due to low fees). The closing |
| 51 | + transaction is now persisted before the aux closer attempts to broadcast, |
| 52 | + ensuring it can be re-broadcast on restart. |
| 53 | + |
48 | 54 | # New Features |
49 | 55 |
|
50 | | -- Basic Support for [onion messaging forwarding](https://github.com/lightningnetwork/lnd/pull/9868) |
| 56 | +- Basic Support for [onion messaging forwarding](https://github.com/lightningnetwork/lnd/pull/9868) |
51 | 57 | consisting of a new message type, `OnionMessage`. This includes the message's |
52 | 58 | definition, comprising a path key and an onion blob, along with the necessary |
53 | 59 | serialization and deserialization logic for peer-to-peer communication. |
|
104 | 110 | ([PR#4704](https://github.com/lightningnetwork/lnd/pull/4704)). Users should |
105 | 111 | migrate to the `--sat_per_vbyte` option, which correctly represents fee rates |
106 | 112 | in terms of virtual bytes (vbytes). |
107 | | - |
| 113 | + |
108 | 114 | Internally `--sat_per_byte` was treated as sat/vbyte, this meant the option |
109 | | - name was misleading and could result in unintended fee calculations. To avoid |
| 115 | + name was misleading and could result in unintended fee calculations. To avoid |
110 | 116 | further confusion and to align with ecosystem terminology, the option will be |
111 | 117 | removed. |
112 | 118 |
|
113 | 119 | The following RPCs will be impacted: |
114 | 120 |
|
115 | | - | RPC Method | Messages | Removed Option | |
| 121 | + | RPC Method | Messages | Removed Option | |
116 | 122 | |----------------------|----------------|-------------| |
117 | 123 | | [`lnrpc.CloseChannel`](https://lightning.engineering/api-docs/api/lnd/lightning/close-channel/) | [`lnrpc.CloseChannelRequest`](https://lightning.engineering/api-docs/api/lnd/lightning/close-channel/#lnrpcclosechannelrequest) | sat_per_byte |
118 | | -| [`lnrpc.OpenChannelSync`](https://lightning.engineering/api-docs/api/lnd/lightning/open-channel-sync/) | [`lnrpc.OpenChannelRequest`](https://lightning.engineering/api-docs/api/lnd/lightning/open-channel-sync/#lnrpcopenchannelrequest) | sat_per_byte |
| 124 | +| [`lnrpc.OpenChannelSync`](https://lightning.engineering/api-docs/api/lnd/lightning/open-channel-sync/) | [`lnrpc.OpenChannelRequest`](https://lightning.engineering/api-docs/api/lnd/lightning/open-channel-sync/#lnrpcopenchannelrequest) | sat_per_byte |
119 | 125 | | [`lnrpc.OpenChannel`](https://lightning.engineering/api-docs/api/lnd/lightning/open-channel/) | [`lnrpc.OpenChannelRequest`](https://lightning.engineering/api-docs/api/lnd/lightning/open-channel/#lnrpcopenchannelrequest) | sat_per_byte |
120 | 126 | | [`lnrpc.SendCoins`](https://lightning.engineering/api-docs/api/lnd/lightning/send-coins/) | [`lnrpc.SendCoinsRequest`](https://lightning.engineering/api-docs/api/lnd/lightning/send-coins/#lnrpcsendcoinsrequest) | sat_per_byte |
121 | 127 | | [`lnrpc.SendMany`](https://lightning.engineering/api-docs/api/lnd/lightning/send-many/) | [`lnrpc.SendManyRequest`](https://lightning.engineering/api-docs/api/lnd/lightning/send-many/#lnrpcsendmanyrequest) | sat_per_byte |
|
126 | 132 |
|
127 | 133 | ## Testing |
128 | 134 |
|
129 | | -* [Added unit tests for TLV length validation across multiple packages](https://github.com/lightningnetwork/lnd/pull/10249). |
| 135 | +* [Added unit tests for TLV length validation across multiple packages](https://github.com/lightningnetwork/lnd/pull/10249). |
130 | 136 | New tests ensure that fixed-size TLV decoders reject malformed records with |
131 | 137 | invalid lengths, including roundtrip tests for Fee, Musig2Nonce, |
132 | 138 | ShortChannelID and Vertex records. |
133 | 139 |
|
134 | 140 | ## Database |
135 | 141 |
|
136 | | -* Freeze the [graph SQL migration |
137 | | - code](https://github.com/lightningnetwork/lnd/pull/10338) to prevent the |
138 | | - need for maintenance as the sqlc code evolves. |
| 142 | +* Freeze the [graph SQL migration |
| 143 | + code](https://github.com/lightningnetwork/lnd/pull/10338) to prevent the |
| 144 | + need for maintenance as the sqlc code evolves. |
139 | 145 |
|
140 | 146 | ## Code Health |
141 | 147 |
|
|
0 commit comments